[nergal]

Originally Posted by rhelgeby I would avoid nesting them, use if-statements in this case (or perhaps a switch-statement). Code readability is more important than saving some lines.

but but but but my laziness implores me to just nest 'em so that i don't have to hit TAB a million times.

[friagram]

Originally Posted by rhelgeby I would avoid nesting them, use if-statements in this case (or perhaps a switch-statement). Code readability is more important than saving some lines.

Switch

[rhelgeby]

Lazy programmers may be haunted by their own code when someone ask for a new feature that apparently isn't that easy to implement - due to code that's hard to read or understand.

[nergal]

Originally Posted by rhelgeby Lazy programmers may be haunted by their own code when someone ask for a new feature that apparently isn't that easy to implement - due to code that's hard to read or understand.

What if I format it to be readable?

PHP Code:

public MenuHandler_SetLulz(Handle:menu, MenuAction:action, client, param2) 
{ 
    decl String:menuitem[64]; 
    new int; 
    GetMenuItem(menu, param2, menuitem, sizeof(menuitem)); 
    if (action == MenuAction_Select) 
        { 
                param2++; 
                int = (param2 == 1) ? 1 :
                       ((param2 == 2) ? 2 : 
                       ((param2 == 3) ? 3 : 
                       0));

                PrintNumber(client, int); 
    } 
    else if (action == MenuAction_End) 
        { 
        CloseHandle(menu); 
    } 
} 


[hamza47sohail]

Originally Posted by nergal What if I format it to be readable? PHP Code: public MenuHandler_SetLulz(Handle:menu, MenuAction:action, client, param2)  {      decl String:menuitem[64];      new int;      GetMenuItem(menu, param2, menuitem, sizeof(menuitem));      if (action == MenuAction_Select)          {                  param2++;                  int = (param2 == 1) ? 1 :                        ((param2 == 2) ? 2 :                         ((param2 == 3) ? 3 :                         0));                 PrintNumber(client, int);      }      else if (action == MenuAction_End)          {          CloseHandle(menu);      }  }

"Procrastination is just like masturbating sure it feels good. But in the end you are only fu*king yourself." - SourceBans.

[Powerlord]

Which is easier to read? Which is easier to update?

PHP Code:

                   int = (param2 == 1) ? 1 :
                       ((param2 == 2) ? 2 : 
                       ((param2 == 3) ? 3 : 
                       0)); 


or

PHP Code:

                   switch(param2) {
                       case 1: int = 1;
                       case 2: int = 2;
                       case 3: int = 3;
                       default: int = 0;
                   } 


(the obvious answer is one of these, but the above two are there for arguments sake)

PHP Code:

                   int = (param2 >= 1 && param2 <= 3) ? param2 : 0; 


PHP Code:

                   switch(param2) {
                       case 1, 2, 3: int = param2;
                       default: int = 0;
                   } 


Now, if you want multiple statements per case, you end up having to put in more { } pairs, which afact is a quirk of Pawn as its the only language I've seen that needs them. Probably has to do with not using break in case statements in Pawn.