[Supremache]

Hi There,
I tried to combining the menus together, but my code doesn't work what is the wrong ?

enum _:eMenuType {
    
    CHECK_RANK,
    RESET_RANK,
    MANAGE_RANK
};


public PlayerRank(id, iLevel, iCid)
{
    if(!cmd_access(id, iLevel, iCid, 1))
    {
        return PLUGIN_HANDLED
    }
    new iPlayers[MAX_PLAYERS], iPnum, szUserID[32], szTitle[128], iMenu 
    
    switch ( iMenu )
    {
        case CHECK_RANK:
        {
            MenuTitle("\yRank System: \rXP List")
        }
        case RESET_RANK:
        {
            MenuTitle("\yRank System: \rReset Data")
        }
        case MANAGE_RANK:
        {
            MenuTitle("\yRank System: \rManage Players")
        }
    }
    
    iMenu = menu_create(szTitle, "Handler")
    get_players(iPlayers, iPnum, "ch"); SortCustom1D(iPlayers, iPnum, "sort_players_by_xp")
    
    for(new szItem[1024], iPlayer, i; i < iPnum; i++)
    {
        iPlayer = iPlayers[i]
        
        MenuInfo("\d[%i XP] \w%s \r[\yLevel %i: %s\r]")
        formatex( szUserID, charsmax( szUserID ), "%d", get_user_userid(iPlayer))
        menu_additem(iMenu, szItem, szUserID)
    }
    
    menu_setprop(iMenu, MPROP_BACKNAME, "Previous page")
    menu_setprop(iMenu, MPROP_NEXTNAME, "Next page")
    menu_setprop(iMenu, MPROP_EXITNAME, "\rClose")

    menu_display(id, iMenu)
    return PLUGIN_HANDLED
}


public Handler(id, iMenu, iItem)
{
    new iAccess, iCallback, iData[6],iName[64];
    
    menu_item_getinfo(iMenu, iItem, iAccess, iData, charsmax(iData), iName, charsmax(iName), iCallback);
    
    new iPlayer = str_to_num(iData);
    
    switch ( iMenu )
    {
        case CHECK_RANK:
        {
            return PLUGIN_HANDLED
        }
        case RESET_RANK:
        {
            if(get_user_flags(id) & eResetDataFlag)
            {
                ResetPlayerRank(id, iPlayer);
                Print(id, "[Rs] You don't have access.");
            }
        }
        case MANAGE_RANK:
        {
            if(get_user_flags(id) & eManagePlayer)
            {
                ChoosePlayerRank(id, iPlayer);
                Print(id, "[Rs] You don't have access.");
            }
        }
    }
    menu_destroy(iMenu)
    return PLUGIN_HANDLED
}

[fysiks]

The first thing I notice is that you're using the variable iMenu for two entirely different purposes at the same time which is not possible. Your menu type and the menu pointer used with the menu_*() functions cannot use the same variable.

However, the first question that you should ask yourself is, why would you combine these menus if you're not keeping their functionality completely separate (via the menu type) anyways? As it is, without any other reason, it looks like you shouldn't even attempt combining menus like this. If you have some reason to do it, you should explain because that will help us help you get to the best result.

Also, MenuTitle() is not an AMX Mod X function, what does it do?

[Supremache]

Originally Posted by fysiks The first thing I notice is that you're using the variable iMenu for two entirely different purposes at the same time which is not possible. Your menu type and the menu pointer used with the menu_*() functions cannot use the same variable. However, the first question that you should ask yourself is, why would you combine these menus if you're not keeping their functionality completely separate (via the menu type) anyways? As it is, without any other reason, it looks like you shouldn't even attempt combining menus like this. If you have some reason to do it, you should explain because that will help us help you get to the best result.

I created other variable but it didn't work.

There's three commands on my plugin using the same style of menu for getting online players why i add same menu three times for three commands and there's way to make one menu for these commands.

Originally Posted by fysiks Also, MenuTitle() is not an AMX Mod X function, what does it do?

I did defines for formatex:

#define MenuInfo(%1) formatex(szItem, charsmax(szItem), %1, g_iPlayerXP[iPlayer], szPlayerName[iPlayer], g_iPlayerLevel[iPlayer], g_mPlayerData[ g_iPlayerLevel[iPlayer]][m_szRankName]);
#define MenuTitle(%1)  formatex(szTitle,charsmax(szTitle), %1) 

[fysiks]

You have to set and keep track of the the menu type for all players (e.g. in a global variable) which you are not even attempting to do. So, currently the handler doesn't know how to handle a menu item selection. Also, you shouldn't be checking flags in the handler, check them before you show the menu and don't show the menu at all if they don't have access.

Finally, you're printing a message saying "you don't have access" even though you just performed the action.

[Supremache]

Originally Posted by fysiks you shouldn't be checking flags in the handler, check them before you show the menu and don't show the menu at all if they don't have access..

Oops, i will fix that !

Originally Posted by fysiks You have to set and keep track of the the menu type for all players (e.g. in a global variable) which you are not even attempting to do. So, currently the handler doesn't know how to handle a menu item selection. Finally, you're printing a message saying "you don't have access" even though you just performed the action.

I don't want to do this, an example for what i want to do is adding three commands for one menu:

 Calling same function
    register_clcmd( "say /manage", "PlayerRank", ADMIN_RCON);
    register_clcmd( "say /rr", "PlayerRank", ADMIN_RCON );  
    register_clcmd( "say /xplist", "PlayerRank", ADMIN_ALL );

public PlayerRank(id, iLevel, iCid)
{
 Check who can use that command
    if(!cmd_access(id, iLevel, iCid, 1))
    {
        return PLUGIN_HANDLED
    }
    new iPlayers[MAX_PLAYERS], iPnum, szUserID[32], szTitle[128], iMenu 
    
 Check which command did player chose
 if user use "/manage, /rr ,/xplist" command will open the same menu and calling the same handler
    switch ( iMenu )
    {
        case CHECK_RANK:
        {
            MenuTitle("\yRank System: \rXP List")
        }
        case RESET_RANK:
        {
            MenuTitle("\yRank System: \rReset Data")
        }
        case MANAGE_RANK:
        {
            MenuTitle("\yRank System: \rManage Players")
        }
    }
    
    iMenu = menu_create(szTitle, "Handler")
    get_players(iPlayers, iPnum, "ch"); SortCustom1D(iPlayers, iPnum, "sort_players_by_xp")
    
    for(new szItem[1024], iPlayer, i; i < iPnum; i++)
    {
        iPlayer = iPlayers[i]
 EX: [ Player XP ] Player Name [ LvL , Rank ]
        MenuInfo("\d[%i XP] \w%s \r[\yLevel %i: %s\r]")
        formatex( szUserID, charsmax( szUserID ), "%d", get_user_userid(iPlayer))
        menu_additem(iMenu, szItem, szUserID)
    }
    
    menu_setprop(iMenu, MPROP_BACKNAME, "Previous page")
    menu_setprop(iMenu, MPROP_NEXTNAME, "Next page")
    menu_setprop(iMenu, MPROP_EXITNAME, "\rClose")

    menu_display(id, iMenu)
    return PLUGIN_HANDLED
}

public Handler(id, iMenu, iItem)
{
    new iAccess, iCallback, iData[6],iName[64];
    
    menu_item_getinfo(iMenu, iItem, iAccess, iData, charsmax(iData), iName, charsmax(iName), iCallback);
    
    new iPlayer = str_to_num(iData);
    
    switch ( iMenuMode )
    {
        case CHECK_RANK:
        {
 If user use /xplist command and choose player will close the menu
            return PLUGIN_HANDLED
        }
        case RESET_RANK:
        {
 If user use  /rr command and choose player will reset his data
            ResetPlayerRank(id, iPlayer);
        }
        case MANAGE_RANK:
        {
 If user use /manage command and choose player will open new menu have all ranks and select which rank want to change that player to
            ManagePlayerRank(id, iPlayer);
        }
    }
    menu_destroy(iMenu)
    return PLUGIN_HANDLED
}

[fysiks]

Originally Posted by Supremache I don't want to do this

Why? If you have a better way that works then you should do that. If you "want" (even though it's unnecessary) to have the same handler, you have to have some deterministic, reliable method for indicating what command to run in the handler. Otherwise, use three different handlers, one for each menu type. I can't think of any good reason to use the same handler ("using less code" and "because I want to" are not a good reasons).

[Supremache]

I want to do this because i see this idea is better for being easy for who want to edit it until i do ini file.
If there some one doesn't have any expriance on scripting and want to edit it will not search between menus, which menu for this command plus fixing hard codding.

I saw this idea made before on plugin but i didn't found that plugin, plz if you have any idea how to do this tell me!

[fysiks]

If you wanted to make it "easy" for beginners (not a good goal) then you would make three completely separate menus. Just implement something that works (you've been given several options) and then you can modify it later.

Even if it is possible to do what you want to do (still not really sure what you're talking about) it will most likely be more complex anyways.

[jimaway]

pass your menu type to the handler in the item info field along with the userid

[Natsheh]

Destroy the menu right after retrieving the info there is no need to keep it alive.

Also dont be shy to post the whole code no ones gonna steal anything its not that well coded either.