[nergal]

Originally Posted by abrandnewday This x1000. I've actually pushed myself to learn to use StringMaps, ArrayLists, DataPacks as well as learning to use menus and panels more efficiently under new syntax via the methodmaps. Next up on my list is KeyValues which I am not looking forward to as I've never messed around with while and do before. But I really want to get into making config files for things, so I have to learn it.

do-while loops are loops that you need to run at least once but it can possibly run again.

[404UserNotFound]

Actually, scratch that, I have messed with while a little bit. In my private chat tag plugin I commissioned (then made my own major modifications to), it uses while for the SQL_TQuery's;

PHP Code:

while (SQL_FetchRow(hHandle))
{
    int iID = SQL_FetchInt(hHandle, 0);
    
    char sTag[256];
    SQL_FetchString(hHandle, 1, sTag, sizeof(sTag));
    
    char sID[12];
    IntToString(iID, sID, sizeof(sID));
    
    char sDisplayName[256];
    SQL_FetchString(hHandle, 2, sDisplayName, sizeof(sDisplayName));
    
    if (strlen(sTag) > 0)
    {
        hTagsTrie.SetString(sID, sTag);
        hDisplayTrie.SetString(sID, sDisplayName);
    }
} 


But no, I've not messed with do-while loops (like in keyvalues for config files) very much as I've never done any config file stuff for my plugins.

[ThatOneGuy]

Originally Posted by abrandnewday This x1000. I've actually pushed myself to learn to use StringMaps, ArrayLists, DataPacks as well as learning to use menus and panels more efficiently under new syntax via the methodmaps. Next up on my list is KeyValues which I am not looking forward to as I've never messed around with while and do before. But I really want to get into making config files for things, so I have to learn it.

Here's you a sample bit of code to get started. You can find everything else you need in the API.
https://sm.alliedmods.net/new-api/keyvalues/KeyValues

Spoiler

PHP Code:

public void LoadCfg()
{
    if(!FileExists(g_sPath))        //global variable with cfg filepath
    {
        SetFailState("Configuration file %s not found!", g_sPath);
        return;
    }

    KeyValues oKeyValues = new KeyValues("Setups");        //Setups is the text at the very top before the first opening bracket

    if(!oKeyValues.ImportFromFile(g_sPath))
    {
        SetFailState("Improper structure for configuration file: %s!", g_sPath);
        return;
    }

    if(!oKeyValues.GotoFirstSubKey(true))
    {
        SetFailState("Can't find first subkey in configuration file: %s!", g_sPath);
        return;
    }

    do
    {
        char sSectionName[100], sBuffer[100];
        oKeyValues.GetSectionName(sSectionName, sizeof(sSectionName));    //if you need the section name
        //Do stuff
        
        oKeyValues.GetString("somekey1", sBuffer, sizeof(sBuffer), "somedefaulttext1");        //somedefaulttext1 is the default if the key isnt found
        //Do stuff
        
        oKeyValues.GetString("somekey2", sBuffer, sizeof(sBuffer));        //blank text is the default if the key isnt found
        //Do stuff
        
        int iSomeInt = oKeyValues.GetNum("somekey3", 0)    //0 is the default if the key isnt found
        //Do stuff
    }
    while(oKeyValues.GotoNextKey(false));
    delete oKeyValues;
} 


Here would be an example cfg to go with that:

Spoiler

PHP Code:

"Setups"
{
    "Some Section Name"
    {
        "somekey1"        "Some Text Value"
        "somekey2"        "Another Text Value"
        "somekey3"        "1"
    }
    
    "Another Section Name"
    {
        "somekey1"        "Blah"
        "somekey2"        "Stuff"
        "somekey3"        "10"
    }
} 


[404UserNotFound]

Ooh, that's some good info. I've got an idea of how to write up the actual configs, it's just a matter of working backwards and figuring out how to code the functions to make the config file work how I want it to. Thanks

Side question: Regarding this bit:

PHP Code:

KeyValues oKeyValues = null;
oKeyValues = new KeyValues("Setups"); 


Is this something I should be doing? I usually do this:

PHP Code:

KeyValues oKeyValues = new KeyValues("Setups"); 


[ThatOneGuy]

Originally Posted by abrandnewday Ooh, that's some good info. I've got an idea of how to write up the actual configs, it's just a matter of working backwards and figuring out how to code the functions to make the config file work how I want it to. Thanks Side question: Regarding this bit: PHP Code: KeyValues oKeyValues = null; oKeyValues = new KeyValues("Setups");  Is this something I should be doing? I usually do this: PHP Code: KeyValues oKeyValues = new KeyValues("Setups");

Yes. That was a relic of some code that I put together a while back and haven't updated that part. I'll update my previous post just now. I'm not sure why I did it that way for that plugin.

[404UserNotFound]

Ah, so it is the old way. Makes sense.

[ddhoward]

It's not the old way. It's just a longer way of doing the same thing.

PHP Code:

int someResult; //or " int someResult = 0; "
someResult = someFunction(); 


as opposed to

PHP Code:

int someResult = someFunction(); 


The old way of creating a new KeyValues structure would be something like this:

PHP Code:

new Handle:oKeyValues = CreateKeyValues("Setups"); 


[headline]

Originally Posted by ddhoward -snip-

This^

It is the longer way, but personally I think it often times looks much cleaner to separate var declaration from it's initialization when I have a bunch of things that way it's a little easer to see. Just a matter of preference.

I do it more in java than sourcemod

Java

PHP Code:

    // DESCRIPTION: Gets an employees information from user
    // PRECONDITION: Keyboard is instanciated
    // POSTCONDITION: Employee array is returned
    public static Employee[] getEmployees(Scanner keyboard)
    {
        Employee[] employees;
        int employeeCount;
        
        String name;
        char lead;
        double startTime, endTime, wage;
        
        System.out.println();
        System.out.println();
        
        System.out.println("How many employees are working today?");
        employeeCount = Cs111.readInt("Enter employee count: ", keyboard, 2, 15);
        
        employees = new Employee[employeeCount];
        System.out.println();
        
        for (int i = 0; i < employeeCount; i++)
        {
            System.out.print("Please enter employee #" + (i+1) + "'s name: ");
            name = keyboard.nextLine();

            System.out.print("Please enter " + name + "'s starting time: ");
            startTime = Employee.formatTime(keyboard.nextLine());

            System.out.print("Please enter " + name + "'s end time: ");
            endTime = Employee.formatTime(keyboard.nextLine());

            System.out.print("Is " + name + " a lead? (y/n): ");
            lead = keyboard.nextLine().charAt(0);
            if (lead == 'y')
            {
                wage = 11.75;
            }
            else
            {
                wage = 10.0;
            }
            System.out.println();

            employees[i] = new Employee(name, startTime, endTime, wage);
        }
        
        Employee[] newEmployees;
        
        newEmployees = new Employee[employeeCount];
        for (int i = 0; i < employeeCount; i++)
        {
            newEmployees[i] = new Employee(employees[i]);
        }
        
        return newEmployees;
    } 


[Timocop]

Will 'decl' have a comeback or is there a heuristic in the compiler now?

[ddhoward]

Originally Posted by Timocop Will 'decl' have a comeback or is there a heuristic in the compiler now?

The consensus is that decl is pretty pointless, is dangerous, was a mistake to have implemented into SourcePawn in the first place, and if what you're doing actually requires decl to perform adequately, then an alternative to what you're doing should be found (such as making the variable static/global if possible, etc.)