[Mitchell]

Originally Posted by asherkin While, yes, that if..elseif..else list is ugly, there is magical syntax to help for that case: PHP Code: switch (PlayerSettings[client][MClass]) {   case MatMClass_Traitor:     PrintToChat(client, "You are a traitor this round!");   case MatMClass_Detective:     PrintToChat(client, "You are a detective this round!");   default:     PrintToChat(client, "You are an innocent this round!"); }  Which, imo, looks considerably better than both, and still covers the a/an case.

Yes, i agree looks alot better than a bunch of ifs.
covering the 'an' for innocent.

PrintToChat(client, "You are a%s this round!", (PlayerSettings[client][MClass] == MatMClass_Traitor) ? " Traitor" : (PlayerSettings[client][MClass] == MatMClass_Detective) ? " Detective" : "n Innocent");

[turtsmcgurts]

Originally Posted by Mitchell -snip- i was going to show an example in python, but nvm all i would be doing is changing a one line to 3 lines.. It's better to break up if-statements into methods to handle them, making the code look less bulky in one huge functions. I just hate having to do: instead of:

Assuming what you want is exactly like you posted (one liners), this looks far better imo.

if(PlayerSettings[client][MClass] == MatMClass_Traitor)
	PrintToChat(client, "You are a traitor this round!");
else if(PlayerSettings[client][MClass] == MatMClass_Detective)
	PrintToChat(client, "You are a detective this round!");
else
	PrintToChat(client, "You are an innocent this round!");

[Powerlord]

Ternaries tend to be harder to read. You could (at the cost of a variable) do something like this:

PHP Code:

decl String:bacon[15];

switch (PlayerSettings[client][MClass])
{
  case MatMClass_Traitor:
    bacon = " traitor";
  case MatMClass_Detective:
    bacon = " detective";
  default:
    bacon = "n innocent";
}

PrintToChat(client, "You are a%s this round!", bacon); 


Or more likely using Format commands with %T because you'd be using translation phrases, right?

[Mitchell]

Originally Posted by Powerlord Ternaries tend to be harder to read. You could (at the cost of a variable) do something like this: PHP Code: decl String:bacon[15]; switch (PlayerSettings[client][MClass]) {   case MatMClass_Traitor:     bacon = " traitor";   case MatMClass_Detective:     bacon = " detective";   default:     bacon = "n innocent"; } PrintToChat(client, "You are a%s this round!", bacon);  Or more likely using Format commands with %T because you'd be using translation phrases, right?

yeahh.. i still need to look up on doing that with color chat for moar customization.

[friagram]

Magic operator that lets you initialize variables without declaring needless intermediate variables.

[captaindeterprimary]

wtf = What the fudge
? = a punctuation mark (?) indicating a question

[rhelgeby]

It's fine to use ternary operators, as long as you're using them "correctly". They are useful for selecting one of two values:

PHP Code:

new bool:speedEnabled = IsSpeedEnabled();
new speedBoost = GetSpeedBoost();
new defaultSpeed = GetDefaultSpeed();

new speed = speedEnabled ? speedBoost : defaultSpeed; 


Note that I only refer to variables. Avoid doing function calls on the line using the ternary operators, otherwise you'll do two things on the same line and disrupt readability.

[nergal]

Originally Posted by rhelgeby It's fine to use ternary operators, as long as you're using them "correctly". They are useful for selecting one of two values: PHP Code: new bool:speedEnabled = IsSpeedEnabled(); new speedBoost = GetSpeedBoost(); new defaultSpeed = GetDefaultSpeed(); new speed = speedEnabled ? speedBoost : defaultSpeed;  Note that I only refer to variables. Avoid doing function calls on the line using the ternary operators, otherwise you'll do two things on the same line and disrupt readability.

expanding on this, what if I used them for menus?

PHP Code:

public MenuHandler_SetLulz(Handle:menu, MenuAction:action, client, param2) 
{ 
    decl String:menuitem[64]; 
    new int; 
    GetMenuItem(menu, param2, menuitem, sizeof(menuitem)); 
    if (action == MenuAction_Select) 
        { 
                param2++; 
                int = (param2 == 1) ? 1 : ((param2 == 2) ? 2 : ((param2 == 3) ? 3 : 0)); 
                PrintNumber(client, int); 
    } 
    else if (action == MenuAction_End) 
        { 
        CloseHandle(menu); 
    } 
} 


[^SmileY]

PrintToChat(iClient,"You is %s",(IsFakeClent(iClient) == true) ? "BOT" : "PLAYER");

You can compare variables (Like an IF) but implementing directly in code, Ah yeah you can concatenate strings too.

(Condition) ? true_value : false_value

[rhelgeby]

Originally Posted by nergal PHP Code: int = (param2 == 1) ? 1 : ((param2 == 2) ? 2 : ((param2 == 3) ? 3 : 0));

I would avoid nesting them, use if-statements in this case (or perhaps a switch-statement). Code readability is more important than saving some lines.