[SamuraiBarbi]

Does anyone have any idea why I can't return this string value? This is something I wrote real quick just to make sure I could return string values, but when I compile it says tag mismatch on line 43.

#pragma semicolon 1



#include <sourcemod>
#include <sdktools>
#include <sdktools_trace>
#include <clients>
#include <hacks>


    public OnPluginStart()
    {
        HookEvent("weapon_fire", Event_WeaponFire, EventHookMode_Pre);

    }

    public Action:Event_WeaponFire(Handle:event, const String:name[], bool:dontBroadcast)
    {
        new target_playerID = GetEventInt(event,"userid");
        new target_playerClient = GetClientOfUserId(target_playerID);
        
        PrintToChatAll("%s", GetPlayerName(target_playerClient));
    }

    GetPlayerName(any:target_playerClient)
    {
        new String:target_playerName[20];
        GetClientName(target_playerClient,target_playerName,sizeof(target_playerName));

        return target_playerName;
    }

[pheadxdll]

That's because you can't return strings in SourcePawn. I'd recommend just scrapping the function because there's GetClientName.

[SamuraiBarbi]

Thx, I know there's GetClientName, like I said this is just something I wrote to check if I could return a string. That can't possibly be right though. We can't return strings in SourcePawn? That's dumb. Why not?

[BAILOPAN]

SamuraiBarbi: It's supposed to work in some situations, in others its impossible. Your usage looks okay, the only problem is the tag mismatch - the compiler looks like it has a bug with tagged return arrays.

Feel free to file.

Impossible situations are: publics/natives returning strings, or trying to call a string-return into a mismatched, dynamic, or automatically sized array. there may be more.

[SamuraiBarbi]

Ah okie dokies! Thx again phread for letting me know and Bailopan for shedding more details on the matter.

[naris]

You can't return strings because strings are arrays and you can't return arrays, you can only return a single cell.

(Also, the function would have to be defined as String:GetPlayerName() to avoid a tag mismatch, but that's not sufficient since it really is a String array and you can define a String[]:function())

Also, even if you could return an array, this code would not work since you are attempting to return a local array (that exists on the stack), which is freed when the function returns (that would leave a dangling pointer, if pawn had pointers).

What you have to do is define the function like all the other sourcemod function that "return" strings, by passing the string and max length and copying the string to the result

    GetPlayerName(any:target_playerClient, String:name[], maxlength)
    {
        new String:target_playerName[20];
        GetClientName(target_playerClient,target_playerName,sizeof(target_playerName));

        strcopy(name, maxlength, target_playerName;
    }

[naris]

Originally Posted by BAILOPAN Your usage looks okay, the only problem is the tag mismatch

Wouldn't "returning" a reference to a local variable be a problem?