[Bitl]

Today I was working on a gamemode and testing it with bots when I seen the crash error "ED_Alloc: no free edicts"

Is there anything in this code that triggered this?

#include <sourcemod>
#include <sdktools>
#include <sdkhooks>
#include <tf2>
#include <tf2_stocks>
#include <tf2items_giveweapon>
#undef REQUIRE_PLUGIN
#tryinclude <tf2itemsinfo>

#if !defined _tf2itemsinfo_included
new TF2ItemSlot = 8;
#endif

new Handle:sm_spyscreed_maxspies;
new Handle:sm_spyscreed_itemid;

public Plugin:myinfo = 
{
    name = "[TF2] Spy's Creed",
    author = "Bitl",
    description = "Move or be killed.",
    version = "1.0",
    url = ""
}

public OnPluginStart()
{
    CheckGame();
    
    HookEvent("player_spawn", event_Spawn, EventHookMode_Pre);
    HookEvent("post_inventory_application", event_inventory);
    sm_spyscreed_maxspies = CreateConVar("sm_spyscreed_maxspies", "1", "Max amount of spies to be on the BLU team.", FCVAR_NOTIFY);
    sm_spyscreed_itemid = CreateConVar("sm_spyscreed_itemid", "99999", "Item ID for cloaking device.", FCVAR_NOTIFY);
    AutoExecConfig(true, "spyscreed");
}

public OnAllPluginsLoaded()
{
        TF2Items_CreateWeapon( GetConVarInt(sm_spyscreed_itemid), "tf_weapon_invis", 297, 4, 9, 10, "160 ; 1 ; 35 ; 20 ; 34 ; -10 ; 414 ; 1", -1, _, true );
}

CheckGame()
{
    decl String:strModName[32]; GetGameFolderName(strModName, sizeof(strModName));
    if (StrEqual(strModName, "tf")) return;
    SetFailState("[SM] This plugin is only for Team Fortress 2.");
}

public event_Spawn(Handle:event, const String:name[], bool:dontBroadcast)
{    
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    
    new iClients[MaxClients+1];
    new iNumClients;
    
    for(new i=1; i<=MaxClients; i++)
    {
        if(IsClientInGame(i) && IsPlayerAlive(i))
        {
            iClients[iNumClients++] = i;
        }
    }
    
    new iRandomClient = iClients[GetRandomInt(0, iNumClients-1)];
    new maxspies = 0;
    
    if (client == iRandomClient)
    {
        TF2_SetPlayerClass(client, TFClass_Spy);
        for( new iSlot = 0; iSlot < _:TF2ItemSlot; iSlot++ )
        TF2_RemoveWeaponSlot(client, iSlot );
        TF2_RemoveWeaponSlot(client, 0);
        TF2_RemoveWeaponSlot(client, 1);
        TF2_RemoveWeaponSlot(client, 3);
        ChangeClientTeam(client, _:TFTeam_Blue);
        TF2Items_GiveWeapon(client, 638);
        TF2Items_GiveWeapon(client, GetConVarInt(sm_spyscreed_itemid)); 
        maxspies +=1;
        if (maxspies == GetConVarInt(sm_spyscreed_maxspies))
        {
            ChangeClientTeam(client, _:TFTeam_Red);
        }
    }
    else
    {
        ChangeClientTeam(client, _:TFTeam_Red);
    }
}

public event_inventory(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if (GetClientTeam(client) == 3)
    {
        for( new iSlot = 0; iSlot < _:TF2ItemSlot; iSlot++ )
        TF2_RemoveWeaponSlot(client, iSlot );
        TF2_RemoveWeaponSlot(client, 0);
        TF2_RemoveWeaponSlot(client, 1);
        TF2_RemoveWeaponSlot(client, 3);
        TF2Items_GiveWeapon(client, 638); 
        TF2Items_GiveWeapon(client, GetConVarInt(sm_spyscreed_itemid));
    }
}

Thanks.

[friagram]

Lol.. Them for loops. Why are you removing 9 item slots in a loop, and then 3 more after?
http://docs.sourcemod.net/api/index....d=show&id=858&

Dont use giveweapon? It does tonshit of thnings, and is probably not freeing entities properly, who knows. Regardless, there is no reason not to, use tf2 items api directly. This is all the wrong ways to make a plugin

[Bitl]

Originally Posted by friagram Lol.. Them for loops. Why are you removing 9 item slots in a loop, and then 3 more after? http://docs.sourcemod.net/api/index....d=show&id=858& Dont use giveweapon? It does tonshit of thnings, and is probably not freeing entities properly, who knows. Regardless, there is no reason not to, use tf2 items api directly. This is all the wrong ways to make a plugin

Thanks.

I use Give Weapon because it is easier to give the weapons to the player. I'll try using the API this time.

[Leonardo]

do you kniow that programmers are lazy people?
so if some code is repeated somethere more that one - then it's better to use some functions instead.
I mean this part:

        for( new iSlot = 0; iSlot < _:TF2ItemSlot; iSlot++ )
        TF2_RemoveWeaponSlot(client, iSlot );
        TF2_RemoveWeaponSlot(client, 0); // oh my
        TF2_RemoveWeaponSlot(client, 1); // dude
        TF2_RemoveWeaponSlot(client, 3); // why?

also, what's the point of 'maxspies'?
also2, do you know that ChangeClientTeam will slay player? so giving weapons before or at same frame with ChangeClientTeam is useless.

[friagram]

Originally Posted by Leonardo do you kniow that programmers are lazy people? so if some code is repeated somethere more that one - then it's better to use some functions instead. I mean this part: for( new iSlot = 0; iSlot < _:TF2ItemSlot; iSlot++ ) TF2_RemoveWeaponSlot(client, iSlot ); TF2_RemoveWeaponSlot(client, 0); // oh my TF2_RemoveWeaponSlot(client, 1); // dude TF2_RemoveWeaponSlot(client, 3); // why? also, what's the point of 'maxspies'? also2, do you know that ChangeClientTeam will slay player? so giving weapons before or at same frame with ChangeClientTeam is useless.

Did u see that new TF2ItemSlot = 8 ?

[Leonardo]

Originally Posted by friagram Did u see that new TF2ItemSlot = 8 ?

so?
this is my vision of ЯEALITY

[HKAnson]

That is already a looping code,

TF2_RemoveWeaponSlot(client, 0); // oh my
TF2_RemoveWeaponSlot(client, 1); // dude
TF2_RemoveWeaponSlot(client, 3); // why?
ALREADY DUPLICATED