[Kitami]

When an admin in our server tries to ban someone, once they are banned they can rejoin again, and again, and again. Is there a problem with my setup or is this a real glitch.

AMXMODX List

----- Currently loaded plugins ----- name version author file status Admin Base 1.8.1.3746 AMXX Dev Team admin.amxx running Command Limits 1.0 Lee limiterplugin.a running Admin Commands 1.8.0.3660 AMXX Dev Team admincmd.amxx running Menus Front-End 1.8.0.3660 AMXX Dev Team menufront.amxx running Players Menu 1.8.1.3746 AMXX Dev Team plmenu.amxx running Maps Menu 1.8.1.3746 AMXX Dev Team mapsmenu.amxx running Admin Chat 1.8.1.3746 AMXX Dev Team adminchat.amxx running Anti Flood 1.8.1.3746 AMXX Dev Team antiflood.amxx running Scrolling Message 1.8.1.3746 AMXX Dev Team scrollmsg.amxx running Info. Messages 1.8.1.3746 AMXX Dev Team imessage.amxx Admin Votes 1.8.1.3746 AMXX Dev Team adminvote.amxx running NextMap 1.8.1.3746 AMXX Dev Team nextmap.amxx running Nextmap Chooser 1.8.1.3746 AMXX Dev Team mapchooser.amxx running TimeLeft 1.8.1.3746 AMXX Dev Team timeleft.amxx running Stats Configurati 1.8.1.3746 AMXX Dev Team statscfg.amxx running Restrict Weapons 1.8.1.3746 AMXX Dev Team restmenu.amxx running StatsX 1.8.1.3746 AMXX Dev Team statsx.amxx running CS Misc. Stats 1.8.1.3746 AMXX Dev Team miscstats.amxx running Admin Chat Colors 2.0 Arion admin_chat_colo running Ak47 1.0 Jim amx_ak47me.amxx running Awp 1.0 Jim amx_awpme.amxx running M4A1 1.0 Jim amx_m4a1me.amxx running Anti-Silent Plant 1.5 SubStream antisilentplant running Anti Silent Run 0.1.2 VEN antisilentrun.a running Bad Camper 1.4 beta Brad Jones bad_camper.amxx running Dead Alltalk 0.1 Exolent deadchat.amxx running Clan Vs. All 2.0 GHW_Chronic GHW_Clan_vs_All running Flashbang Dynamic 0.20 Avalanche flashbang_dligh running i aim good 0.17 Avalanche iag_x1.amxx running AMXX Public serve 1.20 Priski public_rules.amxx running Sniper Rifle Cont 1.2 WillyumYum sniper_control. running FUSION Spec-Fix 1.0 Gray Death specbugfix.amxx running RainySnowy 2.0y OneEyed & teame0 rainysnowy.amxx running Admin Tag Enforce 1 atambo tagprotect.amxx running Unlimited Money 2.0 NL)Ramon(NL unlimited_money running WalkGuard 1.3.2 mogel walkguard.amxx running UAIO (Admin Menu) 1.50 xeroblood/$uicid uaio_admin.amxx running UAIO Manager 2.1 $uicid3 uaio_manager.amxx running

Meta List

Currently running plugins: [ 1] AMX Mod X, v1.8.1.3746, Aug 16 2008, by AMX Mod X Dev Team, see http://www.amxmodx.org [ 2] POD-Bot mm, v3.0B20a, Oct 1 2008, by Count Floyd & Bots United, see http://www.bots-united.com [ 3] NoSeeVar, v1.21, 04/05/2004, by BuzzKill <[email protected]>, see http://www.100acrebloodbath.com [ 4] SBSRV, v3.5.5, Jun 24 2008, by Leff, Kevin, devicenull & Spectral, see http://www.steambans.com/ [ 5] Fun, v1.8.0.3660, Oct 25 2007, by AMX Mod X Dev Team, see http://www.amxmodx.org [ 6] Engine, v1.8.0.3660, Oct 25 2007, by AMX Mod X Dev Team, see http://www.amxmodx.org [ 7] FakeMeta, v1.8.0.3660, Oct 25 2007, by AMX Mod X Dev Team, see http://www.amxmodx.org [ 8] CStrike, v1.8.0.3660, Oct 25 2007, by AMX Mod X Dev Team, see http://www.amxmodx.org [ 9] CSX, v1.8.0.3660, Oct 25 2007, by AMX Mod X Dev Team, see http://www.amxmodx.org/

[Exolent[jNr]]

Use this.

[Kitami]

I would rather not use a new mod, amx_ban would always work for the last 2 years ive been using amxmodx, just wondering whats going on now.

I dont like extra plugins on our server. thanks for the help also.

[Bojangles]

The plugin exolent linked works great. It is the only reliable fix as of right now that I have found. I have had a bug report up for this problem for 2 months with no responses.

https://bugs.alliedmods.net/show_bug.cgi?id=3388

[Exolent[jNr]]

This new ban problem came with the Protocol 48 update.
My ban plugin doesn't use the server's "banid" and "addip" commands.
It manages the bans itself.
Therefore, there are no bugs from the server.

[YamiKaitou]

Originally Posted by Kitami I would rather not use a new mod, amx_ban would always work for the last 2 years ive been using amxmodx, just wondering whats going on now. I dont like extra plugins on our server. thanks for the help also.

Then search around, you might surprise yourself

[Krillin]

Originally Posted by Bojangles The plugin exolent linked works great. It is the only reliable fix as of right now that I have found. I have had a bug report up for this problem for 2 months with no responses. https://bugs.alliedmods.net/show_bug.cgi?id=3388

Same here. We discovered why the bans do not stay. If you use amx_ban, in the end, the only ban added to your list is <STEAM_ID_PENDING> when amx_ban tries to use the command to add the ban. We posted ours back on 11/30/2008. We are the Linux report and you must be the Windows report we saw in there.

Dropped b0bby from server
Reason:  Kicked :"TOO MANY RULE VIOLATIONS (banned for 1440 min)"
L 11/30/2008 - 13:58:14: Ban: "<><STEAM_ID_PENDING><>" was banned "for 1440.00 minutes" by "Console"

https://bugs.alliedmods.net/show_bug.cgi?id=3470

I am about ready to recode this myself and be done with these "New Releases" and wipe my hands of all these troubled-beta-like releases.

I will post back my findings if I am able.

Sincerely,
Krillin

[Krillin]

Originally Posted by Exolent[jNr] Use this.

Q: Why should we "Use this"? "Advanced_Bans" for those who want to know what "THIS" is.
A: It is a nice advanced ban handler for any server which can run AMXMOD-X 1.8.1.xxxx. It has a very detailed Built In amx_banlist, we wonder is everyone has access to this command or just admins only. We feel the command should be accessed by all.

The plmenu.sma is a stock script and plugin. The PLMENU has problems as it is. So why add more fuel to the fire? (new results pending)

We also find that another plugin tries to take over another amx_func only causes even more conflicts.

Sincerely,
Krillin

[UPDATE] We are currently using Advanced_Bans in our server as of now. We must admit, it is a very nice addition to our servers. Thanks for the lead Exolent[jNr]. This plugin makes for a nice welcome addition. Sorry to have doubted your plugin. Congrads on a fantastic plugin!!{/UPDATE]

[YamiKaitou]

Originally Posted by Krillin We also find that another plugin tries to take over another amx_func only causes even more conflicts.

If you do it incorrectly, yes. But, if you put Exo's plugin at the top of the plugins.ini file, it will overwrite the commands that are included in AMXx.

[Krillin]

We did a little digging into and we found out what the problem was. The "amx_ban' is coded to kick the player then ban them. You cannot ban a player after the player has been kicked. We had this theory in the back of our minds but wasn't sure how the plugin handled them. (Store and pass variables). When we saw the code, then modified it and tested it. Wouldn't you know, it worked like a charm! And all on the first try! We tested this on a time ban as well as a permanent ban and it worked PERFECTLY!!

Here is what you can do to fix it:

Find: (Line #441)

	if (reason[0])
		server_cmd("kick #%d ^"%s (%s %s)^";wait;banid ^"%s^" ^"%s^";wait;writeid", userid2, reason, banned, temp, minutes, authid2)
	else
		server_cmd("kick #%d ^"%s %s^";wait;banid ^"%s^" ^"%s^";wait;writeid", userid2, banned, temp, minutes, authid2)

Replace With:

	if (reason[0])
		server_cmd("banid ^"%s^" ^"%s^";wait;writeid;wait;kick #%d ^"%s (%s %s)^"", minutes, authid2, userid2, reason, banned, temp)
	else
		server_cmd("banid ^"%s^" ^"%s^";wait;writeid;wait;kick #%d ^"%s %s^"", minutes, authid2, userid2, banned, temp)

If you do not want to edit the file, we will provide the .sma with the fix attached to this post.

Hope this helps everyone!

Sincerely,
Krillin

[UPDATE]I have discovered another issue with amx_ban from the stock handler. If an admin provides a "REASON" it throws off the line and the STEAM_ID_PENDING is added and I can not figure it out why. I suggest you don't use a REASON in using amx_ban.[/UPDATE]