[SAMURAI16]

Glow Damage v0.1.0

* Details : Makes players glow when damaged.

* Cvars:
glowdamage_type 1/2
1= Random Colors
2= Colors in function by user team : Terro Team and CT Team and if Damage > 15 have some colors,
else if damage > 40 have another colors, etc

* Tests:
- Tested on CS 1.6 with AMXMODX 1.76b

* Required Modules
- Fun & Cstrike

* Credits:
- Doombringer for an fixed on CS Teams
- MaximusBrood for if conditions fixes

[uTg | bigpapajiggs]

Do they stop glowing eventually? Or permanent glow?

[Brad]

The following is your "death_event". Why you call it "death", I don't know.

public death_event()
{
        new r,g,b
 
        new Victim = read_data(0)
        new Damage = get_user_health(Victim)
 
        new CsTeams:playert = cs_get_user_team(Victim)
 
        switch (get_pcvar_num(pcvartype))
        {
                case 1:
                {
                        // random num for r,g,b colors
                        r = random_num(0,255)
                        g = random_num(0,255)
                        b = random_num(0,255)
                }
                case 2:
                {
                        // if is user from Terro team
                        if (playert == CS_TEAM_T && Damage > 40)
                        {
                                r = 255
                                g = 0
                                b = 0
                        }
                        else if(playert == CS_TEAM_T)
                        {
                                r = 255
                                g = 80
                                b = 0
                        }
                        else if(playert == CS_TEAM_T && Damage > 15 && Damage < 40)
                        {
                                r = 200
                                g = 70
                                b = 0
                        }
                        if(playert == CS_TEAM_CT && Damage > 40)
                        {                                                                 
                                r = 0
                                g = 255
                                b = 0         
                        }
                        else if(playert == CS_TEAM_CT)
                        {
                                r = 23
                                g = 243
                                b = 0
                        }
                        else if(playert == CS_TEAM_CT && Damage > 15 && Damage < 50)
                        {
                                r = 0
                                g = 65
                                b = 12
                        }
                }
        }
        playerglow(Victim,r,g,b)
 
        return PLUGIN_CONTINUE;
}

Problems.

• You need to handle the case when the user's team returned is not 1 or 2.
• Your if logic is flawed. The third case for both T and CT will never be reached.
• Your if logic is flawed again. You're forcing the server to check too many cases. For instance, if your first check sees that the player isn't a T, you force the server to check again, twice more, before finally checking if it's a CT.

Did you actually test this?

[SAMURAI16]

-updated . Before this update glow was permanent, now glow are present only when you hit an enemy
Brad how should like codes to not be "flawed"

[Alka]

Gj SAMURAI16 ;) *when i hit a enemy he start glow....but he glow and next round.....and next round......
*When the round end......player must stop glowing and the next round shouldn't glow until he is hit!

[SAMURAI16]

i fixed it now

[Alka]

Now works very fine ..should be approved...

[MaximusBrood]

Originally Posted by SAMURAI16 i fixed it now

No, it's not. You didn't do anything Brad told you.
Your stopglow function was also flawed: you didn't check if the player was still connected.
Fixed code:

/* 
 Glow Damage v0.1.0
 
* Details : Makes players glow when damage. 

* Cvars: 
glowdamage_type 1/2
1= Random Colors
2= Colors in function by user team : Terro Team and CT Team and if Damage > 15 have some colors,
else if damage > 40 have another colors, etc

* Tests:
- Tested on CS 1.6 with AMXMODX 1.76b

* Required Modules
- Fun & Cstrike

* Credits:
- Doombringer for an fixed on CS Teams 

Have a nice day now
*/

#include <amxmodx>
#include <fun>
#include <cstrike>
 
new const PLUGIN[] = "Glow Damage"
new const VERSION[] = "0.1.0"
new const AUTHOR[] = "SAMURAI"
 
new pcvartype;
 
public plugin_init() 
{
        register_plugin(PLUGIN, VERSION, AUTHOR)
        pcvartype = register_cvar("glowdamage_type","1")
        register_event("Damage","glow_event","b","2!0","3=0","4!0")
         
}
 

 
public glow_event()
{
        new r,g,b
 
        new Victim = read_data(0)
        new Damage = get_user_health(Victim)
 
        new CsTeams:playert = cs_get_user_team(Victim)
 
        switch (get_pcvar_num(pcvartype))
        {
                case 1:
                {
                        // random num for r,g,b colors
                        r = random_num(0,255)
                        g = random_num(0,255)
                        b = random_num(0,255)
                }
        
                case 2:
                {
                        // if is user from Terro team
                        if(playert == CS_TEAM_T)
                        {
                            if (Damage <= 15)
                            {
                                r = 255
                                g = 80
                                b = 0
                            } else if(Damage >= 40)
                            {
                                r = 255
                                g = 0
                                b = 0
                            } else
                            {
                                r = 200
                                g = 70
                                b = 0
                            }
                        } else
                        {
                            if(Damage <= 15)
                            {
                                r = 23
                                g = 243
                                b = 0
                            } else if(Damage >= 40)
                            {
                                r = 0
                                g = 255
                                b = 0 
                            } else
                            {
                                r = 0
                                g = 65
                                b = 12
                            }
                        }
                }
        }
        
        playerglow(Victim,r,g,b)
 
        return PLUGIN_HANDLED
} 

public playerglow(player,r,g,b)
{
    new Params[1]
    Params[0] = player    
    set_user_rendering(player,kRenderFxGlowShell,r,g,b,kRenderNormal,25)
    set_task(1.0,"stopglow",0,Params,1);
                      
}

public stopglow(Params[])
{
    if(!is_user_connected(params[0]))
        return PLUGIN_HANDLED;
    
    set_user_rendering(Params[0],kRenderFxGlowShell,0,0,0,kRenderNormal,25)
}

[SAMURAI16]

ah - Thanks man . I fexed that and an bug on params

[Hawk552]

You clearly still have no idea what you're doing. I don't think you will be able to support this if any other problems with it arise. It's also sort of redundant (there are glow by health plugins and stuff like that).

Unapproved.