[abckrieger]

Hey,
I need for my plugin (kztimer) a modification which allows players to change their teams as often as they want. CS:GO says normally after the first team change "only 1 team change allowed". My code creates a weird bug, since one of the last csgo updates, which only appears on windows servers and in combination with bots. After selecting a team you just see the team select picture. You are already spawned at the right place but this fuckin picture doenst go away ... http://s14.directupload.net/images/140629/h6pps93v.jpg
Only solution is a round restart or if someone slays/kills you. Otherwise you have to quit your game with ctrl+alt del. Like i said before the bug only appears if a bot is on your server. I don't have any problems when bot_quota is set to 0. I've already try to bypass that by checking for human players before adding bots. But that solves the problem only for the 1st player :/

I have extracted the relevant code to make it easier for you:

#pragma semicolon 1
#include <sourcemod>
#include <cstrike>

public Plugin:myinfo =
{
    name = "bug tester",
    author = "1NutWunDeR",
    description = "",
    version = "1.0"
}

public OnPluginStart()
    AddCommandListener(Command_JoinTeam, "jointeam");

public OnMapStart()
{
    //neverending round, no warmup, add bots, respawn enabled    
    ServerCommand("mp_ignore_round_win_conditions 1;mp_do_warmup_period 0;bot_quota 1;bot_join_after_player 1;mp_respawn_on_death_ct 1;mp_respawn_on_death_t 1;mp_respawnwavetime_t 1.0;mp_respawnwavetime_ct 1.0;mp_spectators_max 30;mp_limitteams 0;mp_autoteambalance 0");
}
//unlimited team changes
public Action:Command_JoinTeam(client, const String:command[], argc) 
{ 
    if(!argc || !client || !IsValidClient(client))
        return Plugin_Handled;

    decl String:szTeam[8];
    GetCmdArg(1, szTeam, sizeof(szTeam));
    new team = StringToInt(szTeam);

    if (1 <= team <= 3) 
        ChangeClientTeam(client, team); 
    return Plugin_Handled;
}

stock bool:IsValidClient(client)
{
    if(client >= 1 && client <= MaxClients && IsValidEntity(client) && IsClientConnected(client) && IsClientInGame(client))
        return true;  
    return false;
}

public Action:CS_OnTerminateRound(&Float:delay, &CSRoundEndReason:reason)
{
    new timeleft;
    GetMapTimeLeft(timeleft);
    if (timeleft>= -1)
        return Plugin_Handled;
    return Plugin_Continue;
}

/e
p.s. i tested it with an untouched sourcemod (1.5.4-git4088 win) and on maps with enough spawnpoints on both teams ;)

[Drixevel]

You should return Plugin_Continue instead of Plugin_Handled at the end of the command listener for 'jointeam'.

public Action:Command_JoinTeam(client, const String:command[], argc) 
{ 
    if(!argc || !client || !IsValidClient(client))
        return Plugin_Handled;

    decl String:szTeam[8];
    GetCmdArg(1, szTeam, sizeof(szTeam));
    new team = StringToInt(szTeam);

    if (1 <= team <= 3) 
        ChangeClientTeam(client, team); 
    return Plugin_Continue;
}

[JoB2C]

Originally Posted by r3dw3r3w0lf You should return Plugin_Continue instead of Plugin_Handled at the end of the command listener for 'jointeam'. public Action:Command_JoinTeam(client, const String:command[], argc) { if(!argc || !client || !IsValidClient(client)) return Plugin_Handled; decl String:szTeam[8]; GetCmdArg(1, szTeam, sizeof(szTeam)); new team = StringToInt(szTeam); if (1 <= team <= 3) ChangeClientTeam(client, team); return Plugin_Continue; }

Eh, no.

You should return Plugin_Handled. Returning Plugin_Continue will let the engine handle the teamchange while the change is already done.

Try using CS_SwitchTeam and CS_RespawnPlayer instead of ChangeClientTeam.

[abckrieger]

Originally Posted by JoB2C Eh, no. Returning Plugin_Continue will let the engine handle the teamchange while the change is already done. Try using CS_SwitchTeam and CS_RespawnPlayer instead of ChangeClientTeam.

oh yea sry copy paste mistake. im using plugin_handled and it doesnt make any difference.
but thx i will try the other thing

/
it's workin now, thx

[zipcore]

try to delay manual team change

[winniethepooh]

This may have been a CS:GO bug and fixed in today's 1.34.0.0 update.

There were a couple people on the csgo_servers mailing list that reported it too.

Fixed the team select screen lingering and sometimes not going away in some circumstances

[Drixevel]

Originally Posted by JoB2C Eh, no. You should return Plugin_Handled. Returning Plugin_Continue will let the engine handle the teamchange while the change is already done. Try using CS_SwitchTeam and CS_RespawnPlayer instead of ChangeClientTeam.

If you call plugin_handled, the screen will not switch so..

[JoB2C]

I'm returning Plugin_Handled in a plugin, and it does switch when you change the team with CS_SwitchTeam.

[hamilton5]

post #6

7/1/2014

[misc]
-Fixed the team select screen lingering and sometimes not going away in some circumstances.