[Knifesss]

Delete this topic.

[Flick3rR]

Da*n, man, you can use arrays instead of creating new variables for all the things. This code may be optimized and reduced with about 350 lines, doing the same stuff, but with arrays. Think about it.

[Blizzard_87]

There is ALOT of better ways to code this. You could reduce the amount of lines down to very small. I could give you example but got no time atm

[ArabicMan]

Useful plugin. Good job.

[HamletEagle]

PHP Code:

new     cvar_money_num_1,
cvar_money_num_2,
cvar_money_num_3,
cvar_money_num_4,
cvar_money_num_5,
cvar_money_num_6,
cvar_money_num_7 


----->

PHP Code:

new cvar_money_num [ 8 ] /* 8 since you will use seven cells,one have to be free. Or, you can reserve 7 cell, if you start from 0. */ 


Now you will use it like this: cvar_money_num [ 1 ] , cvar_money_num [ 2 ] , etc

PHP Code:

cvar_money_num_1 = register_cvar("cffs_money_num_1", "5")
cvar_money_num_2 = register_cvar("cffs_money_num_2", "10")
cvar_money_num_3 = register_cvar("cffs_money_num_3", "15")
cvar_money_num_4 = register_cvar("cffs_money_num_4", "20")
cvar_money_num_5 = register_cvar("cffs_money_num_5", "25")
cvar_money_num_6 = register_cvar("cffs_money_num_6", "30")
cvar_money_num_7 = register_cvar("cffs_money_num_7", "35") 


-------------->

PHP Code:

cvar_money_num [ 1 ]  = register_cvar("cffs_money_num_1", "5") //and so on 


PHP Code:

    register_clcmd("say /frags", "the_frags_menu")
    register_clcmd("say_team /frags", "the_frags_menu")
    register_clcmd("say frags", "the_frags_menu")
    register_clcmd("say_team frags", "the_frags_menu")
    register_clcmd("say !frags", "the_frags_menu")
    register_clcmd("say_team !frags", "the_frags_menu") 


----->

PHP Code:

register_clcmd( "say", "Say" );
register_clcmd( "say_team", "Say" ); 


You will make public "Say" :

PHP Code:


public Say ( id ) {

    new szSaid[ 192 ];
    read_args( szSaid, sizeof( szSaid ) -1 );
    
    remove_quotes( szSaid );
    
    if( contain( szSaid, "frags" ) != -1 )
    {
        the_frags_menu ( id )
    }

} 


PHP Code:

new msg1[64],msg2[64],msg3[64],msg4[64],msg5[64],msg6[64],msg7[64] 


---->

PHP Code:

new msg [ 8 ] [ 64 ] /* same thins, you can use it like msg  [ 1 ] [ 64 ] , or you can initialize it with 0 ( only seven cell needed ) 


You could use len+= formatex with just one variabile, instand of seven.

In the handler, you use this a lot of time:

PHP Code:

cs_get_user_money(id)
get_user_frags(id) 


Why not simply cache them before you start the switch ?

PHP Code:

new iMoney =  cs_get_user_money ( id )
new deaths =  get_user_frags ( id ) 


If you do this, you can make your code smaller and you will make the compiler happy ( not really, but ... ) . This are some optimizations , I guess that there are more to do, I have not looked carefully through the code.

[Backstabnoob]

PHP Code: new cvar_money_num [ 8 ] /* 8 since you will use seven cells,one have to be free. Or, you can reserve 7 cell, if you start from 0. */

This is exactly the same thing I told you to fix in your plugin (which you never did). Stop giving people bad habits.

[Flick3rR]

Here is an improvement I did today. It works without mistakes for me, and as far as I could test, it's all okay. If that kind of post is argue with the rules (like thread hijack or something), excuse me, I'll delete it.

[HamletEagle]

Originally Posted by Backstabnoob This is exactly the same thing I told you to fix in your plugin (which you never did). Stop giving people bad habits.

Hmm:

PHP Code:

Or, you can reserve 7 cell, if you start from 0. 


I just told him that to understand about how it is working, and I understand what you told me in my theard, thank for that. Btw, I will fix my plugin when I have free time.

[Kia]

[Backstabnoob]

This plugin has limited to no functionality and the code is absolute garbage. I almost feel too bad for moving this to unapproved instead of simply trashing it.

Forever unapproved. Please stop posting plugins if you don't know how to code, thanks.