Amx_Hiteffects

Gadzislaw007 · **Plugin Info:**

Hello!

This is my first released plugin, so I hope I won't get smashed to the ground.
I think that there has already been similiar plugin developed, but not the same. At least, I hope.

This simple plugin adds few effects, when you get shot by someone:
• Your screen shakes a little.
• Your screen is being covered with black-red, bloodlike fade.
• You emit a random groan hitsound.

The power of shake or fade is laying on the damage you've took.

Cvars:

- amx_hitsoundchance (0-100) Default: 50 - sets the percent chance of emitting sound on hit
- amx_blinddamage (0-100) Default: 25 - sets the minimal damage you must take to make your screen be covered with bloodlike fade.
- amx_shakedamage (0-100) Default: 50 - sets the minimal damage you must take to make your screen shake

Setting amx_hitsoundchance to 0 will disable hitsounds.
Setting amx_blinddamage to 101 (or more) will disable fading.
Setting amx_shakedamage to 101 (or more) will disable screen shaking.

I posted this in Counter-Strike Addons sections. Since I never tried to do plugins for any other modifications, but I think it will work for other games too.

ConnorMcLeod · 08-15-2012 , 05:37 Re: Amx_Hiteffects

- you need to use cvar pointers.
- you hook TakeDamage as pre, so you can't know real damage; to know real damage, hook it as post and check dmg_take value, or hook "Damage" event.
- Blind fonction should be more explicit about blind hold time, remember 1 second is 4096 (1<<12) and max value is max unsigned short value (0xFFFF).
Also, 3rd argument of ScreenFade message is wrong, you can see my include screenfade_util for more details.
- You don't need to use floatround with damage value, just check that value against get_pcvar_float instead of get_pcvar_int (actually you used get_cvar_num but you gonna use pcvars).
- functions hitsound, twist and blind don't need to be public, also should directly be integrated in Damage function because they are not be used anywhere else.
- emit_sound code could be shortened as we discussed in the other thread.

PyPKjE20 · 08-15-2012 , 06:05 Re: Amx_Hiteffects

Good effects ;)

Pleas add cvar ff off effects!

Gadzislaw007 · 08-15-2012 , 07:06 Re: Amx_Hiteffects

Deeply thanks for feedback and cc.
I just have few sentences, since I'm kinda new in making plugins. I hope you will help me.

• What exactly are cvar pointers? How do I use them, why do I use them. Tried to use google, but I didn't find anything. Any link from your side?

• Why you think I need to know real damage?

• I think that blind/fade addon is enough explicit and making it even longer could annoy player, cause of limit on his seeing.

• Tried to shorten emit_sound code, somehow doesn't work for me.

ConnorMcLeod · 08-15-2012 , 07:39 Re: Amx_Hiteffects

• http://wiki.amxmodx.org/Optimizing_P...#Cvar_Pointers (you can read this page from the begining though)

• Administrators may want to set min damage related cvars according to real damage done...

• Because administrators may want to be able to set the fade time, also flags (3rd arg) are wrong. (anyway, max duration with your values is 2.6 seconds on 100 HP damage, if real damage of course, else it gonna be more).

• Try again then