[xXDeathreusXx]

Originally Posted by 11530 First section: Change the && to ||. Some odd indentation too. Second section: Wouldn't recommend setting pitch to 100. Leave it at whatever it already was otherwise you may get conflicts. Third section: Hopefully this isn't being run every time a sound is emitted.

1. What odd indentation? It's 1 space per word, and is tabbed in to indent, notepad++ keeps previus indentations

2. It was set to something else earlier, it was a randomint between 95 and 100

3. It is

[xXDeathreusXx]

Originally Posted by Bacardi Just quick look and fix... if (!GetConVarBool(cvarSounds)) return Plugin_Continue; if (!IsValidClient(Ent)) return Plugin_Continue; if (StrContains(sound, "vo/announcer_", false) != -1) return Plugin_Continue; /*if (StrContains(sound, "weapons/", false) != -1) CPrintToChatAll("{red}Played: %s %d %f %d %d %d", sound, channel, volume, level, pitch, flags);*/ new client = Ent; new TFClassType:class = TF2_GetPlayerClass(client);

I hadn't touched that, that's how it was in the original plugin. Will probably make it an or statement

[11530]

Originally Posted by xXDeathreusXx 1. What odd indentation? It's 1 space per word, and is tabbed in to indent, notepad++ keeps previus indentations 2. It was set to something else earlier, it was a randomint between 95 and 100 3. It is

1. Your second if-statement there starts in one tab, though isn't nested. Remember if-statements without brackets only apply to the next line.

PHP Code:

if (!GetConVarBool(cvarSounds) && !IsValidClient(Ent)) 
        return Plugin_Continue;
    if (StrContains(sound, "vo/announcer_", false) != -1)
        return Plugin_Continue;
    /*if (StrContains(sound, "weapons/", false) != -1) 
        CPrintToChatAll("{red}Played: %s %d %f %d %d %d", sound, channel, volume, level, pitch, flags);*/

    new client = Ent;
    new TFClassType:class = TF2_GetPlayerClass(client); 


Should be this. As Bacardi also shows.

PHP Code:

if (!GetConVarBool(cvarSounds) || !IsValidClient(Ent))
        return Plugin_Continue;
if (StrContains(sound, "vo/announcer_", false) != -1)
        return Plugin_Continue;
/*if (StrContains(sound, "weapons/", false) != -1) 
        CPrintToChatAll("{red}Played: %s %d %f %d %d %d", sound, channel, volume, level, pitch, flags);*/

new client = Ent;
new TFClassType:class = TF2_GetPlayerClass(client); 


2. Randomints setting the pitch would still conflict with certain plugins *pokes sig*

3. Checking the sounds exist earlier may be better than checking it every time it plays. Same for the convar.

[xXDeathreusXx]

Originally Posted by 11530 1. Your second if-statement there starts in one tab, though isn't nested. Remember if-statements without brackets only apply to the next line. PHP Code: if (!GetConVarBool(cvarSounds) && !IsValidClient(Ent))          return Plugin_Continue;     if (StrContains(sound, "vo/announcer_", false) != -1)         return Plugin_Continue;     /*if (StrContains(sound, "weapons/", false) != -1)          CPrintToChatAll("{red}Played: %s %d %f %d %d %d", sound, channel, volume, level, pitch, flags);*/     new client = Ent;     new TFClassType:class = TF2_GetPlayerClass(client);  Should be this. As Bacardi also shows. PHP Code: if (!GetConVarBool(cvarSounds) || !IsValidClient(Ent))         return Plugin_Continue; if (StrContains(sound, "vo/announcer_", false) != -1)         return Plugin_Continue; /*if (StrContains(sound, "weapons/", false) != -1)          CPrintToChatAll("{red}Played: %s %d %f %d %d %d", sound, channel, volume, level, pitch, flags);*/ new client = Ent; new TFClassType:class = TF2_GetPlayerClass(client);  2. Randomints setting the pitch would still conflict with certain plugins *pokes sig* 3. Checking the sounds exist earlier may be better than checking it every time it plays. Same for the convar.

2 and 3. Like I said, this is how the plugin was when I got it

As for 1, still not seeing it, and I have changed the and statement to an or

[xXDeathreusXx]

After changing that one thing, it seems to have been fixed

All thats left is this:

[SM] Native "CreateNative" reported: Fatal error creating dynamic native!
L 04/11/2014 - 22:29:06: [SM] Displaying call stack trace for plugin "betherobot.smx":
L 04/11/2014 - 22:29:06: [SM]   [0]  Line 56, betherobot.sp::AskPluginLoad2()

And this is the APL code

public APLRes:AskPluginLoad2(Handle:myself, bool:late, String:error[], err_max)
{
    CreateNative("BeTheRobot_GetRobotStatus", Native_GetRobotStatus);
    CreateNative("BeTheRobot_SetRobot", Native_SetRobot);
    CreateNative("BeTheRobot_CheckRules", Native_CheckRules);
    RegPluginLibrary("betherobot");
    return APLRes_Success;
}

And the natives:

public Native_GetRobotStatus(Handle:plugin, args)
    return _:Status[GetNativeCell(1)];

public Native_SetRobot(Handle:plugin, args)
    ToggleRobot(GetNativeCell(1), bool:GetNativeCell(2));

public Native_CheckRules(Handle:plugin, args)
    return CheckTheRules(GetNativeCell(1));

[Bacardi]

Originally Posted by xXDeathreusXx I hadn't touched that, that's how it was in the original plugin. Will probably make it an or statement

look again
[TF2] Be the Robot (1.3, December 22 2012)

it have updated, fixed those errors etc. etc.

[xXDeathreusXx]

Originally Posted by Bacardi look again [TF2] Be the Robot (1.3, December 22 2012) it have updated, fixed those errors etc. etc.

Useing that

Unless he made an update and is hidden somewhere in the threads replies?

[xXDeathreusXx]

Oh, the native thing, I'm fairly certain it's to do with the same native being added in Bethegiant, GetRobotStatus, but I need this native in that, is there a way around this?

[Bacardi]

Originally Posted by xXDeathreusXx Oh, the native thing, I'm fairly certain it's to do with the same native being added in Bethegiant, GetRobotStatus, but I need this native in that, is there a way around this?

Problem is, that Bethegiant is copy of Betherobot with few change. And creates also sam natives.
It should not.

Post whole Bethegiant or link to it.

*edit
or you need run only Bethegiant plugin, not Betherobot