[Zuko]

Pfsm999, your plugin still displays wrong achievement progress on chat and players cannot get achievements on my server (progress on site is good eg. 2/2)

[Pfsm999]

Okay, i see the problem !
And now... normaly : All be correct on the new version !

Just a bad line of code ... i don't know how could be happen ...
See on the first page the new plug !

[Zuko]

ok, new version works, thanks

[Zuko]

error logs.
http://g2.isports.pl/~zuko/errors_20100326.log

[NovaDenizen]

 public Action:blocks_sniper_jarate(UserMsg:msg_id, Handle:bf, const players[], playersNum, bool:reliable, bool:init)
 {
-       CreateTimer(0.1, DelaySniperExpire, bf);
+       new strClient = BfReadByte(bf);
+       new strVictim = BfReadByte(bf);
+       g_VICTIMSNIPER[strClient] = strVictim;
+       CreateTimer(0.1, DelaySniperExpire, strClient);
        return Plugin_Continue;
 }
 
-public Action:DelaySniperExpire(Handle:hTimer, Handle:buffer)
+public Action:DelaySniperExpire(Handle:hTimer, any:argClient)
 {
-       new strClient = BfReadByte(buffer);
-       new strVictim = BfReadByte(buffer);
+       new strClient = argClient;
+       new strVictim = g_VICTIMSNIPER[argClient];

If a sniper jarates 3 people simultaneously then the plugin will instead treat it as one of them getting jarated 3 times. There will be 3 player_jarated messages that happen quickly before the timer runs out. It's not a good idea to use a global variable in this situation.

You instead should use a DataPack, like this:

 public Action:blocks_sniper_jarate(UserMsg:msg_id, Handle:bf, const players[], playersNum, bool:reliable, bool:init)
 {
       new strClient = BfReadByte(bf);
       new strVictim = BfReadByte(bf);
       new Handle:dp = CreateDataPack();
       WritePackCell(dp, strClient);
       WritePackCell(dp, strVictim);
       CreateTimer(0.1, DelaySniperExpire, dp);
       return Plugin_Continue;
 }
public Action:DelaySniperExpire(Handle:hTimer, any:dp)
 {
       ResetPack(dp);
       new strClient = ReadPackCell(dp);
       new strVictim = ReadPackCell(dp);
       CloseHandle(dp);

[NovaDenizen]

L 03/26/2010 - 22:53:40: [SM] Native "IsClientConnected" reported: Client index 0 is invalid
L 03/26/2010 - 22:53:40: [SM] Displaying call stack trace for plugin "customs_achievements.smx":
L 03/26/2010 - 22:53:40: [SM]   [0]  Line 1701, customs_achievements.sp::IsValidClient()
L 03/26/2010 - 22:53:40: [SM]   [1]  Line 92, mwach/medic.inc::blocks_medic_uber()

// ------------------------------------------------------------------------
// IsValidClient
// ------------------------------------------------------------------------
stock bool:IsValidClient(iClient)
{
        if (iClient < 0) return false;
        if (iClient > MaxClients) return false;
        if (!IsClientConnected(iClient)) return false;
        return IsClientInGame(iClient);
}

I think you want to change that one line to:

        if (iClient <= 0) return false;

[NovaDenizen]

L 03/26/2010 - 23:16:10: [SM] Native "GetClientAuthString" reported: Client 4 is not connected
L 03/26/2010 - 23:16:10: [SM] Displaying call stack trace for plugin "customs_achievements.smx":
L 03/26/2010 - 23:16:10: [SM]   [0]  Line 1258, customs_achievements.sp::ResetBlockStatus()
L 03/26/2010 - 23:16:10: [SM]   [1]  Line 1131, customs_achievements.sp::ResetFunction()
L 03/26/2010 - 23:16:10: [SM]   [2]  Line 1118, customs_achievements.sp::ResetAllOneLifeForOneClient()
L 03/26/2010 - 23:16:10: [SM]   [3]  Line 333, mwach/kill.inc::blocks_ResetOnDeath()

//----------------------------------------KILL BLOCKS----------------------------------------
public blocks_kill_pre(Handle:argEvent, const String:name[], bool:noBroadcast) {
        blocks_kill(argEvent, -1, -1);
        new g_victimid = GetEventInt(argEvent, "userid");
        new g_victim = GetClientOfUserId(g_victimid);
        CreateTimer(2.0, blocks_ResetOnDeath, g_victim);
}

I believe this error happens because the victim disconnected before the 2 second timer expired and blocks_ResetOnDeath was called.

I see several ways to approach this problem.

One way is to just put an IsValidClient check in ResetBlockStatus, and return if the client is not valid. This is kind of sketchy because the resets will not be performed.

Another way is to simply reduce the timer length from 2 seconds to 0.1 seconds. I haven't figured out why you're using a timer at all here. Shortening the timer doesn't eliminate the problem but it does make it more unlikely.

The best, and most difficult way, is to call getClientAuthString in blocks_kill_pre, put the steamid in a DataPack, and pass the DataPack through blocks_ResetOnDeath, ResetAllOneLifeForOneClient(), ResetFunction(), and ResetBlockStatus().

[Pfsm999]

Thanks to you NovaDenizen
Done version 1.05 of plug !
And i work for new addon on the website.

And you have a PM Nova ^^

[Zuko]

another errors from my log ;]

http://g2.isports.pl/~zuko/errors_20100326.log

[berni]

Please set the plugin description and the public cvar in the thread, approved for now.

Greetings ~Berni