GetClientName can't function properly while name contains percent sign

22920206 · **Author**

It doesn't seems to be able to get the percent sign
So when a player name is "123%123" it only get "123123"
How could I get the sign properly?

Powerlord · *Last edited by Powerlord; 10-17-2012 at 13:51.*

Quote:

Originally Posted by 22920206

It doesn't seems to be able to get the percent sign
So when a player name is "123%123" it only get "123123"
How could I get the sign properly?

The problem isn't with GetClientName, but instead when you go to print it using any of the print functions. This is because % is a special character in Format-type statements like Format, PrintToChat, PrintHintText, PrintCenterText, etc...

I'd recommend using the %N format specifier and pass the client ID, which will automatically print the client's name without having to use GetClientName.

Bacardi

Source game(s) not support % character in player names, and there was another symbols.
Old exploit.

berni · *Last edited by berni; 10-17-2012 at 16:21.*

When you pass a string to a format function as format parameter that has a %, you have to escape it of course, that is not an exploit.

PHP Code:


			
newString:str[] = "String with % in it";
ReplaceString(str, sizeof(str), "%", "%%");
PrintToServer(str);

However when you pass the string as variable argument, it should work correctly anyway I think.
Like this:

PHP Code:


			
PrintToServer("%s", str);

asherkin

Quote:

Originally Posted by berni

PHP Code:


			
newString:str[] = "String with % in it";

ReplaceString(str, sizeof(str), "%", "%%");

PrintToServer(str);

Never, ever, ever, ever, ever, ever, ever do this.

Quote:

Originally Posted by berni

PHP Code:


			
PrintToServer("%s", str);

Do this.

11530 · *Last edited by 11530; 10-17-2012 at 17:41.*

Quote:

Originally Posted by asherkin

Never, ever, ever, ever, ever, ever, ever do this.

Do this.

Is that because the former may lack a null terminator or something?

Chrisber · *Last edited by Chrisber; 10-17-2012 at 18:44.*

It is bad because you may shorten the players name accidentally.
Also think of applying this replacement for a second time, or even a third one.

asherkin

Quote:

Originally Posted by 11530

Is that because the former may lack a null terminator or something?

The 2nd completely sanitises the string and is a lot faster, the former targets a specific issue.

22920206 · *Last edited by 22920206; 10-17-2012 at 23:59.*

Thank everyone's reply. I should have been more specific that I actually want to compare that string with another string, this is generally how my code look like:

PHP Code:


			
    new String:nickname[36];
    GetClientName(client,    nickname,    sizeof(nickname));

    while(!IsEndOfFile(KickFile))    {
        ReadFileLine(KickFile, kLine, sizeof(kLine));
    
       if    (StrContains(nickname, kLine, false) != -1)    {
       KickClient(client, "Kicked by Console");
       }
    }

kLine is read from a txt file.
The plugin works pretty well as long as I don't test with name with % sign(and probably some other symbols too). So is there any workaround for this?

FaTony · *Last edited by FaTony; 10-17-2012 at 23:27.*

What happens when the name has % sign? I don't see bugs in your code.