[Obada]

Hey there,


Here is the vote function in my adminvote.sma.

Spoiler

PHP Code:

public cmdVote(id, level, cid)
{
    if (!cmd_access(id, level, cid, 4))
        return PLUGIN_HANDLED
    
    new Float:voting = get_cvar_float("amx_last_voting")
    if (voting > get_gametime())
        {
        console_print(id, "%L", id, "ALREADY_VOTING")
        return PLUGIN_HANDLED
    }
    
    if (voting && voting + get_cvar_float("amx_vote_delay") > get_gametime())
        {
        console_print(id, "%L", id, "VOTING_NOT_ALLOW")
        return PLUGIN_HANDLED
    }
    
    new quest[48]
    read_argv(1, quest, 47)
    
    if ((contain(quest, "sv_password") != -1) || (contain(quest, "rcon_password") != -1) || (contain(quest, "kick") != -1) || 
    (contain(quest, "addip") != -1) || (contain(quest, "ban") != -1))
    {
        console_print(id, "%L", id, "VOTING_FORBIDDEN")
        return PLUGIN_HANDLED
    }
    
    new count=read_argc();
    
    for (new i=0;i<4 && (i+2)<count;i++)
    {
        read_argv(i+2, g_optionName[i], sizeof(g_optionName[])-1);
    }
    
    new authid[32], name[32]
    
    get_user_authid(id, authid, 31)
    get_user_name(id, name, 31)
    log_amx("Vote: ^"%s<%d><%s><>^" vote custom (question ^"%s^") (option#1 ^"%s^") (option#2 ^"%s^")", name, get_user_userid(id), authid, quest, g_optionName[0], g_optionName[1])
    
    if(get_user_flags(id) & ADMIN_LEVEL_G)
    client_print(0, print_chat, "Silver Player %s: vote custom", name)
    
    else if(get_user_flags(id) & ADMIN_BAN)
    show_activity_key("ADMIN_VOTE_CUS_1", "ADMIN_VOTE_CUS_2", name)
    
    else if(get_user_flags(id) & ADMIN_LEVEL_H)
    client_print(0, print_chat, "Golden Player %s: vote custom", name)
    
    new maxpl=get_maxplayers();
    new msg[256];
    for (new i = 1; i <= maxpl; i++)
    {
        if (is_user_connected(i) && !is_user_bot(i))
            {
            // HACK: ADMIN_VOTE_CUS_{1,2} keys were designed very poorly.  Remove all : and %s in it.
            LookupLangKey(msg, charsmax(msg), "ADMIN_VOTE_CUS_1", i);
            replace_all(msg, charsmax(msg), "%s", "");
            replace_all(msg, charsmax(msg), ":", "");
            trim(msg);
            show_activity_id(i, id, name, msg);
        }
    } 


It's working and everything is fine, but the problem is that if a Golden Player/Silver player made custom vote, it will print like


Thank you, and help is appreciated!

[Flick3rR]

Well, first you have 3 if-else statements, where 1 message is printed. And then you have that loop and print another message. I don't really see the purpose, but yes - that's what the code is supposed to make.

[Obada]

Then do you have any idea how can I make it print once?

[Flick3rR]

PHP Code:

new maxpl=get_maxplayers(); 
    new msg[256]; 
    for (new i = 1; i <= maxpl; i++) 
    { 
        if (is_user_connected(i) && !is_user_bot(i)) 
            { 
            // HACK: ADMIN_VOTE_CUS_{1,2} keys were designed very poorly.  Remove all : and %s in it. 
            LookupLangKey(msg, charsmax(msg), "ADMIN_VOTE_CUS_1", i); 
            replace_all(msg, charsmax(msg), "%s", ""); 
            replace_all(msg, charsmax(msg), ":", ""); 
            trim(msg); 
            show_activity_id(i, id, name, msg); 
        } 
    } 


to

PHP Code:

else
    {
        new maxpl=get_maxplayers(); 
        new msg[256]; 
        for (new i = 1; i <= maxpl; i++) 
        { 
            if (is_user_connected(i) && !is_user_bot(i)) 
            { 
                // HACK: ADMIN_VOTE_CUS_{1,2} keys were designed very poorly.  Remove all : and %s in it. 
                LookupLangKey(msg, charsmax(msg), "ADMIN_VOTE_CUS_1", i); 
                replace_all(msg, charsmax(msg), "%s", ""); 
                replace_all(msg, charsmax(msg), ":", ""); 
                trim(msg); 
                show_activity_id(i, id, name, msg); 
            } 
        }
    } 


[Obada]

Alright thanks man.