[BlackJack]

Hello.

With MySQL I have learned to work, but I have a little problem.

This is my code:

PHP Code:

public OnClientPutInServer(client)
{
    new String:auth[32];
    new String:steam_id[24];
    GetClientAuthString(client, auth, sizeof(auth));
    new String:query1[150];
    new String:query2[150];
    
    Format(query2, sizeof(query2), "SELECT `steam_id` FROM `bodovysystem` WHERE steam_id='%s'", auth);    
    new Handle:queryQ = SQL_Query(g_database, query2);
    SQL_FetchString(queryQ, 0, steam_id, sizeof(steam_id));

    if (!StrEqual(auth, steam_id, true))
    {
        if(!StrEqual(auth, "", true))
        {    
            Format(query1, sizeof(query1), "INSERT INTO `bodovysystem`(`steam_id`, `body`) VALUES ('%s',0)", auth);    
            new Handle:queryH = SQL_Query(g_database, query1);
            
            if (queryH == INVALID_HANDLE)
            {
                new String:error[100]
                SQL_GetError(g_database, error, sizeof(error));
                PrintToChat(client,"[JB] Databaza je momentalne nedostupna, Chyba: %s", error);
            }
        }
    }    
} 


When a client first time connect on server, this code save his SteamId32 to Database. And when client connect second time, server detects it and does not writes it to the database.

This part is working (i tested):

PHP Code:

if (!StrEqual(auth, steam_id, true))
    {
        if(!StrEqual(auth, "", true))
        {    
            Format(query1, sizeof(query1), "INSERT INTO `bodovysystem`(`steam_id`, `body`) VALUES ('%s',0)", auth);    
            new Handle:queryH = SQL_Query(g_database, query1);
            
            if (queryH == INVALID_HANDLE)
            {
                new String:error[100]
                SQL_GetError(g_database, error, sizeof(error));
                PrintToChat(client,"[JB] Databaza je momentalne nedostupna, Chyba: %s", error);
            }
        }
    }    
} 


This also work:

PHP Code:

new String:auth[32];
    new String:steam_id[24];
    GetClientAuthString(client, auth, sizeof(auth));
    new String:query1[150];
    new String:query2[150]; 


But i have problem with this:

PHP Code:

Format(query2, sizeof(query2), "SELECT `steam_id` FROM `bodovysystem` WHERE steam_id='%s'", auth);    
    new Handle:queryQ = SQL_Query(g_database, query2);
    SQL_FetchString(queryQ, 0, steam_id, sizeof(steam_id));

    if (!StrEqual(auth, steam_id, true))
    {
....
....
.... 


And anyway I do not know what's the problem. When I write that last part, plugin does not work.

[xf117]

Format(query2, sizeof(query2), "SELECT `steam_id` FROM `bodovysystem` WHERE steam_id='%s'", auth);

What are you trying to do with this?

[BlackJack]

Select STEAM ID from the database ("STEAM_ID") and compare it with the "auth". Oh, wait, something I do not sit there. If "STEAM_ID" is not in the database, so there is nothing to return. Is that right?

This is new code:

PHP Code:

new String:auth[32];
    GetClientAuthString(client, auth, sizeof(auth));
    new String:query1[150];
    new String:query2[150];
    
    Format(query2, sizeof(query2), "SELECT `steam_id` FROM `bodovysystem` WHERE steam_id='%s'", auth);    
    new Handle:queryQ = SQL_Query(g_database, query2);
    
    if (queryQ == INVALID_HANDLE)
    {
        if(!StrEqual(auth, "", true))
        {    
            Format(query1, sizeof(query1), "INSERT INTO `bodovysystem`(`steam_id`, `body`) VALUES ('%s',0)", auth);    
            new Handle:queryH = SQL_Query(g_database, query1);
            
            if (queryH == INVALID_HANDLE)
            {
                new String:error[100]
                SQL_GetError(g_database, error, sizeof(error));
                PrintToChat(client,"[JB] Databaza je momentalne nedostupna, Chyba: %s", error);
            }
        }
    } 
    else
    {
        PrintToServer("Mate problem");
    } 


The message "PrintToServer("Mate problem");" shows still.

[xf117]

I'm saying, you are trying to get steam id from a database WHERE steam id is the same as the one you specify. Anyway, use this check to be sure database does return you something to fetch

PHP Code:

Format(query2, sizeof(query2), "SELECT `steam_id` FROM `bodovysystem` WHERE steam_id='%s'", auth);
new Handle:queryQ = SQL_Query(g_database, query2);
if (SQL_FetchRow(queryQ)) {
    SQL_FetchString(queryQ, 0, steam_id, sizeof(steam_id));
} else {
    // There is no such steam id in your database
}

if (!StrEqual(auth, steam_id, true)) {
    // your code ... 


[thetwistedpanda]

You may want to rewrite this code to utilize threaded queries so it doesn't crash/lag server on slow/no response.

[Dr. Greg House]

And again, someone does not realize that GetClientAuthString is failable and returns bool...

[Chrisber]

How to do it correctly:

SELECT EXISTS(SELECT 1 FROM bodovysystem WHERE steam_id = '%s' LIMIT 1)

[11530]

Originally Posted by Dr. Greg House And again, someone does not realize that GetClientAuthString is failable and returns bool...

Or succeeded, but returns an unusable SteamID like STEAM_ID_PENDING.

[Root_]

Does OnClientAuthorized may also fail sometimes?

[mcpan313]

PHP Code:

public OnClientAuthorized(client, const String:auth[])
{
    if (IsFakeClient(client))
    {
        return;
    }

    decl String:szQuery[256];

    FormatEx(szQuery, sizeof(szQuery),
        "INSERT INTO bodovysystem (steam_id, body) \
        SELECT * FROM (SELECT '%s', 0) AS tmp \
        WHERE NOT EXISTS \
        (SELECT steam_id FROM bodovysystem WHERE steam_id='%s') \
        LIMIT 1;",
        auth, auth);
    
    SQL_TQuery(g_database, SQLTCallback_GetError, szQuery);
}

public SQLTCallback_GetError(Handle:owner, Handle:hndl, const String:error[], any:data)
{
    if (hndl == INVALID_HANDLE)
    {
        LogError("SQLERROR=%s", error);
    }
}