[11530]

I had that thought too, but thinking more of FormatEx rather than Format, but to be honest, I rather like the simple mathematics of my version even if I say so myself.

[Zephyrus]

its berni's code from like 1.5 years ago from the originhal communityid thread and yes it can easily be further optimized

[minimoney1]

Originally Posted by Zephyrus its berni's code from like 1.5 years ago from the originhal communityid thread and yes it can easily be further optimized

I don't think it would still, even when completely optimized, be "way better" than the provided method.

[11530]

Curiosity got the better of me, so I've just tested my version against Zephyrus's - including the optimizations that he failed to do. Ran both 10 million times, twice.

Results (in seconds):
Zephyrus's code - Average Time: 6.781233 then 6.865508 (Total Average: 6.8233705)
My code - Average Time: 6.725708 then 6.860354 (Total Average: 6.793031)

Conclusion:
My code is faster by a fraction, but for all intents and purposes, they are identical. Both second trials, running 10 million times in 6.86 seconds - it pretty much renders this entire argument that Zephyrus started as obsolete - but then again, we always knew it would end up pointless anyway. This isn't the "be-the-fastest-and-win-a-cookie" thread Zeph, - this is to convert SteamIDs to CommunityIDs.

Both do the same thing. Will I switch to Zephyrus's barely slower code (well, berni's, since Zephyrus is just super at copy/pasting 1.5 year-old code)? Not at all. Will I stick to my shorter code? Yes - and I love the simple mathematical syntax.

Hopefully (though I'm sure I'll be mistaken), this will be the end of this week's drama.

[Zephyrus]

heres MY version:

bool:GetFriendID(String:AuthID[], String:FriendID[], size)
{
    if(AuthID[6]=='I' || size < 18)
    {
        FriendID[0] = 0;
        return false;
    }

    new iUpper = 765611979;
    new iFriendID = StringToInt(AuthID[10])*2 + 60265728 + AuthID[8]-48;

    if(iFriendID >= 39734271)
        ++iUpper;
    if(iFriendID >= 139734271)
        ++iUpper;

    new iDiv = iFriendID/100000000;
    IntToString(iFriendID, FriendID[9-iDiv], size-9-iDiv);
    IntToString(iUpper, FriendID, size);

    return true;
}

I ran both 10 million times:

My version: 1. 2.923248 2. 2.910583 3. 2.927520 Total avg: 2.92045033
Your version: 1. 7.414703 2. 7.334228 3. 7.284574 Total avg: 7.34450167

Difference: mine is faster 2.51485245 times

Length of code:

My version: 21 lines can be decreased to 17 lines if I remove the blank lines
Your version: 23 lines can be decreased to 20 lines if you remove the blank lines

[psychonic]

[11530]

@Zephyrus, Thanks for attempting to post improvements. We're always encouraging you guys to post when you can. Your speed boosts might be stemming from incorrect code however. I ran your function against some examples of SteamIDs to see their results. Whilst they are incorrect, I can still concede that your code, when fixed, might be faster. As of yet, your code will error if the output length is smaller than 18, which should be allowed, and also crashes my test server when an output string larger than 18 is used.

Data used: "STEAM_0:0:131785", "STEAM_ID_PENDING", "STEAM_0:0:12341111", "BOT", "STEAM_0:1:1" with the usual output size:

Output:

PHP Code:

765611980 should be 76561197960529298 (returns 1)
[blank] should be [blank] (returns 0)
765611980 should be 76561197984947950 (returns 1)
765611980 should be [blank] (returns 0)
765611980 should be 76561197960265731 (returns 1) 


Note: [blank] here implies an empty string.

[Zephyrus]

Originally Posted by 11530 @Zephyrus, Thanks for attempting to post improvements. We're always encouraging you guys to post when you can. Your speed boosts might be stemming from incorrect code however. I ran your function against some examples of SteamIDs to see their results. Whilst they are incorrect, I can still concede that your code, when fixed, might be faster. As of yet, your code will error if the output length is smaller than 18, which should be allowed, and also crashes my test server when a larger buffer than 18 is used. Data used: "STEAM_0:0:131785", "STEAM_ID_PENDING", "STEAM_0:0:12341111", "BOT", "STEAM_0:1:1": Output: PHP Code: 765611980 should be 76561197960529298 (returns 1) [blank] should be [blank] (returns 0) 765611980 should be 76561197984947950 (returns 1) 765611980 should be [blank] (returns 0) 765611980 should be 76561197960265731 (returns 1)  Note: [blank] here implies an empty string.

PHP Code:

stock bool:GetClientCommunityID(String:AuthID[], String:FriendID[], size)
{
    if(AuthID[0]!='S' || AuthID[6]=='I' || size < 18)
    {
        FriendID[0] = 0;
        return false;
    }

    new iUpper = 765611979;
    new iFriendID = StringToInt(AuthID[10])*2 + 60265728 + AuthID[8]-48;

    if(iFriendID >= 100000000)
        ++iUpper;
    if(iFriendID >= 200000000)
        ++iUpper;

    new iDiv = (iFriendID/100000000?1:0);
    IntToString(iUpper, FriendID, size);
    IntToString(iFriendID, FriendID[9-iDiv], size-9-iDiv);

    return true;
} 


here, this one should be correct for all your cases, problem was that i didnt add 60265728 to those numbers that i checked iFriendID against and having only the upper was caused by the wrong order of inttostrings, code should be the same speed tho as i didnt add anything new except +1 byte check for BOT ids

Edit: confirmed, ive tried all your test cases, all work and time is still under 3 secs on my PC for 10 million runs

[11530]

Originally Posted by Zephyrus here, this one should be correct for all your cases, problem was that i didnt add 60265728 to those numbers that i checked iFriendID against and having only the upper was caused by the wrong order of inttostrings, code should be the same speed tho as i didnt add anything new except +1 byte check for BOT ids

Yea, that one works better now, but still exits early when an output string less than 18 is given. In my head, it should just truncate the string. But then you'd need a different check maybe.

[Zephyrus]

Originally Posted by 11530 Yea, that one works better now, but still exits early when an output string less than 18 is given. In my head, it should just truncate the string. But then you'd need a different check maybe.

you can simply remove that check, it even makes the code measurably faster altho i didnt find any useful case for a truncated communityid thats why i added that check, tested and works

PHP Code:

stock bool:GetCommunityID(String:AuthID[], String:FriendID[], size)
{
    if(AuthID[0]!='S' || AuthID[6]=='I')
    {
        FriendID[0] = 0;
        return false;
    }

    new iUpper = 765611979;
    new iFriendID = StringToInt(AuthID[10])*2 + 60265728 + AuthID[8]-48;

    if(iFriendID >= 100000000)
        ++iUpper;
    if(iFriendID >= 200000000)
        ++iUpper;

    new iDiv = (iFriendID/100000000?1:0);
    IntToString(iUpper, FriendID, size);
    IntToString(iFriendID, FriendID[9-iDiv], size-9-iDiv);

    return true;
}