[Flick3rR]

Hey, guys! I just want to ask why is this tag mismatch caused in the code. It's purpose is to block FF for Terrorist and allow it for CTs. Thanks!

PHP Code:

#include <amxmodx>
#include <hamsandwich>
#include <cstrike>

#define PLUGIN "CT FF"
#define VERSION "1.0"
#define AUTHOR "Flicker"

new mpFriendlyFire

public plugin_init()
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
    
    mpFriendlyFire = get_cvar_pointer("mp_friendlyfire")
    set_pcvar_num(mpFriendlyFire, 1)
    
    RegisterHam(Ham_TakeDamage, "player", "onTakeDamage")
}

public onTakeDamage(victim, inflictor, attacker, Float:damage, dmgbits)
{
    new CsTeams:Vteam = cs_get_user_team(victim)
    new CsTeams:Ateam = cs_get_user_team(attacker)
    
    return (Vteam == Ateam == CS_TEAM_T) ? HAM_SUPERCEDE : HAM_IGNORED
} 


[bat]

Originally Posted by Flick3rR Hey, guys! I just want to ask why is this tag mismatch caused in the code. It's purpose is to block FF for Terrorist and allow it for CTs. Thanks! PHP Code: #include <amxmodx> #include <hamsandwich> #include <cstrike> #define PLUGIN "CT FF" #define VERSION "1.0" #define AUTHOR "Flicker" new mpFriendlyFire public plugin_init() {     register_plugin(PLUGIN, VERSION, AUTHOR)          mpFriendlyFire = get_cvar_pointer("mp_friendlyfire")     set_pcvar_num(mpFriendlyFire, 1)          RegisterHam(Ham_TakeDamage, "player", "onTakeDamage") } public onTakeDamage(victim, inflictor, attacker, Float:damage, dmgbits) {     new CsTeams:Vteam = cs_get_user_team(victim)     new CsTeams:Ateam = cs_get_user_team(attacker)          return (Vteam == Ateam == CS_TEAM_T) ? HAM_SUPERCEDE : HAM_IGNORED }

#include <amxmodx> 
#include <hamsandwich> 
#include <cstrike> 

#define PLUGIN "CT FF" 
#define VERSION "1.0" 
#define AUTHOR "Flicker" 

new mpFriendlyFire 

public plugin_init() 
{ 
    register_plugin(PLUGIN, VERSION, AUTHOR) 
     
    mpFriendlyFire = get_cvar_pointer("mp_friendlyfire") 
    set_pcvar_num(mpFriendlyFire, 1) 
     
    RegisterHam(Ham_TakeDamage, "player", "onTakeDamage") 
} 

public onTakeDamage(victim, inflictor, attacker, Float:damage, dmgbits) 
{ 
    new CsTeams:Vteam = cs_get_user_team(victim) 
    new CsTeams:Ateam = cs_get_user_team(attacker) 
     
    return (Vteam && Ateam == CS_TEAM_T) ? HAM_SUPERCEDE : HAM_IGNORED 
}

[HamletEagle]

Your problem is right here:

PHP Code:

return (Vteam == Ateam == CS_TEAM_T) ? HAM_SUPERCEDE : HAM_IGNORED 


[NikKOo31]

There's no need to create new var on damage forward. Also may lag/overflow..
Just

PHP Code:

public onTakeDamage(victim, inflictor, attacker, Float:damage, dmgbits) 
{
    return (get_user_team(victim) == 1 && get_user_team(attacker) == 1) ? HAM_SUPERCEDE : HAM_IGNORED 
} 


No need for cstrike inc

[hleV]

Make sure the attacker is a connected player before doing team check.

[meTaLiCroSS]

Originally Posted by NikKOo31 Also may lag/overflow..

Would be better if someone explains "better" what's a lag issue and a overflow problem, since many guys don't know even when they are triggered.

[Nextra]

Originally Posted by NikKOo31 There's no need to create new var on damage forward. Also may lag/overflow.. Just PHP Code: // snip  No need for cstrike inc

Creating a set of variables in TakeDamage will never ever do that. Don't spread misguided and misinformed fear like this, if he needs the variables later or wishes to use them for clarity it is perfectly fine.

Also not using cstrike offers no tangible benefit unless he wants to make this plugin mod-independent.

[NikKOo31]

Originally Posted by meTaLiCroSS Would be better if someone explains "better" what's a lag issue and a overflow problem, since many guys don't know even when they are triggered.

I got servers crashing before I knew statics var -.-

[klippy]

Originally Posted by NikKOo31 I got servers crashing before I knew statics var -.-

However, variables have absolutely nothing to do with overflowing! Overflowing is caused by too much network traffic, and variables are never sent over internet.

[Flick3rR]

I've actually heard that the deafult native (*get_user_team()) has some bugs and doesn't always provide the right team (like not detecting changes, etc..). That's why I prefer using the cs_ native.