Raised This Month: $51 Target: $400
 12% 

Info Players v1.2


Post New Thread Reply   
 
Thread Tools Display Modes
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 03-26-2010 , 09:01   Re: Info Players v1.2
Reply With Quote #31

There are some minor things you could change :

- You should check '/' before all the others checks and you should organized them better, something like :

Code:
    if ( Args[ 0 ] != '/' )     {         return;     }         if ( get_pcvar_num( Admins_Only ) && !is_user_admin( id ) )     {         client_print( id, print_chat, "%L", id, "ONLY_ADMINS" );     }     else if ( containi( Args, "info" ) != -1 )     {         ...     }
- Instead of writing sizeof - 1 ; you can use the macro charsmax(). Something you should apply for all, not only in format().
- Use formatex() instead of format(), it's faster and you can use it safely here.
- It's more efficient to use get_players() like suggested by fezh instead of looping through all players + is_user_connected().
- So using get_players() you will know total players with the second param and you can remove client_putinserver/client_disconnect.
- Don't create var in a loop when you can.
- No need to check if '<' is present before, use directly replace().
- In the first three format(), you could save 2 natives by using only one format.

This plugin doesn't seem useful ; you should try to add more features.

btw :

Code:
[fr]
INFO_PLAYERS = Infos sur les joueurs
NICK = Nom
HEALTH = Vie
ARMOR = Armure
MONEY = Argent
TOTAL = Total des joueurs
ONLY_ADMINS = Uniquement les admins peuvent utiliser la commande.
__________________

Last edited by Arkshine; 03-26-2010 at 09:06.
Arkshine is offline
Filcora
Member
Join Date: Nov 2008
Location: Poland ;)
Old 03-26-2010 , 09:12   Re: Info Players v1.2
Reply With Quote #32

Polish Translation
Code:
[pl]
INFO_PLAYERS = Informacje o Graczach
NICK = Nick
HEALTH = Zycie
ARMOR = Armor
MONEY = Kasa
TOTAL = Liczba Graczy
ONLY_ADMINS = Tylko admini moga tego uzywac.
Filcora is offline
Shidla
Senior Member
Join Date: Nov 2008
Location: Russia, Moscow
Old 03-26-2010 , 09:44   Re: Info Players v1.2
Reply With Quote #33

bg + Ru updated... pl + fr +tr added
And I am not shidla, I am Shidla
Attached Files
File Type: txt InfoPlayers.txt (1.4 KB, 79 views)
__________________
[Russian Federation] NOT USSR
This is madness?! This is Shidla!
[ZP] Laser Mine 2.8.2 ML (NEW !!2013!!) | [ZP] New Win Msg 1.4
| [ZP] MutaDote 1.1

Last edited by Shidla; 03-26-2010 at 09:58.
Shidla is offline
Send a message via ICQ to Shidla Send a message via Skype™ to Shidla
Hawk552
AMX Mod X Moderator
Join Date: Aug 2005
Old 04-02-2010 , 20:31   Re: Info Players v1.2
Reply With Quote #34

This plugin serves no real purpose or can be done using other plugins.

If you would like any information regarding possible adjustments you could make or things you could do to make this better, please feel free to post here or PM me.

Unapproved.
__________________
Hawk552 is offline
Send a message via AIM to Hawk552
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:48.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode