[SweatyBanana]

UPDATED

ty sir..stupid me with my stupid mistakes.

[VEN]

    //...
    register_event("HLTV", "new_round", "a", "1=0", "2=0") 
}  
public new_round()
    //... 

[SweatyBanana]

k

updated.

[bmann_420]

lol, at least your trying.

[Kensai]

Lol.

[Brad]

SweatyBanana:

The following code could be made more efficient:

public new_round()  
{  
    new players[32], num, i;   
    get_players(players,num);   
      
    for(i=0;i<num;i++)   
    givemoney(players[i]);  
}  

public givemoney(id)  
{   
    new cVar = get_cvar_num("round_money")   
    if(cs_get_user_money(id) < cVar)   
    cs_set_user_money(id, cVar)   
}

By changing it to something like this:

public new_round()  
{  
    new cVar = get_cvar_num("round_money");

    new players[32], num, i;   
    get_players(players,num);   
    
    // make sure each player has at least x dollars
    for(i=0;i<num;i++) 
    {
        id = players[i];
        if(cs_get_user_money(id) < cVar)   
            cs_set_user_money(id, cVar);
    }
}

I applaud your attempt to make the code more readible, but in a plugin this small and where the code your factoring out is so small and where the factored out code isn't being called from more than one place, it makes more sense to just comment the code rather than having the overhead of calling another function. Actually the overhead of calling two functions per player.

Make this minor change (not necessarily verbatim as my example) and I'll approve the plugin.

[SweatyBanana]

Oh thank you brad...you are right with your code...no use in setting a players cash to the cvar if they have more money or equal amount of money...

by the way..u forgot to declare id as a new variable


[ UPDATED ]

[SweatyBanana]

Thx EKS for telling me how to get it approved..Thx v3x for approval..


+karma to the both of u.

[SweatyBanana]

I added another plugin to the front post...

Now a new download to keep people from going past the limit.

[SweatyBanana]

Anyone try this out?