[CS] Weapon Mod Beta 1.0

Ghosted · **Plugin Info:**

Closed!

**HamletEagle** · 01-05-2016 , 12:50 Re: [CS] Weapon Mod Beta 0.7

Lol, are you serious with all this huge and useless switch structs ? Please, learn more before getting into this kind of things.

Ghosted · *Last edited by Ghosted; 01-05-2016 at 12:59.*

Ya I Thinked About That After I Write Full Code

But Im Too Lazy

**HamletEagle** · 01-05-2016 , 13:11 Re: [CS] Weapon Mod Beta 0.7

You have to find another way, this is not acceptable. If you need help, ask.

Ghosted · 01-05-2016 , 13:25 Re: [CS] Weapon Mod Beta 0.7

Quote:

Originally Posted by HamletEagle

You have to find another way, this is not acceptable. If you need help, ask.

You here talking about those too many switches and variables?

**HamletEagle** · 01-05-2016 , 13:35 Re: [CS] Weapon Mod Beta 0.7

At the moment, about the switches, because you have better ways.

KORD_12.7 · 01-05-2016 , 21:38 Re: [CS] Weapon Mod Beta 0.7

Omg, this code is one big switch o_O

Ghosted · 01-06-2016 , 00:49 Re: [CS] Weapon Mod Beta 0.7

Quote:

Originally Posted by KORD_12.7

Omg, this code is one big switch o_O

Just Wait I Will ReCode

Ghosted · 01-06-2016 , 02:24 Re: [CS] Weapon Mod Beta 0.8

Done.

addons_zz · 01-06-2016 , 04:46 Re: [CS] Weapon Mod Beta 0.8

Hi, I made some observations about you code as follows. What do you think about them?

Spoiler

At 'stock UTIL_WeaponPrecacheSounds(const model[])' use a for because the code is too much similar, them probably can be placed within a for.

At 'public UTIL_WeaponModelReset(id, cswpn)' and 'stock UTIL_WeaponSetSprite(id, cswpn, const name[])', break the list as follows to improve readability:

Code:

    switch(cswpn)
    {
        case CSW_GLOCK18: 
        { 
            sprite = spr; 
            primammoid = -1; 
            primammomax = -1; 
            secammoid = 10; 
            secammomax = 120; 
            slotid = 1; 
            slotnum = 17;
        }

Or:

Code:

    switch(cswpn) {
        case CSW_GLOCK18: { 
            sprite = spr; 
            primammoid = -1; 
            primammomax = -1; 
            secammoid = 10; 
            secammomax = 120; 
            slotid = 1; 
            slotnum = 17;
        }

At 'stock util_weapon_find(model[])', use tries to improve speed.

At 'stock get_weapon_attachment(id, Float:output[3], Float:fDis = 40.0)', declare all new variables at the beginning of the scope to improve readability. Ex:

Code:

    new viEnd[3] 
    new Float:vfEnd[3]
    new Float:fOrigin[3]
    new Float:fAngle[3]
    new Float:fAttack[3]
    new Float:fRate

    get_user_origin(id, viEnd, 3)  
    IVecFVec(viEnd, vfEnd) 
    
    pev(id, pev_origin, fOrigin) 
    pev(id, pev_view_ofs, fAngle)
    
    xs_vec_add(fOrigin, fAngle, fOrigin) 
    
    xs_vec_sub(vfEnd, fOrigin, fAttack)
    xs_vec_sub(vfEnd, fOrigin, fAttack) 

    fRate = fDis / vector_length(fAttack)
    xs_vec_mul_scalar(fAttack, fRate, fAttack)
    
    xs_vec_add(fOrigin, fAttack, output)

At 'public fw_CmdStart(id, uc_handle, seed)', use a switch for 'Weapon_Attack2' variable, instead of if's to improve speed.
At:
- 'public fw_Weapon_Reload(weapon)',
- 'fw_Weapon_PrimaryAttack_Post(weapon)'
- 'public fw_Weapon_PrimaryAttack(weapon)',
- 'public fw_Weapon_PostFrame(weapon) ',
- 'public fw_Weapon_Deploy_Post(weapon)',
- 'public event_CurWeapon(id)' and
- 'public mh_WeaponMenu(id, menu, item)'.
The expression 'if (is_user_connected(player) && is_user_alive(player))', if the user is alive, he is connected, so just 'if (is_user_alive(player))' is fine.

At 'public clcmd_weapon_glock18(id){ engclient_cmd(id, "weapon_glock18"); }' and other like, break lines as follows to improve readability:

Code:

public clcmd_weapon_glock18(id){
    engclient_cmd(id, "weapon_glock18"); 
}

Or:

Code:

public clcmd_weapon_glock18(id)
{
    engclient_cmd(id, "weapon_glock18"); 
}

At 'public native_DisplayMenu(id)' do not declare variables inside a for to improve speed. Because there is a cost to re-create/allocate them every loop, however, a smart compiler may put them out. Ex:

Code:

public native_DisplayMenu(id)
{
    WeaponMenu = menu_create("\wGhost's \yWeapon Mod^nSelect Weapon:", "mh_WeaponMenu")

    new Cost
    new Access

    new Text[128]
    new Name[32]
    
    for(new i=0; i<WeaponArrayCount; i++)
    {
        ArrayGetString(WeaponArrayName, i, Name, charsmax(Name))

At 'new const CSW_NAMES[][]', declare them separated by new lines to improve readability. Ex:

Code:

new const CSW_NAMES[][] =
{
    "weapon_glock18", 
    "weapon_usp", 
    "weapon_p228", 
    "weapon_deagle", 
    "weapon_fiveseven", 
    "weapon_elite", 
    "weapon_m3", 
    "weapon_xm1014", 
    "weapon_tmp", 
    "weapon_mac10", 
    "weapon_mp5navy", 
    "weapon_ump45", 
    "weapon_p90", 
    "weapon_famas", 
    "weapon_galil", 
    "weapon_m4a1", 
    "weapon_ak47", 
    "weapon_aug", 
    "weapon_sg552", 
    "weapon_sg550", 
    "weapon_g3sg1", 
    "weapon_scout", 
    "weapon_awp", 
    "weapon_m249"
}

At 'new Array:WeaponArrayName, ...', declare them at new lines to improve readability. Ex:

Code:

new Array:WeaponArrayName
new Array:WeaponArrayModel
new Array:WeaponArrayCsWpn
new Array:WeaponArrayFSound
new Array:WeaponArrayClip
new Array:WeaponArrayAmmo
new Array:WeaponArrayAnimDraw
new Array:WeaponArrayAnimShoot
new Array:WeaponArrayAnimReload
new Array:WeaponArrayDeploy
new Array:WeaponArrayDelay
new Array:WeaponArrayDamage
new Array:WeaponArrayRecoil
new Array:WeaponArrayReload

At and others:

Code:

    if(ArrayGetCell(WeaponArrayCost, item) > 0)
        cs_set_user_money(id, cs_get_user_money(id) - ArrayGetCell(WeaponArrayCost, item))
    WeaponKey[id][cswpn] = ArrayGetCell(WeaponArrayKey, item)
    return PLUGIN_HANDLED

Put a new line between the 'if' and 'WeaponKey...' to improve readability. Ex:

Code:

    if(ArrayGetCell(WeaponArrayCost, item) > 0)
        cs_set_user_money(id, cs_get_user_money(id) - ArrayGetCell(WeaponArrayCost, item))

    WeaponKey[id][cswpn] = ArrayGetCell(WeaponArrayKey, item)
    return PLUGIN_HANDLED

Update:

I placed in red, which ones do not relating to codding rightness. So the red ones are as I code and think let me to a clean coding to avoid mistakes errors, but each one code as they think is good for them just as myself.

About my codding style, I am usually updating it so last year I coded very much differently from today, but it is because I am just starting getting experience and learn things. So as much as the time pass, I change less the way I write code, and recently I am not changing too much or likely not changing at all.