Real Weapon Drop - Page 11

fiury · 08-03-2011 , 14:51 Re: Real Weapon Drop

because the grenades do not stop bouncing?

MPNumB · 09-21-2011 , 20:15 Re: Real Weapon Drop

After 3 and a half years since original release, this plugin had many downloads and is one of most popular ones what I've created. However back then my coding skills were quite a bit less advance, therefor now I've decided to make a full rewrite of the plugin, insuring it works on servers as stable as I can make it to be. Also in all fairness, since this is a "from scratch" rewrite, I would like to request this plugin to be moved in New Plugin Submissions section. Also I do hope, that you guys fixed the glitch, where few of my approved plugins don't appear in the http://amxmodx.org/compiler.php link. Yes, I have filed a bug report, but got no response for quite some time. Just in case, those approved plugins are:

Updated to 2.0
Fixed: Grenades do not bounce insane when dropped.
Fixed: VIPs can't no longer pick-up ammunition.
Fixed: VIPs also do drop their weapons if have any.
Changed: Full plugin rewrite - plugin is now much more stable.

Personal record: 19729 downloads reset

**Emp`** · 11-16-2011 , 12:09 Re: Real Weapon Drop

I'm going to leave this in Approved Plugins because it is working fine, just needs some small improvements:

You use static variables a lot. Most of these circumstances are not needed. You should only use static variables for strings and arrays where they are called very often. (ie. prethink, posthink, startframe, etc.)

Not sure why you are using clamp here:

Code:

g_iMaxPlayers = clamp(get_maxplayers(), 1, 32);

Code:
```
FM_SetModel_Pre(iEnt, iModel[])
```
iModel should be szModel, it is not an integer.
When comparing the model name to weapon models, you should not have it check against "models/". Just use:
Code:
```
if( equal(iModel[9], "glock18.mdl") )
```
You could probably clean this up even more, but at least do that.

In force_weapon_drop you should be able to get rid of your giant if block:

Code:

	if( s_iUserWeapons&(1<<CSW_P228) && iWeaponType!=CSW_P228 ) // just drop all the weapons
		engclient_cmd(iPlrId, "drop", "weapon_p228");

by using a loop and get_weaponname.

MPNumB · 11-28-2011 , 23:25 Re: Real Weapon Drop

Quote:

Originally Posted by Emp`

I'm going to leave this in Approved Plugins because it is working fine, just needs some small improvements:

You use static variables a lot. Most of these circumstances are not needed. You should only use static variables for strings and arrays where they are called very often. (ie. prethink, posthink, startframe, etc.)

Not sure why you are using clamp here:

Code:

g_iMaxPlayers = clamp(get_maxplayers(), 1, 32);

Code:
```
FM_SetModel_Pre(iEnt, iModel[])
```
iModel should be szModel, it is not an integer.
When comparing the model name to weapon models, you should not have it check against "models/". Just use:
Code:
```
if( equal(iModel[9], "glock18.mdl") )
```
You could probably clean this up even more, but at least do that.

In force_weapon_drop you should be able to get rid of your giant if block:

Code:

	if( s_iUserWeapons&(1<<CSW_P228) && iWeaponType!=CSW_P228 ) // just drop all the weapons
		engclient_cmd(iPlrId, "drop", "weapon_p228");

by using a loop and get_weaponname.

I'm using static cause there are conditions where those functions can be executed quite often - don't want to risk with "new".

I'm clamping maxplayers, cause I have noticed there are GoldSource engine servers what support more than 32 players (though they are glitchy, but I still don't want no errorlog reports from those servers flooding the posts, PMs or steam).

I'm using iModel[], cause it's basically an integer with many cells.

About my method what can be shorter, I am perfectly aware. In version before I've been using it. However Akrshine thought me that the less amxx natives I'm using, the less resources plugin uses. Now if he's reading this, he's probably getting mad with a big smile on his face.

zippel · 12-09-2011 , 04:09 Re: Real Weapon Drop

Please add some function for dropping weapons. All weapons must be stage down in one box such as in HL and +cvar for this func. that's must be very nice.

MPNumB · 03-07-2012 , 07:23 Re: Real Weapon Drop

Updated to 2.1
Changed: Minor performance improvement.

622 downloads reset.

MPNumB · 05-19-2013 , 07:54 Re: Real Weapon Drop

Due to last amxmodx dev-build updates servers may crash at mapchange and/or player disconnect.

In order to avoid crashes, please make sure have rwd_disconnectdrop set to 0 in case if you are using dev-builds, or downgrade to official amxmodx release!!!

ZASTRELIS · 02-04-2014 , 02:29 Re: Real Weapon Drop

Quote:

Originally Posted by MPNumB

Due to last amxmodx dev-build updates servers may crash at mapchange and/or player disconnect.

In order to avoid crashes, please make sure have rwd_disconnectdrop set to 0 in case if you are using dev-builds, or downgrade to official amxmodx release!!!

Code:

;real_weapon_drop.amxx debug (maybe bugged. I don't know. But server crashed with him_)

HTML Code:

I using official not dev builds

MPNumB · 02-04-2014 , 14:36 Re: Real Weapon Drop

try rwd_disconnectdrop 0 in amxx.cfg

// EDIT:

Updated to 2.3
Fixed: Crash at mapchange if there's too many players and other entities.
Changed: More reliability when saving number of dropped bullets and flash grenades.

(1751 downloads reset)

baneado · 05-02-2015 , 18:01 Re: Real Weapon Drop

A cvar to select when you want to emit sound of picking up items will be great.