[away000]

maybe u can make a logfile who show Nick SteamID Reset his score....

[shavit]

Originally Posted by away000 maybe u can make a logfile who show Nick SteamID Reset his score....

Sure, it will be added to the next update too.

[thetwistedpanda]

Review for Approval
Status: Pending Feature Additions / Code Correction

• Your plugin currently does not provide any features that are not already available by existing plugins: Exvel's Save Scores and tuty's Resetscore. The former provides saving scores, saving cash, multiple games, etc, while the latter is CS:S specific that provides the core functionality with no fluff.
• You do not need to attach random images such as a cookie for a plugin thread...
• Now as for your coding:
  • While not required, it's usually a good idea to prefix your variables with their type. For example, you already use "g_" to signify global, and "h" for handles, albeit your usage is hit/miss. You can prefix integers with i, floats with f, b for bools, and strings with s to make your code easier to read. iResets, fTimeleft, and sResets allow you to easily see what type a variable is.
  • You declare "resets" to 64 characters, when it's an integer that is with in the single digits. resets[2] or resets[3] would be more desirable (why declare 62 other characters if they're never used?)
  • Your usage of ConVarChanged is incorrect as well as inefficient - there's no reason to update all variables when ConVarChanged only changes one convar at a time.
  • PHP Code:

    public ConVarChanged(Handle:convar, const String:oldVal[], const String:newVal[])
{
    if(convar == gH_Enabled)
        Enabled = StringToInt(newVal) ? true : false;
    else if(convar == gH_Resets)
        Resets = StringToInt(newVal);
    else if(convar == gH_ResetTime)
        Timeleft = StringToFloat(newVal);
} 

  • There's no need to hook your version cvar.
  • You should never pass a client index within a trigger: instead use their userid or serial and get the new value within the Timer. This ensures a new client doesn't inherit a previous client's timer. Alternatively, you can create an array of Handles per client and kill the timer when the client disconnects.

[shavit]

Originally Posted by thetwistedpanda Review for Approval Status: Pending Feature Additions / Code Correction Your plugin currently does not provide any features that are not already available by existing plugins: Exvel's Save Scores and tuty's Resetscore. The former provides saving scores, saving cash, multiple games, etc, while the latter is CS:S specific that provides the core functionality with no fluff. You do not need to attach random images such as a cookie for a plugin thread... Now as for your coding: While not required, it's usually a good idea to prefix your variables with their type. For example, you already use "g_" to signify global, and "h" for handles, albeit your usage is hit/miss. You can prefix integers with i, floats with f, b for bools, and strings with s to make your code easier to read. iResets, fTimeleft, and sResets allow you to easily see what type a variable is. You declare "resets" to 64 characters, when it's an integer that is with in the single digits. resets[2] or resets[3] would be more desirable (why declare 62 other characters if they're never used?) Your usage of ConVarChanged is incorrect as well as inefficient - there's no reason to update all variables when ConVarChanged only changes one convar at a time. PHP Code: public ConVarChanged(Handle:convar, const String:oldVal[], const String:newVal[]) {     if(convar == gH_Enabled)         Enabled = StringToInt(newVal) ? true : false;     else if(convar == gH_Resets)         Resets = StringToInt(newVal);     else if(convar == gH_ResetTime)         Timeleft = StringToFloat(newVal); }  There's no need to hook your version cvar. You should never pass a client index within a trigger: instead use their userid or serial and get the new value within the Timer. This ensures a new client doesn't inherit a previous client's timer. Alternatively, you can create an array of Handles per client and kill the timer when the client disconnects.

Done

2.0 - Anything here. Stopped using cookies. New cvar. I have no idea why I made the plugin to work with CS:S only, so lets go with all games! Now everybody will be able to read this scarmbled code :S

[asherkin]

While it's awesome that you fixed the suggestions, this still wont be approved as it's a dupe of currently approved plugins - while choice is good, fracturing the user base isn't.

[shavit]

Originally Posted by asherkin While it's awesome that you fixed the suggestions, this still wont be approved as it's a dupe of currently approved plugins - while choice is good, fracturing the user base isn't.

It have many features that other plugins don't have.
It can give the user the resets that he used back after defined time, advantage for admins and much more that I can add soon.

[asherkin]

Originally Posted by shavit It have many features that other plugins don't have. It can give the user the resets that he used back after defined time, advantage for admins and much more that I can add soon.

That's a non-feature, people will just rejoin the server if they run out of resets and want to reset their score.

[shavit]

Originally Posted by asherkin That's a non-feature, people will just rejoin the server if they run out of resets and want to reset their score.

2.1 -
The plugin will don't allow players to get 0/0 score after retry if the time haven't passed.

[butaford]

can add some functions from this code?

Spoiler

PHP Code:

#pragma semicolon 1
#include <sourcemod>
#include <sdktools>

#define PLUGIN_AUTHOR    "tuty & GoDtm666"
#define PLUGIN_VERSION    "1.3.3"

new Handle:g_hEnabled = INVALID_HANDLE,
    Handle:g_hTimerMsg = INVALID_HANDLE,
    Handle:g_hTimer = INVALID_HANDLE;
    
new bool:g_bEnabled = false,
    bool:g_bSayHook = false;
    
new Float:g_fTimer;

public Plugin:myinfo =
{
    name = "Reset Score",
    author = PLUGIN_AUTHOR,
    description = "Type !resetscore in chat to reset your score.",
    version = PLUGIN_VERSION,
    url = "www.ligs.us"
};

public OnPluginStart()
{
    decl String:sGame[64];
    GetGameFolderName(sGame, sizeof(sGame));
    if (StrEqual(sGame, "cstrike", false))
    {
        g_hEnabled = CreateConVar("sm_resetscore", "1", "1 Включить, 0 Выключить.", FCVAR_PLUGIN, true, 0.0, true, 1.0);
        OnSettingsChanged(g_hEnabled, "", "");
        HookConVarChange(g_hEnabled, OnSettingsChanged);
        g_hTimerMsg = CreateConVar("sm_resetscore_announce_timer", "0.0", "Через сколько времени (в секундах) прокручивать подсказку для сброса счета. (0 отключить.)", FCVAR_PLUGIN, true, 0.0);
        OnSettingsChanged(g_hTimerMsg, "", "");
        HookConVarChange(g_hTimerMsg, OnSettingsChanged);
        if (GuessSDKVersion() == SOURCE_SDK_EPISODE2VALVE)
        {
            g_bSayHook = true;
            RegConsoleCmd("say", Command_Say, "say", 0);
            RegConsoleCmd("say_team", Command_Say, "say_team", 0);
        }
        else
        {
            g_bSayHook = false;
            RegConsoleCmd("rs", Command_Say, "Restart Score", 0);
            RegConsoleCmd("resetscore", Command_Say, "Restart Score", 0);
            RegConsoleCmd("restartscore", Command_Say, "Restart Score", 0);
            RegConsoleCmd("rdk", Command_Say, "Restart Score", 0);
            RegConsoleCmd("кы", Command_Say, "Restart Score", 0);
            RegConsoleCmd("куыуеысщку", Command_Say, "Restart Score", 0);
            RegConsoleCmd("куыефкеысщку", Command_Say, "Restart Score", 0);
            RegConsoleCmd("квл", Command_Say, "Restart Score", 0);
        }
        CreateConVar("sm_resetscore_version", PLUGIN_VERSION, "Reset Score Version", FCVAR_PLUGIN |FCVAR_SPONLY|FCVAR_REPLICATED|FCVAR_NOTIFY);
        LoadTranslations("resetscore.phrases.txt");
    }
    else
    {
        SetFailState("This game is not supported!");
    }
}

public OnSettingsChanged(Handle:convar, const String:oldValue[], const String:newValue[])
{
    if (g_hTimer != INVALID_HANDLE)
    {
        KillTimer(g_hTimer, false);
        g_hTimer = INVALID_HANDLE;
    }
    if (g_hEnabled == convar)
    {
        g_bEnabled = GetConVarBool(convar);
    }
    else if (g_hTimerMsg == convar)
    {
        if (GetConVarBool(convar))
        {
            g_fTimer = GetConVarFloat(convar);
            g_hTimer = CreateTimer(4.9, Timer_Announce);
        }
    }
}

public Action:Timer_Announce(Handle:timer)
{
    PrintToChatAll("\x04%t\x01 %t", "rs_tag", "announce_chat");
    g_hTimer = CreateTimer(g_fTimer, Timer_Announce);
    return Plugin_Continue;
}

public Action:Command_Say(client, args)
{
    if (g_bSayHook)
    {
        decl String:sBuffer[32];
        GetCmdArgString(sBuffer, sizeof(sBuffer));
        StripQuotes(sBuffer);
        TrimString(sBuffer);
        if (StrEqual(sBuffer, "!resetscore", false) || StrEqual(sBuffer, "!restartscore", false) || StrEqual(sBuffer, "!rs", false) || StrEqual(sBuffer, "!rdk", false) || StrEqual(sBuffer, "!куыуеысщку", false) || StrEqual(sBuffer, "!куыефкеысщку", false) || StrEqual(sBuffer, "!кы", false) || StrEqual(sBuffer, "!квл", false))
        {
            if (g_bEnabled)
            {
                EditScore(client);
            }
            else
            {
                PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "plugin_disabled_chat");
                PrintToConsole(client, "%t %t", "rs_tag", "plugin_disabled_console");
            }
            return Plugin_Stop;
        }
    }
    else
    {
        if (g_bEnabled)
        {
            EditScore(client);
        }
        else
        {
            PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "plugin_disabled_chat");
            PrintToConsole(client, "%t %t", "rs_tag", "plugin_disabled_console");
        }
    }
    return Plugin_Continue;
}

public EditScore(client)
{
    if (!GetClientDeaths(client) && !GetClientFrags(client))
    {
        PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "reset_already_chat");
        PrintToConsole(client, "%t %t", "rs_tag", "reset_already_console");
    }
    else
    {
        decl String:sName[MAX_NAME_LENGTH], String:sMesg[128];
        SetClientFrags(client);
        SetClientDeaths(client);
        GetClientName(client, sName, sizeof(sName));
        PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "reset_chat");
        new Handle:hBuffer = StartMessageAll("SayText2");
        Format(sMesg, sizeof(sMesg), "\x04%t\x01 %t", "rs_tag", "reset_chat_all", "\x03", sName, "\x01");
        if (hBuffer != INVALID_HANDLE)
        {
            BfWriteByte(hBuffer, client);
            BfWriteByte(hBuffer, true);
            BfWriteString(hBuffer, sMesg);
            EndMessage();
        }
        PrintToConsole(client, "%t %t", "rs_tag", "reset_console" );
    }
}

stock SetClientFrags(client)
{
    SetEntProp(client, Prop_Data, "m_iFrags", 0);
    return true;
}

stock SetClientDeaths(client)
{
    SetEntProp(client, Prop_Data, "m_iDeaths", 0);
    return true;
} 


[shavit]

Originally Posted by butaford can add some functions from this code? Spoiler PHP Code: #pragma semicolon 1 #include <sourcemod> #include <sdktools> #define PLUGIN_AUTHOR    "tuty & GoDtm666" #define PLUGIN_VERSION    "1.3.3" new Handle:g_hEnabled = INVALID_HANDLE,     Handle:g_hTimerMsg = INVALID_HANDLE,     Handle:g_hTimer = INVALID_HANDLE;      new bool:g_bEnabled = false,     bool:g_bSayHook = false;      new Float:g_fTimer; public Plugin:myinfo = {     name = "Reset Score",     author = PLUGIN_AUTHOR,     description = "Type !resetscore in chat to reset your score.",     version = PLUGIN_VERSION,     url = "www.ligs.us" }; public OnPluginStart() {     decl String:sGame[64];     GetGameFolderName(sGame, sizeof(sGame));     if (StrEqual(sGame, "cstrike", false))     {         g_hEnabled = CreateConVar("sm_resetscore", "1", "1 Включить, 0 Выключить.", FCVAR_PLUGIN, true, 0.0, true, 1.0);         OnSettingsChanged(g_hEnabled, "", "");         HookConVarChange(g_hEnabled, OnSettingsChanged);         g_hTimerMsg = CreateConVar("sm_resetscore_announce_timer", "0.0", "Через сколько времени (в секундах) прокручивать подсказку для сброса счета. (0 отключить.)", FCVAR_PLUGIN, true, 0.0);         OnSettingsChanged(g_hTimerMsg, "", "");         HookConVarChange(g_hTimerMsg, OnSettingsChanged);         if (GuessSDKVersion() == SOURCE_SDK_EPISODE2VALVE)         {             g_bSayHook = true;             RegConsoleCmd("say", Command_Say, "say", 0);             RegConsoleCmd("say_team", Command_Say, "say_team", 0);         }         else         {             g_bSayHook = false;             RegConsoleCmd("rs", Command_Say, "Restart Score", 0);             RegConsoleCmd("resetscore", Command_Say, "Restart Score", 0);             RegConsoleCmd("restartscore", Command_Say, "Restart Score", 0);             RegConsoleCmd("rdk", Command_Say, "Restart Score", 0);             RegConsoleCmd("кы", Command_Say, "Restart Score", 0);             RegConsoleCmd("куыуеысщку", Command_Say, "Restart Score", 0);             RegConsoleCmd("куыефкеысщку", Command_Say, "Restart Score", 0);             RegConsoleCmd("квл", Command_Say, "Restart Score", 0);         }         CreateConVar("sm_resetscore_version", PLUGIN_VERSION, "Reset Score Version", FCVAR_PLUGIN |FCVAR_SPONLY|FCVAR_REPLICATED|FCVAR_NOTIFY);         LoadTranslations("resetscore.phrases.txt");     }     else     {         SetFailState("This game is not supported!");     } } public OnSettingsChanged(Handle:convar, const String:oldValue[], const String:newValue[]) {     if (g_hTimer != INVALID_HANDLE)     {         KillTimer(g_hTimer, false);         g_hTimer = INVALID_HANDLE;     }     if (g_hEnabled == convar)     {         g_bEnabled = GetConVarBool(convar);     }     else if (g_hTimerMsg == convar)     {         if (GetConVarBool(convar))         {             g_fTimer = GetConVarFloat(convar);             g_hTimer = CreateTimer(4.9, Timer_Announce);         }     } } public Action:Timer_Announce(Handle:timer) {     PrintToChatAll("\x04%t\x01 %t", "rs_tag", "announce_chat");     g_hTimer = CreateTimer(g_fTimer, Timer_Announce);     return Plugin_Continue; } public Action:Command_Say(client, args) {     if (g_bSayHook)     {         decl String:sBuffer[32];         GetCmdArgString(sBuffer, sizeof(sBuffer));         StripQuotes(sBuffer);         TrimString(sBuffer);         if (StrEqual(sBuffer, "!resetscore", false) || StrEqual(sBuffer, "!restartscore", false) || StrEqual(sBuffer, "!rs", false) || StrEqual(sBuffer, "!rdk", false) || StrEqual(sBuffer, "!куыуеысщку", false) || StrEqual(sBuffer, "!куыефкеысщку", false) || StrEqual(sBuffer, "!кы", false) || StrEqual(sBuffer, "!квл", false))         {             if (g_bEnabled)             {                 EditScore(client);             }             else             {                 PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "plugin_disabled_chat");                 PrintToConsole(client, "%t %t", "rs_tag", "plugin_disabled_console");             }             return Plugin_Stop;         }     }     else     {         if (g_bEnabled)         {             EditScore(client);         }         else         {             PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "plugin_disabled_chat");             PrintToConsole(client, "%t %t", "rs_tag", "plugin_disabled_console");         }     }     return Plugin_Continue; } public EditScore(client) {     if (!GetClientDeaths(client) && !GetClientFrags(client))     {         PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "reset_already_chat");         PrintToConsole(client, "%t %t", "rs_tag", "reset_already_console");     }     else     {         decl String:sName[MAX_NAME_LENGTH], String:sMesg[128];         SetClientFrags(client);         SetClientDeaths(client);         GetClientName(client, sName, sizeof(sName));         PrintToChat(client, "\x04%t\x01 %t", "rs_tag", "reset_chat");         new Handle:hBuffer = StartMessageAll("SayText2");         Format(sMesg, sizeof(sMesg), "\x04%t\x01 %t", "rs_tag", "reset_chat_all", "\x03", sName, "\x01");         if (hBuffer != INVALID_HANDLE)         {             BfWriteByte(hBuffer, client);             BfWriteByte(hBuffer, true);             BfWriteString(hBuffer, sMesg);             EndMessage();         }         PrintToConsole(client, "%t %t", "rs_tag", "reset_console" );     } } stock SetClientFrags(client) {     SetEntProp(client, Prop_Data, "m_iFrags", 0);     return true; } stock SetClientDeaths(client) {     SetEntProp(client, Prop_Data, "m_iDeaths", 0);     return true; }

Actually, this code is very hard to read, just tell me which features you want. [list them]