[Player 1]

When this code runs the server immediately crashes. I'm think the while loop isn't terminating properly, but I can't see why it wouldn't.

My array may also be the problem since I have no experience working with this function.

Just to be clear, I'm working on a balancer that evens the teams based on the player's rank. I'm trying to store all the ranks in an array using the client's index as the array index.
'count' is the level I'm searching for in the array. If it's not found, it should decrement and search for the next number.

Can anyone see what might be going wrong?

PHP Code:

BalanceTeams() {
    new Handle:Array = CreateArray(4, 33);
    new bool:team, bool:complete;
    new count = 80;
    
    for (new i = 1; i <= MaxClients; i++) {
        if (IsClientInGame(i)) {
            SetArrayCell(Array, i, GetEntData(g_iPlayerManager, g_iRankOffset + 4*i));
        }
    }

    while(!complete) {
        new client = FindValueInArray(Array, count);
        if (client > -1) {
            if (IsClientInGame(client)) {
                ChangeClientTeam(client, 1);
                ChangeClientTeam(client,team ? 2 : 3);
                team = !team;
                SetArrayCell(Array, client, -1);
            }
            continue;
        }
        else {
            count--;
            if (count < 0) {
                break;
            }
            continue;
        }
    }
    return;
} 


[11530]

I haven't used SetArrayCell(Array, i, GetEntData(g_iPlayerManager, g_iRankOffset + 4*i)); before, but perhaps thats the offending code since the rest looks ok.

[berni]

uhm, complete is always false ? you are not setting it to true at any time.

[Player 1]

But I'm using break. I had complete be set to true at one point, then changed to break to see if it made a difference.

@11530
It is just getting an integer value and setting it in the array. Unless I'm misunderstanding exactly what a cell is.

[Mitchell]

Originally Posted by Player 1 But I'm using break. I had complete be set to true at one point, then changed to break to see if it made a difference. @11530 It is just getting an integer value and setting it in the array. Unless I'm misunderstanding exactly what a cell is.

make complete = true; before the break.

[Player 1]

Originally Posted by Mitchell make complete = true; before the break.

PHP Code:

        else {
            count--;
            if (count < 0) {
                complete = true;
                break;
            } 


Didn't change anything

[Leonardo]

while( count >= 0 )
{
}

[blodia]

PHP Code:

BalanceTeams() {
    new Handle:Array = CreateArray(4, 33);
    new bool:team;
    new count = 80;
    
    for (new i = 1; i <= MaxClients; i++) {
        if (IsClientInGame(i)) {
            SetArrayCell(Array, i, GetEntData(g_iPlayerManager, g_iRankOffset + 4*i));
        }
    }

    while(count > 0) {
        new client = FindValueInArray(Array, count);
        if (client > -1) {
            if (IsClientInGame(client)) {
                ChangeClientTeam(client, 1);
                ChangeClientTeam(client,team ? 2 : 3);
                team = !team;
                SetArrayCell(Array, client, -1);
            }
        }
        else {
            count--;
        }
    }
    return;
} 


try that, you break when a certain condition is met so why not just use that for the loop condition to start with, also you don't need any of the continues as you placed them just before the loop would start again anyway.

[Player 1]

Originally Posted by Leonardo while( count >= 0 ) { }

Not that either.

I'm almost certain it's not the loop at this point. It has to be the array. Trouble is, I don't see anything wrong with that either.

[Player 1]

That did it blodia. Thanks for your help everyone!