[KiLLeR.]

What is problem, why crashing without any errors?!

PHP Code:

#define TASK_EXPLODE 1111

#define EXPLOSION_MAX_DAMAGE 100
#define EXPLOSION_RANGE 300
#define EXPLOSION_BLAST_RADIUS 250

new toucher_owner;
new Float:g_origin[3];

// It's called when the entity is touched
public mine_explosion(toucher, touched)
{
    toucher_owner = entity_get_edict(toucher, EV_ENT_owner);
    
        // Only crashing if this check is passed!
    if(cs_get_user_team(touched) != cs_get_user_team(toucher_owner))
    {
        entity_get_vector(toucher, EV_VEC_origin, g_origin);
    
        set_task(0.5, "explode", toucher + TASK_EXPLODE);
    
        emit_sound(toucher, CHAN_AUTO, "ambience/particle_suck1.wav", VOL_NORM, ATTN_NORM, 0, PITCH_NORM);
    }
}

public explode(toucher)
{    
    toucher -= TASK_EXPLODE;
    
    new Float:position[3];
    position[0] = g_origin[0] + random_float(-100.0, 100.0);
    position[1] = g_origin[1] + random_float(-100.0, 100.0);
    position[2] = g_origin[2] + random_float(-50.0, 50.0);

    te_explosion(Float:g_origin, Float:position, zerogxplode, (random_num(0,20) + 20), 12, TE_EXPLFLAG_NONE);
    te_smoke(Float:g_origin, Float:position, steam1, 60, 10);
        
    new players[32], num, i;
    get_players(players, num, "a");

    new target, Float:target_origin[3], Float:distance, damage;
    new multiplier = (EXPLOSION_MAX_DAMAGE * EXPLOSION_MAX_DAMAGE) / EXPLOSION_RANGE;
    
    for(i=0; i<num; i++)
    {
        target = players[i];
        
        entity_get_vector(target, EV_VEC_origin, target_origin);

        distance = get_distance_f(g_origin, target_origin);
        
        if(distance < EXPLOSION_RANGE && cs_get_user_team(toucher_owner) != cs_get_user_team(target))
        {
            damage = (EXPLOSION_RANGE - floatround(distance)) * multiplier;
            damage = sqroot(damage);
            
            ExecuteHamB(Ham_TakeDamage, target, toucher, toucher, damage, DMG_ALWAYSGIB);
            
            remove_entity(toucher);
        }
    }
}

stock te_explosion(Float:origin[3], Float:position[3], sprite, scale, framerate, flags)
{
    engfunc(EngFunc_MessageBegin, MSG_PVS, SVC_TEMPENTITY, origin);
    write_byte(TE_EXPLOSION);
    engfunc(EngFunc_WriteCoord, position[0]); // position.x
    engfunc(EngFunc_WriteCoord ,position[1]); // position.y
    engfunc(EngFunc_WriteCoord, position[2]); // position.z
    write_short(sprite); // sprite index
    write_byte(scale); // scale in 0.1's
    write_byte(framerate); // framerate
    write_byte(flags); // flags
    message_end();
}

stock te_smoke(Float:origin[3], Float:position[3], sprite, scale, framerate)
{
    engfunc(EngFunc_MessageBegin, MSG_PVS, SVC_TEMPENTITY, origin);
    write_byte(TE_SMOKE);
    engfunc(EngFunc_WriteCoord, position[0]); // position.x
    engfunc(EngFunc_WriteCoord ,position[1]); // position.y
    engfunc(EngFunc_WriteCoord, position[2]); // position.z
    write_short(sprite); // sprite index
    write_byte(scale); // scale in 0.1's
    write_byte(framerate); // framerate
    message_end();
} 


[jimaway]

touch is called every frame that the touch occurs. i would think spamming the emit_sound will crash the server, try commenting it out and test it

[KiLLeR.]

Originally Posted by jimaway touch is called every frame that the touch occurs. i would think spamming the emit_sound will crash the server, try commenting it out and test it

Again crashing...

[Flick3rR]

As @jimaway has already mentioned, the touch is called each frame while the entities are in contact. So I guess that setting a task each frame will cause the server to crash. So I'd guess to check if the task already exist and then set it.

PHP Code:

if(!task_exists(toucher + TASK_EXPLODE))
  set_task(0.5, "explode", toucher + TASK_EXPLODE) 


[yokomo]

Make sure to check is_user_connected(index), this is important.

PHP Code:

public mine_explosion(toucher, touched)
{
    if(is_valid_ent(toucher) && is_user_connected(touched))
    {
        toucher_owner = entity_get_edict(toucher, EV_ENT_owner);
        if(is_user_connected(toucher_owner))
        {
            // Only crashing if this check is passed!
            if(cs_get_user_team(touched) != cs_get_user_team(toucher_owner))
            {
                //#define SOLID_NOT 0 // No interaction with other objects
                //if instant explode then you can set EV_INT_solid to SOLID_NOT, to prevent touch again
                entity_set_int(toucher, EV_INT_solid, SOLID_NOT)
                entity_get_vector(toucher, EV_VEC_origin, g_origin);
                set_task(0.5, "explode", toucher + TASK_EXPLODE);
                emit_sound(toucher, CHAN_AUTO, "ambience/particle_suck1.wav", VOL_NORM, ATTN_NORM, 0, PITCH_NORM);
            }
        }
    }
} 


also set_task is not good to use here, you can use "entity_set_float(ent, EV_FL_nextthink, get_gametime()+0.5)"

[aron9forever]

this is a blind shot but this plugin is a tripmine, right?
isn't the mine supposed to explode, and be removed, and not the player?

set_task(0.5, "explode", toucher + TASK_EXPLODE);
->>
set_task(0.5, "explode", touched + TASK_EXPLODE);


just asking because idk the behavior of removing player entity but my common sense tells me it's not a good idea
remove_entity(toucher);

[Flick3rR]

Originally Posted by aron9forever this is a blind shot but this plugin is a tripmine, right? isn't the mine supposed to explode, and be removed, and not the player? set_task(0.5, "explode", toucher + TASK_EXPLODE); ->> set_task(0.5, "explode", touched + TASK_EXPLODE); just asking because idk the behavior of removing player entity but my common sense tells me it's not a good idea remove_entity(toucher);

As far as I can see from the code, the 'toucher' id is the one of the mine entity. Otherwise it makes no sense and should be changed, but if it's so, there shouldn't be a problem.

[HamletEagle]

When trying to remove a player entity the server will crash.

[Flick3rR]

I guess the indexes of the player and the entity should be replace with one another. I mean, just change them with the another one. F*ckin english, killing me...

[KiLLeR.]

Working fine.

PHP Code:

public mine_explosion(toucher, touched)
{
    if(!is_valid_ent(toucher) && !is_user_connected(touched))
        return;

    toucher_owner = entity_get_edict(toucher, EV_ENT_owner);
    
    // Only crashing if this check is passed!
    if(cs_get_user_team(touched) != cs_get_user_team(toucher_owner))
    {
        entity_get_vector(toucher, EV_VEC_origin, g_origin);
        
        if(task_exist(toucher + TASK_EXPLODE))
        {
            set_task(0.5, "explode", toucher + TASK_EXPLODE);
        }
    }
} 


But now i have another problem.

PHP Code:

set_user_health(target, get_user_health(target) - damage); // work!
ExecuteHamB(Ham_TakeDamage, target, toucher, toucher, damage, DMG_ALWAYSGIB); // doesn't work! (there are no errors, just don't take damage) 


I prefer to use Ham_TakeDamage instead of set_user_health.