[LucasFromDK]

I'm trying to create a plugin which checks the map name and if the map is in Maps[][] list to change it to a random one from LegalMaps[][] list.

PHP Code:

static const String: Maps[][] = {
    "de_dust2",
    "de_inferno",
    "de_train",
    "de_mirage"
}

static const String: LegalMaps[][] = {
    "de_vertigo",
    "de_dust",
    "de_aztec",
    "de_nuke"
}

public OnMapStart( ) {
    decl String: MapName[ 128 ]
    GetCurrentMap( MapName, sizeof( MapName ) )
    
    if( StrContains( Maps, MapName ) ) {
        new RandomLegalMap = GetRandomInt( 0, sizeof( LegalMaps ) -1 )
        ServerCommand( "changelevel %s", RandomLegalMap )
    }
} 


[Michael Shoe Maker]

And your problem is...?

[Kailo]

Michael Shoe Maker, i think problem about iteration of array. (StrContains( Maps, MapName ))

PHP Code:

public OnMapStart( ) { 
    decl String: MapName[ 128 ] 
    GetCurrentMap( MapName, sizeof( MapName ) ) 
    
    for ( new i = 0; i < sizeof( Maps ); i++ )
        if( StrEqual( Maps[i], MapName ) )
            ServerCommand( "changelevel %s", LegalMaps[ GetRandomInt( 0, sizeof( LegalMaps ) - 1 ) ] ) 
} 


[KissLick]

The question should be "Why do something like that? Maplists are also a thing..."

As fo the code.. I would do something like

PHP Code:

new Handle:g_hBadMaps;
new Handle:g_hLegalMaps;

public OnPluginStart()
{
    g_hBadMaps = CreateArray(64);
    g_hLegalMaps = CreateArray(64);
    
    PushArrayString(g_hBadMaps, "de_dust2");
    PushArrayString(g_hBadMaps, "de_inferno");
    PushArrayString(g_hBadMaps, "de_train");
    PushArrayString(g_hBadMaps, "de_mirage");
    
    PushArrayString(g_hLegalMaps, "de_vertigo");
    PushArrayString(g_hLegalMaps, "de_dust");
    PushArrayString(g_hLegalMaps, "de_aztec");
    PushArrayString(g_hLegalMaps, "de_nuke");
}

public OnMapStart()
{
    new String:sMap[64];
    GetCurrentMap(sMap, sizeof(sMap));

    if (FindStringInArray(g_hBadMaps, sMap) != -1) {
        new i = GetRandomInt(0, GetArraySize(g_hLegalMaps));

        GetArrayString(g_hLegalMaps, i, sMap, sizeof(sMap));
        ForceChangeLevel(sMap);
    }
} 


[klippy]

A hashmap would be better for the bad maps collection.

[KissLick]

Originally Posted by KliPPy A hashmap would be better for the bad maps collection.

+1

But I still use old/legacy syntax and there is no IsKeyInTrie function :-D

[Powerlord]

Originally Posted by KissLick +1 But I still use old/legacy syntax and there is no IsKeyInTrie function :-D

A few things about this.

1. GetTrie* returns false when a key doesn't exist.
2. You can use a Trie snapshot to check for it:

PHP Code:

// Old Style
stock bool:IsKeyInTrie(Handle:trie, const String:key[])
{
    new Handle:snapshot = CreateTrieSnapshot(trie);
    new snapShotLen = TrieSnapshotLength(snapshot);
    new bool:found;

    for (new i = 0; i < snapShotLen; i++)
    {
        new length = TrieSnapshotKeyBufferSize(trie, i);
        new String:myKey[length];
        GetTrieSnapshotKey(trie, i);
        if (StrEqual(key, myKey))
        {
            found = true;
            break;
        }
    }

    CloseHandle(snapshot);
    return found;
}

// New Style
stock bool IsKeyInTrie(StringMap trie, const char[] key)
{
    StringMapSnapshot snapshot = trie.Snapshot();
    int snapShotLen = snapshot.Length;
    bool found;

    for (int i = 0; i < snapShotLen; i++)
    {
        int length = snapshot.KeyBufferSize(i);
        char[] myKey = new char[length];
        snapshot.GetKey(i);
        if (StrEqual(key, myKey))
        {
            found = true;
            break;
        }
    }

    delete snapshot;
    return found;
} 


[KissLick]

Originally Posted by Powerlord A few things about this. 1. GetTrie* returns false when a key doesn't exist. - requires extra variable 2. You can use a Trie snapshot to check for it - this is SM 1.8+ or 1.7+ ?

Good to mention anyway

[Powerlord]

Originally Posted by KissLick Good to mention anyway

The second is 1.7+.

Having said that, if you're not running 1.7 or newer by now, well...