Hi there,
Some things should be changed for approval :
- You shouldn't duplicate your code. You're killing timers in two different ways (code consistency; L562 versus stock in L1516)
- Only one of your timer that is using a client Id is safe. The rest is unsafe way (i.e. DisplayMenu to a client not in game ).
Beside that, you should remove FCVAR_REPLICATED from version ConVar, as well as FCVAR_NOTIFY from NON-version convar.
A post from Peace-Maker explaining why.
Code:
CloseHandle(hRandom);
CloseHandle on ConVar's handle is useless and fails silently (asherkin @ irc).
Code:
MenuTime = (3 + FreezeTime) / 2; //L1610
MenuTime = (4 + FreezeTime) / 2; //L253
Is this really wanted ?
Code:
// KyleS HATES Handles
Good thing ;).
Otherwise, seems alright.
__________________