[xerox8521]

Hi,

would like to suggest that the AddMenuItems natives support format specifiers.

example:

PHP Code:

AddMenuItem(Handle:menu,const String:info[],const String:display[],any:...); 


It wouldnt break the compatibility with previous versions.

[Bara]

stock bool:AddMenuItemEx(Handle:menu, style, String:info[], String:display[], any:...)
{
	decl String:m_display[256];
	VFormat(m_display, sizeof(m_display), display, 5);
	return (AddMenuItem(menu, info, m_display, style)?true:false);
}

[Impact123]

The ternary return is pointless.

[Bara]

Snippet isn't from me.
https://www.dropbox.com/s/cuen066k5v80qjj/gangs.zip (gangs\source\core\include\basestock.inc)

[Dr. Greg House]

This probably hasn't already been added (and is kind of useless) because you could as well want to format the info string (multiply "any"s aren't possible), and also you will probably want to have multiple items and therefore would continue reallocating and freeing (the same) space for each call. If you want it, use it, if you want it to be added to sm, PRs welcome I guess, I doubt it will be added though due to the aforementioned points.

[Powerlord]

If you want to do translation phrases for menus, the MenuAction_DisplayItem callback exists for this reason.

[TnTSCS]

Originally Posted by Impact123 ... ternary ...

Thank you for this - now I know the proper term for this operation that I've used a few times... LoL

Have you ever used multiple ternary evaluations in SM plugins?

PHP Code:

bool firstCheck = false,
bool secondCheck = false,
char access[] = firstCheck ? "Access denied" : secondCheck ? "Access denied" : "Access granted";
  
PrintToServer(access); // Prints "Access granted" 


Or, more than on single operation separated by a comma?

[Chdata]

I do multiple ternaries sometimes. Just read it left to right.

firstcheck ? true = do this : else trythischeck ? true = do this : else do this

[Impact123]

@TnTSCS
No. I tend to change my mind on how code should be formatted over time, but I always though that doing this greatly hinders the readability of code.
I understand that your code is a simple example, but you could avoid the stacking by writing the code like this.

PHP Code:

char access[] = (firstCheck || secondCheck) ? "Access denied" : "Access granted"; 


[11530]

Originally Posted by TnTSCS Thank you for this - now I know the proper term for this operation that I've used a few times... LoL Have you ever used multiple ternary evaluations in SM plugins?

I guess its proper name is the Conditional Operator. Ternary is just an adjective to say it takes three operands, in the same way that +/-/* are binary and ++/-- are unary.

Granted that SourcePawn only has one ternary operator I can think of though...

Resize Players has about 19 of these operators, the most basic being the GetMax function:

PHP Code:

GetMax(const iValA, const iValB)
{
  return (iValA < iValB ? iValB : iValA);
}