[bibu]

How can I make a function by using only edict_t so I can be sure that this function doesn't fail?

[Arkshine]

Don't understand the question. It's anyway unlikely issue is with Orpheu, you do something wrong with the function. Maybe you should start by explaining what are you doing, from where you retrieve an edict etc.

[bibu]

Something you can test easily yourself. Anyway:

PHP Code:

#include < amxmodx >
#include < orpheu >
#include < orpheu_stocks >

#define EdictToIndex(%1) OrpheuCall( o_IndexOfEdict, %1 )

new OrpheuFunction:O_ClientPutInServer, OrpheuFunction:o_IndexOfEdict;

public plugin_precache( )
{
    O_ClientPutInServer = OrpheuGetDLLFunction( "pfnClientPutInServer", "ClientPutInServer" );

    OrpheuRegisterHook(O_ClientPutInServer, "ClientPutInServer", OrpheuHookPost );
    
    o_IndexOfEdict = OrpheuGetFunction( "IndexOfEdict" );
}

public ClientPutInServer( edict_t )
{
    //new id = EdictToIndex( edict_t );
    
    log_amx( "ClientPutInServer" );
} 


The hook works perfect, but once getting the id, it crashes with that error.

[Arkshine]

I see. You know, if you provide edict_s * as type for ClientPutInServer, Orpheu will convert automatically to an index. Tried, and it works fine.

Assuming you want to work with edict, I've also tried using pfnIndexOfEdict (with/out signatures, but no reason to use with).

#include <amxmodx>
#include <orpheu>
#include <orpheu_stocks>

public plugin_precache()
{
    OrpheuRegisterHook(OrpheuGetDLLFunction("pfnClientPutInServer", "ClientPutInServer"), "OnClientPutInServer", OrpheuHookPost);
}

public OnClientPutInServer(pEdict)
{
    new index = ENTINDEX(pEdict);
    
    server_print( "ClientPutInServer - index: %d, pEdict = %d", index, pEdict);
}  

ENTINDEX(edict)
{
    static OrpheuFunction:function;

    if (!function)
    {
        function = OrpheuGetEngineFunction("pfnIndexOfEdict", "IndexOfEdict");
    }
    
    return OrpheuCall(function, edict);
}

{
    "name"      : "ClientPutInServer",
    "library"   : "mod",
    "arguments" :
    [
        {
            "type" : "pointer"
        }
    ]
}

{
    "name"      : "IndexOfEdict",
    "library"   : "engine",
    "arguments" :
    [
        {
            "type" : "pointer"
        }
    ],
    "return":
    {
        "type" : "int"
    }
}

Result:

ClientPutInServer - index: 1, pEdict = 92510652
ClientPutInServer - index: 2, pEdict = 92511456
ClientPutInServer - index: 3, pEdict = 92512260
ClientPutInServer - index: 4, pEdict = 92513064

Your code is ok, the only thing left is you used "edict_s *" in ClientPutInServer ?

[baneado]

will be a summary thread with all updated signatures?

It may help a lot to create new orpheu plugins, many people don't know how to get offsets...

[Arkshine]

It's on the TODO list. But it needs to be thought properly as signature are shared among Orpheu/Okapi/Rage/Others. Just listing signature as it is will be a pain to maintain. Maybe some online tool where you can choose your function, and output format (orpheu, rage, etc) and you will get your config file. And ideally such tool would use some database on github for example, so new functions can be added more easily and fastly.

[GuskiS]

Will orpheu be included in amxmodx package?

[Arkshine]

Nope. But Okapi has a good chance, it's similar to Orpheu, and I'm already working to update it to add missing things (removing treemap, factorize natives, more lib support, structures support, etc). Module is somehow better coded, more flexible and has more useful natives. I would say it fits better. Module needs some update as Joaquim just thrown a first version like a motherfucker (lol) and after that, Orpheu will be deprecated i guess.

[meTaLiCroSS]

Originally Posted by Arkshine as Joaquim just thrown a first version like a motherfucker

[GuskiS]

Dat motherfucker