[SchlumPF*]

Originally Posted by MPNumB If you so like fakemeta, create fm_cstrike.inc. As I know cstrike module is in standard amxx Counter-Strike pack. So why it should not be allowed to use it? Fun also is in standard amxx base. Cstrike module is used in amxx CS pack also and for /rank so... Almost forgot - fun module is used in standard amxx BASE for teleport plugin...

fun sux, engine sux, cstrike is ok but somehow it sux too xD
using the fun natives should really be avoided but the cstrike natives basically do the same as cstrike natives ported to fm, they set offsets in c++. this means i dont think using the cstrike natives is bad or should be avoided even if i dont use them (fm ftw).
for the fm_cstrike.sma... have a look on this http://forums.alliedmods.net/showpos...&postcount=163, made by my personal god of offsets

edit:
btw, "iPlrId<33" in line 177 lol? why dont you use some global variable which stored the result of get_maxplayers()

[MPNumB]

Originally Posted by SchlumPF* btw, "iPlrId<33" in line 177 lol? why dount you use some global variable which stored the result of get_maxplayers()

Cuz it is one more ram variable. Plus right after that check goes g_iIsUserConnected[]. So result and CPU usage will be the same as if using maxplayers. =)

P.S. This version is readable... Next one will be as complicated as my ljstats (well, mby not that much, but... [boosed source code lines in UNTESTED BETA from 320 up to 1227 - worked all night with no sleep] ). <3 SchlumpPF*

// edit:

Now probably will go to sleep. If someone wants to test the beta and say what bugs (if are) found - I uploaded it.

[bmann_420]

Nice, might have to check that out, as I love this plugin
(sorry connorr) lol

[SchlumPF*]

PHP Code:

new iPlrId = find_player("a", iName);    
if( iPlrId<33 && g_bIsUserConnected[clamp(iPlrId, 0, 32)] ) 


so you want to say that find_player() could return a value smaller than 0 or higher than 32 = not a possible players id? im neitehr familiar with your code nor that native but it looks very weird to me. also, a simple global varaible which stores a single cell takes a few byte.
btw your beta is again unreadable why dont you just use fm only since fm is the most important plugin nearly every server has enabled.

[MPNumB]

Originally Posted by SchlumPF* PHP Code: new iPlrId = find_player("a", iName);     if( iPlrId<33 && g_bIsUserConnected[clamp(iPlrId, 0, 32)] )  so you want to say that find_player() could return a value smaller than 0 or higher than 32 = not a possible players id? im neitehr familiar with your code nor that native but it looks very weird to me. also, a simple global varaible which stores a single cell takes a few byte. btw your beta is again unreadable why dont you just use fm only since fm is the most important plugin nearly every server has enabled.

About code: let me put it this way... I trust hl-engine more than amxx natives since update to amxx1.8.0 when I had to fully rewrite amxmisc.inc. =)

And about FM... In beta I made a config of usage FM only or CStrike+Fun. =)

P.S. If you cannot read the code - my mission is done and plugin should be 100% functionally.

[SchlumPF*]

22:21 - dok: What we are looking for in plugins:
* Make sure it's code is clean, concise, and readable.
22:21 - dok: Woohahahaha

having a unreadable code doesnt show skill, skill is a working plugin with a nice looking code with a nice performance. you match a couple of these requirements but not all xD
+ i already had a look on your beta and i just told you that the is crap since you shouldnt sue the fun antive anyway

[MPNumB]

Originally Posted by SchlumPF* 22:21 - dok: What we are looking for in plugins: * Make sure it's code is clean, concise, and readable. 22:21 - dok: Woohahahaha having a unreadable code doesnt show skill, skill is a working plugin with a nice looking code with a nice performance. you match a couple of these requirements but not all xD + i already had a look on your beta and i just told you that the is crap since you shouldnt sue the fun antive anyway

For some people it's readable, for some not. My experience shows that my best plugins are those what are unreadable for you and readabale for those who are getting in the code. =)

JbTrainer is readable for some people, for some not. LJStats is not readable for no1 (that's why I'm not submitting it). This plugin is more readale than JbTrainer.

But I'm not using FUN native if fakemeta is enabled... I just didn't understood what you are trying to say about FUN native. =P

[SchlumPF*]

what i am trying to say about the fun module is this:
imo fun sux and the module should be removed from amxx (hope its clear to you now xD)

btw i was able to read your ljstats after a couple of days xD anyway ljstats incldues a lot of calculations etc which automatically makes the code hard to read but a plugin like this should be readable :/

[MPNumB]

Originally Posted by SchlumPF* what i am trying to say about the fun module is this: imo fun sux and the module should be removed from amxx (hope its clear to you now xD) btw i was able to read your ljstats after a couple of days xD anyway ljstats incldues a lot of calculations etc which automatically makes the code hard to read but a plugin like this should be readable :/

Understood. =) In beta by standard FM is enabled instead of CStrike & Fun. But even if w/o the calculations - this plugin is much more readable than ljstats and imo it's more readable than JbTrainer so shouldn't be not accepted cuz of readability level. =)

[SchlumPF*]

i want your plugin to be approved, dont misunderstand me but i just think you should rather start writing readable plugins if you want to show your skilllevel as you said before