1.
The location of
fragmod.sma is immaterial to anything unless you're compiling it locally, and even then, it's not guaranteed that it'll be the user's scripting folder.
2.
While it's okay to request translations in the actual plugin thread, there's a
board specifically created to handle these things.
3.
Code:
g_switch = register_cvar("fragmod", "1")
sellfrags_max = register_cvar("fm_sellfrags_max", "5")
All your CVARs should start with the same prefix.
I would suggest changing
fragmod to something like
fm_enable so that it shares the same CVAR prefix as the rest of your CVARs.
4.
Code:
if(FragsSold==get_pcvar_num(sellfrags_max)) {
client_print(id, print_chat, "%L", "CANT_SELL_MORE", get_pcvar_num(sellfrags_max))
return PLUGIN_HANDLED
}
If you are calling a function more than once, you should store the value from the first function call and then use that value in the place of subsequent function calls. In the case of the function being pretty light like
get_pcvar_num(), the speed savings isn't great, but doing so is still good programming practice.
5.
Code:
g_switch = register_cvar("fragmod", "1")
sellfrags_max = register_cvar("fm_sellfrags_max", "5")
buyfrags_max = register_cvar("fm_buyfrags_max", "5")
g_fragearn = register_cvar("fm_sellfragcost", "4000")
g_fragcost = register_cvar("fm_buyfragcost", "6000")
This isn't critical for approval but it is still worthy of being pointed out. Good programming practice dictates that you should maintain some sort of consistency in the name of your variables. In this case, it would be enough to just change
sellfrags_max to
g_sellfrags_max and
buyfrags_max to
g_buyfrags_max.
__________________