[swapped]

Originally Posted by Sun Aloe You didn't get what I meant. I meant a cvar to define if you can only see teammates glowing or everyone. And... how can a spectator have glow if it's not supposed to be playing?

Whow the hell to do that ?

now im not check if is user spectator or other things i just use get_user_team( id ) , and is check also spectator, i think to post this ( This is not an option is default checking by get_user_team native )

[ezio_auditore]

I had a similar plugin called "Hp based glow"...

But that got unapproved.
Anyway, Good Job. lets hope for approval !

[swapped]

Originally Posted by ezio_auditore I had a similar plugin called "Hp based glow"... But that got unapproved. Anyway, Good Job. lets hope for approval !

I know, look at Credits.

Thanks

[ezio_auditore]

Originally Posted by swapped I know, look at Credits. Thanks

Oh sorry,
I didnt saw it..
Thanks by the way

[HamletEagle]

PHP Code:

RegisterCvars()
{
    bot_cvar         = register_cvar("gh_bot_show","1");
    red_health_cvar     = register_cvar("gh_red","25");
    green_health_cvar     = register_cvar("gh_green","100");
    yellow_health_cvar    = register_cvar("gh_yellow","70");
    team_cvar        = register_cvar("gh_team","4");
    admin_cvar        = register_cvar("gh_admins","0");
}

RegisterHamEvents()
{
    RegisterHam(Ham_Spawn, "player", "hk_spawn", 1)
    RegisterHam(Ham_Killed, "player", "hk_dead", 1)
}


public plugin_init()
{
    register_plugin(PLUGIN_NAME, VERSION, AUTHOR)

    register_event( "Health", "evHealth", "be" );

    RegisterCvars();
    RegisterHamEvents();
} 


Just write them as default. It is true that this doesn't affect plugin performance but makes it harder to read. If you saw this in another plugin, this doesn't mean that it is ok to add it to your code...

[ezio_auditore]

Originally Posted by HamletEagle PHP Code: RegisterCvars() {     bot_cvar         = register_cvar("gh_bot_show","1");     red_health_cvar     = register_cvar("gh_red","25");     green_health_cvar     = register_cvar("gh_green","100");     yellow_health_cvar    = register_cvar("gh_yellow","70");     team_cvar        = register_cvar("gh_team","4");     admin_cvar        = register_cvar("gh_admins","0"); }   RegisterHamEvents() {     RegisterHam(Ham_Spawn, "player", "hk_spawn", 1)     RegisterHam(Ham_Killed, "player", "hk_dead", 1) }     public plugin_init() {     register_plugin(PLUGIN_NAME, VERSION, AUTHOR)       register_event( "Health", "evHealth", "be" );       RegisterCvars();     RegisterHamEvents(); }  Just write them as default. It is true that this doesn't affect plugin performance but makes it harder to read. If you saw this in another plugin, this doesn't mean that it is ok to add it to your code...

perhaps you can indent them as in my Tarus plugin(See my signature)

[Spawner30]

GJ ^^'

[Buckshot]

Originally Posted by swapped will be aded in 1.1 I see a code exact like my code writed not in the same line in a Exolent plugin so dont comment if you dont have experience. About my "bad code" if this is true , please tell me where to update my source. thanks for some optimization , updated to v1.1 !

So I am the one who doesn't have any experience? Really.. Okay. I'm trying to help you and give you feedback. Don't be an asshole. Thank me instead.

Heres one example..

set_user_rendering(id,kRenderFxGlowShell,0,0,0

-->

set_user_rendering(id,kRenderFxNone,0,0,0

Code could be cleaned furthermore, but im just removing a few functions to show you some of it.. My point is that you should go through your code and clean it up from junk and fails before you post it as a new plugin submission

#include <amxmodx>
#include <amxmisc>
#include <hamsandwich>
#include <fun>

#define PLUGIN_NAME "Glow Health"
#define VERSION "1.1"
#define AUTHOR "swapped"

new bot_cvar;
new red_health_cvar;
new green_health_cvar;
new yellow_health_cvar;
new team_cvar;
new admin_cvar;
new health_client[33];

public plugin_init()
{
    register_plugin(PLUGIN_NAME, VERSION, AUTHOR)

    register_event( "Health", "evHealth", "be" );

    bot_cvar        = register_cvar("gh_bot_show","1");
    red_health_cvar     = register_cvar("gh_red","25");
    green_health_cvar   = register_cvar("gh_green","100");
    yellow_health_cvar  = register_cvar("gh_yellow","70");
    team_cvar       = register_cvar("gh_team","4");
    admin_cvar      = register_cvar("gh_admins","0");
    
    RegisterHam(Ham_Spawn, "player", "hk_spawn", 1)
    RegisterHam(Ham_Killed, "player", "hk_dead", 1)
}

public evHealth( id )
{
    health_client[id] = get_user_health( id );

    if(is_user_bot( id ) && !get_pcvar_num(bot_cvar))
        set_user_rendering(id,kRenderFxNone, 0,0,0,kRenderNormal,25)

    if(is_user_admin( id ) && get_pcvar_num(admin_cvar))
        set_user_rendering(id,kRenderFxNone, 0,0,0,kRenderNormal,25)

    if(!get_user_team( id ) == get_pcvar_num(team_cvar))
        set_user_rendering(id,kRenderFxNone, 0,0,0,kRenderNormal,25)

    if(health_client[id] < get_pcvar_num(red_health_cvar))
    {
        set_user_rendering(id,kRenderFxGlowShell, 255, 0, 0,kRenderNormal,25)

    }

    else if(health_client[id] < get_pcvar_num(yellow_health_cvar) && health_client[id] > get_pcvar_num(red_health_cvar))
    {
        set_user_rendering(id,kRenderFxGlowShell, 253, 253, 27,kRenderNormal, 25)
    }

    else if(health_client[id] > get_pcvar_num(yellow_health_cvar) && health_client[id] < get_pcvar_num(green_health_cvar))
    {
        set_user_rendering(id,kRenderFxGlowShell, 0, 255, 0,kRenderNormal,25)
    }

    else
    {
        set_user_rendering(id,kRenderFxGlowShell, 0 , 255 , 0,kRenderNormal,25)
    }
}


public hk_spawn( id )
{
    health_client[id] = get_user_health( id );

    if( is_user_alive( id ) )
    {
        set_user_rendering(id,kRenderFxGlowShell, 0, 255, 0,kRenderNormal,25)
    }
}

public client_putinserver(id)
{
    if( is_user_alive( id ) )
    {
        colorx( id, 0, 255, 0 );
    }
}

Also reading these might help some

Pawn Picture Tutorial
Good programming habits

[GuskiS]

It seems that you don't know shit about programing. Why do you even try?

[Buckshot]

Originally Posted by GuskiS It seems that you don't know shit about programing. Why do you even try?

Doon't go that hard on him.. everyone can learn.. But i agree he shouldnt post these plugins right now, until he learns some more..