[Agret]

Excuse the formatting, was asking in SourceMod IRC but got no reply (yet?)

17:16 Agret Hello
17:16 Agret i'm writing a plugin that reads a text file line by line
17:17 Agret it then uses BreakString to get the first part of the string as the comparison and if it matches the map name it will set the downloadurl to the index as defined by the return of BreakString
17:17 Agret the problem is if i use line[pos] to get the rest of the line
17:17 Agret it will get the newline
17:18 Agret and set my downloadurl to http://;blah/<newline>
17:18 Agret obviously this is a bit of an issue
17:18 Agret so i attempted to make it set the downloadurl, read it back then use the strip function to remove whitespace and then set that new string back as the downloadurl
17:18 Agret however it was giving me an issue about 'array not indexed' or something
17:19 Agret so i had to do fix[0] = trim(downloadurl)
17:19 Agret but then the first character is cut off
17:19 Agret so the download url becomes " ttp/blah"
17:19 Agret (replacing the h with a space)
17:19 Agret how can i strip the newline when setting the string?
17:20 Agret SetConVarString(g_hDownloadURL, line[pos])
17:21 Agret logically (to me) i tried SetConVarString(g_hDownloadURL, trim(line[pos]))
17:21 Agret but it doesnt work

[bl4nk]

PHP Code:

new len = strlen(line);
if (line[len-1] == '\n')
{
    line[len-1] = '\0';
} 


[Agret]

I added your fix but it doesn't compile now,

//// downloadurl.sp // downloadurl.sp(102) : error 022: must be lvalue (non-constant) // downloadurl.sp(102) : warning 215: expression has no effect // // 1 Error. // // Compilation Time: 0.2 sec // ----------------------------------------

Your fix seems logically sound to me, I must be passing the variable to it wrong though.
This is the first SourceMod script i've written (previously written amxmodx scripts, about a year ago) and i'm still not used to the different variable types.

[bl4nk]

You defined "line" as a constant string, meaning you can't change the value of it, and that's exactly what you're trying to do there.

[Agret]

Ohhh, I see what I did wrong. Thank you bl4nk. Plugin is working great now

Although my plugin works properly now I have to ask, does anyone see any improvements I could make in the way the plugin is coded.
I'm interested in advancing my knowledge of how you should code and whatever improvements can be made to it.