Raised This Month: $ Target: $400
 0% 

Release Legacy SourceBans 1.4.11 (Updated 2014/02/17)


Post New Thread Closed Thread   
 
Thread Tools Display Modes
sirmoe
Senior Member
Join Date: Mar 2008
Old 07-21-2008 , 07:41   Re: SourceBans (1.2.0) (UPDATE)
#711

Question, why dont I have a page 2 button on my admins page?
sirmoe is offline
DJ Tsunami
DJ Post Spammer
Join Date: Feb 2008
Location: The Netherlands
Old 07-21-2008 , 08:45   Re: SourceBans (1.2.0) (UPDATE)
#712

Quote:
Originally Posted by Gweedo View Post
[IMG]http://img398.**************/img398/1858/problemwithpaginationnk4.th.jpg[/IMG]

I'm seeing a problem with the admin page pagination. In my screen shot it says showing 50 - 75 of 86 results and it's on page 3 of 3. If I hit next the drop down will show as page 1 but it will show the last of the list.
Quote:
Originally Posted by DJ Tsunami View Post
Yeah, seems the last page is left out of the drop down box on the admin list page. Weird that this isn't the case on the ban list page.
Anyway, this was fixed in the SVN release I just committed, along with some other bugs. Attached are the changed files.

Edit: there was a serious bug in the game plugin in r99, r100 is attached on page 74.
__________________
Advertisements | REST in Pawn - HTTP client for JSON REST APIs
Please do not PM me with questions. Post in the plugin thread.

Last edited by DJ Tsunami; 07-22-2008 at 08:46.
DJ Tsunami is offline
Kigen
BANNED
Join Date: Feb 2008
Old 07-21-2008 , 09:49   Re: SourceBans (1.2.0) (UPDATE)
#713

There also appears to be errors in SourceBans' GetCommunityID() function in dealing with long Steam IDs. Example: STEAM_0:0:19900xxx
Kigen is offline
Order66
Member
Join Date: May 2008
Old 07-21-2008 , 10:08   Re: SourceBans (1.2.0) (UPDATE)
#714

is the server group permission still broken?

I just tried applying server group permissions then went to 'edit permissions' and nothing is ticked off for the server (the web admin works fine though)

I haven't tested if admin works or not after applying permission.
Order66 is offline
Gweedo
Member
Join Date: Aug 2007
Old 07-21-2008 , 13:29   Re: SourceBans (1.2.0) (UPDATE)
#715

Quote:
Originally Posted by DJ Tsunami View Post
I would like to ask you guys, and anyone else doing a fresh install or an upgrade, to empty the themes_c folder after uploading the new files. Unfortunately the zip for 1.2.0 contains a bunch of files in there that shouldn't be there, and it will probably fix some problems that you guys are having.
Quote:
Originally Posted by DJ Tsunami View Post
Anyway, this was fixed in the SVN release I just committed, along with some other bugs. Attached are the changed files.
These fixes solved their respective issues. Thanks!
Gweedo is offline
Xtrm2Matt
Member
Join Date: Nov 2004
Location: England, UK
Old 07-21-2008 , 14:41   Re: SourceBans (1.2.0) (UPDATE)
#716

Got a small bug for you (forgot to report it some months ago).

I created a (staff) group called 'Master', full permissions. For some reason, the server downloads the group as 'master' (note the capitalized/uncapitalised M) and as such the access doesn't work:

Quote:
L 07/21/2008 - 192:49: [admin-flatfile.smx] Error(s) detected parsing addons\sourcemod\configs\admins.cfg
L 07/21/2008 - 192:49: [admin-flatfile.smx] (line 7) Unknown group "Master"
L 07/21/2008 - 194:40: [admin-flatfile.smx] Error(s) detected parsing addons\sourcemod\configs\admins.cfg
L 07/21/2008 - 194:40: [admin-flatfile.smx] (line 7) Unknown group "Master"
The way I fixed this was renaming 'Master' to 'master' on the web panel.
Xtrm2Matt is offline
Kigen
BANNED
Join Date: Feb 2008
Old 07-21-2008 , 18:31   Re: SourceBans (1.2.0) (UPDATE)
#717

Quote:
Originally Posted by DJ Tsunami View Post
Anyway, this was fixed in the SVN release I just committed, along with some other bugs. Attached are the changed files.
admin.admins.search.php
Line 50:
Code:
$srvadmgroup_list = $GLOBALS['db']->Execute("SELECT name FROM ". DB_PREFIX ."_srvgroups" ORDER BY name ASC);
Replace with:
Code:
$srvadmgroup_list = $GLOBALS['db']->Execute("SELECT name FROM ". DB_PREFIX ."_srvgroups ORDER BY name ASC");
Kigen is offline
Kigen
BANNED
Join Date: Feb 2008
Old 07-21-2008 , 18:47   Re: SourceBans (1.2.0) (UPDATE)
#718

Also, there is an inaccuracy in the Friend ID calculation in the present (1.2.0) SourceBans version.

Here is the fix (taken from Seather's Steam ID convert script):

Open includes/system-functions.php.

On line 763 find the function:
Code:
function getCommunityID($pszAuthID)
{
	$steamParts = explode(":", $pszAuthID);
	$comId = (int)$steamParts[2] * 2;
	$comId += 60265728 + (int)$steamParts[1];
	return "765611979" . $comId;
}
And replace with:
Code:
function getCommunityID($szAuthID)
{
	$iServer = "0";
	$iAuthID = "0";
	$szTmp = strtok($szAuthID, ":");
	while(($szTmp = strtok(":")) !== false)
	{
		$szTmp2 = strtok(":");
		if($szTmp2 !== false)
		{
			$iServer = $szTmp;
			$iAuthID = $szTmp2;
		}
	}
	if($iAuthID == "0")
		return "0";

	$i64friendID = bcmul($iAuthID, "2");
	$i64friendID = bcadd($i64friendID, bcadd("76561197960265728", $iServer)); 
	return $i64friendID;
}
Kigen is offline
DJ Tsunami
DJ Post Spammer
Join Date: Feb 2008
Location: The Netherlands
Old 07-21-2008 , 19:55   Re: SourceBans (1.2.0) (UPDATE)
#719

That requires an extension that not all PHP installations have, that's why we're using this method.
__________________
Advertisements | REST in Pawn - HTTP client for JSON REST APIs
Please do not PM me with questions. Post in the plugin thread.
DJ Tsunami is offline
Kigen
BANNED
Join Date: Feb 2008
Old 07-21-2008 , 20:00   Re: SourceBans (1.2.0) (UPDATE)
#720

Quote:
Originally Posted by DJ Tsunami View Post
That requires an extension that not all PHP installations have, that's why we're using this method.
Hrm, well, just let it be known that the current method has inaccuracies with larger Steam IDs.
Kigen is offline
Closed Thread



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:53.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode