[mordi]

When checking for a pcvar or a cvar in the start of a function, should i use:

public function() 
{
    if(get_pcvar_num(pcvar))
    {
        something
    }
}

or...

public fuction()
{
    if(!get_pcvar_num(pcvar))
        return PLUGIN_HANDLED
        
    something
    
}

What is the most efficient way?

[Lee]

I agree with Will Shipley.

Originally Posted by http://wilshipley.com/blog/2005_07_01_archive.html What you should really do is write "if" statements that check for improper conditions, and if you find them, bail. This cleans your code immensely, in two important ways: (a) the main, normal execution path is all at the top level, so if the programmer is just trying to get a feel for the routine, all she needs to read is the top level statements, instead of trying to trace through indention levels figuring out what the "normal" case is, and (b) it puts the "bail" code right next to the correctness check, which is good because the "bail" code is usually very short and belongs with the correctness check.

The performance difference will be negligible to say the least. It might be worth noting that you only need to return a value if it's actually going to be used.

Most importantly, ignore vl@d.

[mordi]

Thanks Lee!
I'll use this then:

public fuction()
{
    if(!get_pcvar_num(pcvar))
        return PLUGIN_HANDLED
        
    something
    
}