[Solved] sql save data at disconnect

lexzor · **Author**

hello. i have this code

PHP Code:


			
#if AMXX_VERSION_NUM < 183

    public client_disconnect(id)

#else 

    public client_disconnected(id)

#endif

{

    if(g_PlayerData[id][ISBOT] == 1 )

        return PLUGIN_HANDLED;



    switch(id)

    {

        case 1..10: set_task(0.1, "save_data", id + SendDataTask);

        case 11..22: set_task(0.1, "save_data", id + SendDataTask);   

        case 23..32: set_task(0.3, "save_data", id + SendDataTask);

    }





    return PLUGIN_CONTINUE;

}



public save_data(id)

{

    id -= SendDataTask;



    new szQuery[512];



    g_PlayerData[id][LASTVISIT] = get_systime();



    formatex(szQuery, charsmax(szQuery), "UPDATE `%s` SET `last_visit` = '%i' , `daily_bonus_time` = '%i' , `points` = '%i'  WHERE `steamid` = '%s'",

    g_szTable, g_PlayerData[id][LASTVISIT], g_PlayerData[id][DAILYBONUS], g_PlayerData[id][CASH], g_PlayerData[id][STEAMID]);



    SQL_ThreadQuery(g_SqlTuple, "FreeHandle", szQuery);





}

the problem is that when map is changing the data are not saved only when player disconnect.

If i don t use set_task i get this error after map change

Code:

[MySQL] Thread worker was unable to start.

i think the plugin free handle the sql tuple and can t send the query.

what are your solutions?

Dragos · *Last edited by Dragos; 08-05-2021 at 15:02.*

Try using my method.

Not good to use, but try

PHP Code:


			
public client_disconnect(id) {
    if(!(is_user_bot(id)||is_user_hltv(id)))    Save_MySql(id)
}

public Save_MySql(id)
{
    new szTemp[512]
    format(szTemp,charsmax(szTemp),"UPDATE `%s` SET `kills` = '%d', `deaths` = '%d', `points` = '%d' WHERE `steamid` = '%s';",TABEL, szKills[id], szDeaths[id], Points[id], szSteamId[id])
    SQL_ThreadQuery(g_SqlTuple,"IgnoreHandle",szTemp)
}

Change with your data.

**Bugsy** · 08-05-2021 , 16:09 Re: sql save data at disconnect

Have you tried printing out the query in a server_print() or log to make sure it's formatted correctly?
Are you getting a positive result in your FreeHandle callback?

**Bugsy** · 08-06-2021 , 00:01 Re: sql save data at disconnect

And what is this all about with the difference in intervals based on the id (1-10 and 11-22 can be grouped btw). And why use set_task() at all, just call save_data() directly.

PHP Code:


			
    switch(id)
    {
        case 1..10: set_task(0.1, "save_data", id + SendDataTask);
        case 11..22: set_task(0.1, "save_data", id + SendDataTask);   
        case 23..32: set_task(0.3, "save_data", id + SendDataTask);
    }

Natsheh · 08-06-2021 , 00:12 Re: sql save data at disconnect

Show how are you loading the data from the top to the bottom.

deprale · *Last edited by deprale; 08-08-2021 at 20:18.*

PHP Code:


			
#if AMXX_VERSION_NUM < 183
    public client_disconnect(id)
#else 
    public client_disconnected(id)
#endif
#include <fakemeta> 
public plugin_init(){
register_forward( FM_ChangeLevel, "fwd_FM_ChangeLevel");  // HOOK changelevel forward NOTE: you WILL need to include fakemeta.
}
{
    if(g_PlayerData[id][ISBOT] == 1 )
        return PLUGIN_HANDLED;

    switch(id)
    {
        case 1..10: set_task(0.1, "save_data", id + SendDataTask);
        case 11..22: set_task(0.1, "save_data", id + SendDataTask);   
        case 23..32: set_task(0.3, "save_data", id + SendDataTask);
    }


    return PLUGIN_CONTINUE;
}

public save_data(id)
{
    id -= SendDataTask;

    new szQuery[512];

    g_PlayerData[id][LASTVISIT] = get_systime();

    formatex(szQuery, charsmax(szQuery), "UPDATE `%s` SET `last_visit` = '%i' , `daily_bonus_time` = '%i' , `points` = '%i'  WHERE `steamid` = '%s'",
    g_szTable, g_PlayerData[id][LASTVISIT], g_PlayerData[id][DAILYBONUS], g_PlayerData[id][CASH], g_PlayerData[id][STEAMID]);

    SQL_ThreadQuery(g_SqlTuple, "FreeHandle", szQuery);


} 

SaveStuff(){
new iPlayers[32], iPNum, iPlayer;
get_players(iPlayers, iPNum, "hc") // get all players beside HLTV proxies and bots
for (new i = 0; i<<iPNum, i++){
iPlayer = iPlayers[i]
    switch(i)
    {
        case 1..10: set_task(0.1, "save_data", id + SendDataTask);
        case 11..22: set_task(0.1, "save_data", id + SendDataTask);   
        case 23..32: set_task(0.3, "save_data", id + SendDataTask);
    }
}
return PLUGIN_HANDLED;
}

public fwd_FM_ChangeLevel( map[] ) { //HOOK CHANGELEVEL
SaveStuff(); // loop players save data function
return PLUGIN_CONTINUE;
}

public plugin_end(){ // HOOK PLUGIN END
SaveStuff();
return PLUGIN_CONTINUE;
}

plugin_end() should be called when the "server stops", not sure if its called at map change, but just in case you shut off the server or it crashes I think it's worth saving then as well, if not just delete the whole function.
forward changelevel hook => NOT RELIABLE if you change map from other plugins, example you use changelevel from x.amxx it won't always register, in b.amxx not sure why that is, maybe it's related to plugin order in amxx.cfg or some other "too advanced stuff" for me. Pardon my ignorance.

I believe others know better, so don't take my post for granted, but would be sweet if you tried it

EDIT: can somebody also clarify for me whether set_task is a good idea to call on a changelevel hook? wouldn't that task try to execute when already the map is changing ? Or does it respect set_task's delays and THEN changes map?

2nd EDIT (SORRY AHAHAH):

Quote:

Originally Posted by Bugsy

And what is this all about with the difference in intervals based on the id (1-10 and 11-22 can be grouped btw). And why use set_task() at all, just call save_data() directly.

PHP Code:


			
    switch(id)
    {
        case 1..10: set_task(0.1, "save_data", id + SendDataTask);
        case 11..22: set_task(0.1, "save_data", id + SendDataTask);   
        case 23..32: set_task(0.3, "save_data", id + SendDataTask);
    }

exactly, why doesn't he just pass arguments to save_data? why delay it? if player has disconnected then save for id only, if map changed then pass no arguments, if arguments empty then loop through all players and save.
I suppose I could see why he would want to delay certain ids from saving, maybe he starts saving the data AS SOON as something happens, but is STILL happening, and the latter ids dont YET have the data to be saved, so he's trying to SAVE before actually WRITING the data that's "ACTUAL", a.k.a the one that's true. But hey, I guess it's worth waiting for his answer instead than trying to think about it.

But then he can just delay the changelevel forward with a boolean and another task, "I suppose" (not actually sure its possible, never tried it).

lexzor · *Last edited by lexzor; 08-08-2021 at 21:11.*

actually this is working:

PHP Code:


			

#if AMXX_VERSION_NUM < 183
    public client_disconnect(id)
#else 
    public client_disconnected(id)
#endif
{
    if(g_PlayerData[id][ISBOT] == 1 )
        return PLUGIN_HANDLED;

    save_data(id);

    return PLUGIN_CONTINUE;
}

public save_data(id)
{
    new ErrorCode,Handle:SqlConnection = SQL_Connect(g_SqlTuple,ErrorCode,g_Error,charsmax(g_Error));

    if(SqlConnection == Empty_Handle)
        set_fail_state(g_Error);
    
    new Handle:Queries;
    new szQuery[1024];

    g_PlayerData[id][LASTVISIT] = get_systime();
    formatex(szQuery, charsmax(szQuery), "UPDATE `%s` SET `last_visit` = '%i' , `points` = '%i'  WHERE `steamid` = '%s'",
        g_szTable, g_PlayerData[id][LASTVISIT], g_PlayerData[id][CASH], g_PlayerData[id][STEAMID]);
    
    Queries = SQL_PrepareQuery(SqlConnection, szQuery);

    if(!SQL_Execute(Queries))
    {
        SQL_QueryError(Queries,g_Error,charsmax(g_Error));
        set_fail_state(g_Error);
    }        
    
    SQL_FreeHandle(Queries);
    SQL_FreeHandle(SqlConnection);
}

and this is how i get data

PHP Code:


			
public client_authorized(id)
{
    if(is_user_bot(id) || is_user_hltv(id))
    {
        g_PlayerData[id][ISBOT] = 1;

        return PLUGIN_HANDLED;
    }

    get_user_authid(id, g_PlayerData[id][STEAMID], charsmax(g_PlayerData[][STEAMID]));
    get_user_name(id, g_PlayerData[id][NAME], charsmax(g_PlayerData[][NAME]));
    get_user_ip(id, g_PlayerData[id][IP], charsmax(g_PlayerData[][IP]), 1);

    g_PlayerData[id][DONATE] = 0;
    g_PlayerData[id][ID] = 0;
    g_PlayerData[id][ISBOT] = 0;

    switch(id)
    {
        case 1..10: set_task(0.1, "get_data", id + GetDataTask);
        case 11..22: set_task(0.2, "get_data", id + GetDataTask);   
        case 23..32: set_task(0.3, "get_data", id + GetDataTask);
    }

    set_task(float(HELLO_TIME), "hello_user", id + HelloTask);

    return PLUGIN_CONTINUE;
}

I don't know why but i get a lot of errors if i don't use set_task.

In the above code i just make a mistake, that's why i put the same value for 2 cases of switch statement.

In first provided code i made a mistake (i was trying to evoid an error that occurs when there are to many queries sending to dtb):
- using set task to save it and at changelevel the data wasn't saved

Maybe if i would used SQL_ThreadQuery to send data like

PHP Code:


			
new szData[3];
szData[0] = id
szData[1] = kills; //or whatever

//etc...

SQL_ThreadQuery(g_SqlTuple, "FreeHandle", szQuery, szData, 2)

maybe it would worked but i think the above code is more practical

**Bugsy** · 08-08-2021 , 20:47 Re: sql save data at disconnect

Yeah, you should never run into an issue with threaded since they should be queued and processed when the system can process. Like I said, I would use execute only at plugin_cfg() or plugin_end() since there, it will never impact gameplay. All mid-game stuff, use threaded.

lexzor · 08-08-2021 , 21:13 Re: sql save data at disconnect

Actually i can't use threaded in client_disconnected because i get a lot of errors for every player but i think it s ok rn because it s working with no errors when the server is full.

Thanks you all.

**Bugsy** · 08-08-2021 , 21:48 Re: sql save data at disconnect

Show your disconnect code