[Halt]

So my mod selects a random player on the start of a match to be the first zombie

PHP Code:

GetRandomPlayer()
{
    new players[MaxClients + 1];
    new ClientCount;
    for    (new i = 1; i <= MaxClients; i++)
        if(IsClientInGame(i))
            if    (PlayerTeam[i] == TFTeam_Blue && PlayerClass[i] >= 1 && !bWasFirstZombie[i])
            {
                players[ClientCount++] = i;
                bWasFirstZombie[i] = true;
            }
    return (ClientCount == 0) ? -1 : players[GetRandomInt(0, ClientCount - 1)];
} 


Now I set bWasFirstZombie to true for that client so the next round they wont be selected again. But where would I set it to false. It would have to be after this is fired the next round.

[headline]

Instead of a Boolean for WasFirstZombie per client, try having a single "first zombie" integer which just holds the client index. So all you have to check is that client != wasFirstZombie

Also if the inside of your if statements is more than one line, you should really be using braces for each exterior branch. In your case, the for loop and the IsClientInGame check should have brackets

[Halt]

Like so?

PHP Code:

new WasFirstZombie = 0; //<----- Declared an int globally

GetRandomPlayer()
{
    new players[MaxClients + 1];
    new ClientCount;
    for    (new i = 1; i <= MaxClients; i++)
    {
        if(IsClientInGame(i))
            if    (PlayerTeam[i] == TFTeam_Blue && PlayerClass[i] >= 1 && != WasFirstZombie[i])
            {
                players[ClientCount++] = i;
                WasFirstZombie == i; //<---------- Did I set this correctly?
            }
    }
    return (ClientCount == 0) ? -1 : players[GetRandomInt(0, ClientCount - 1)];
} 


I also added the braces after the for loop. Is this what you were getting at?

[hmmmmm]

== operator checks if the two things are equal and returns true or false
e.g. x == 5 checks if x is 5

= operator assigns value on right hand side to variable on left hand side
e.g. x = 5 makes x hold value 5

not sure what you're going for in your code but WasFirstZombie == i probably wont do what you want it to.
Also you should keep style consistent. You've got tab in front of second if (ew) but no tab in front of first

[Halt]

Minus the tab mistake which was a mistake, I'm not sure how to apply what hmmmmm is explaining to me. Could I see an example. It doesn't have to be applied to mine. Preferably not I'd learn better.

[fiction]

Originally Posted by Halt Minus the tab mistake which was a mistake, I'm not sure how to apply what hmmmmm is explaining to me. Could I see an example. It doesn't have to be applied to mine. Preferably not I'd learn better.

You should post some more code around WasFirstZombie and explain what GetRandomPlayer is being used for.

[Neuro Toxin]

int g_FirstZombie = 0;

stock int GetFirstZombie()
{
   int players[MAXPLAYERS+1];
   int maxplayers = 0;

   for (int client = 1; client <= MaxClients; client++)
   {
      if (!IsClientInGame(client))
         continue;

      if (PlayerTeam[client] != TFTeam_Blue)
         continue;

      if (PlayerClass[client] < 1)
         continue;

      if (client == g_FirstZombie)
         continue;

      players[maxplayers++] = client;
   }

   if (maxplayers == 0)
      g_FirstZombie = -1;
   else
      g_FirstZombie = players[GetRandomInt(0, maxplayers - 1)];

   return g_FirstZombie;
}

Not tested. It should compile.

Couple of points.

1. Use the new syntax all the time
2. Name things based on what they do as it makes code more readable.
3. Use the same naming conventions. We normally lowercase all local variables within function scope and camel case everything that is global
4. Avoid loops with i, try to name i as to what it holds
5. Try to avoid heavily nested if statements

The result is a few more lines. But so much more readable.

Coding should always be a balance of readability and not focused completely on less lines.

[hmmmmm]

PHP Code:

int x;
for( int i = 0; i < 5; i++ )
{
    if( i != 0 )
    {
        x == i; // incorrect, this will check if x is equal to i, and return true or false, instead of making x = i
        x = i; // this is what you're probably trying to do, assigning value of i to x
    }
} 


int players[MaxClients+1];

Won't compile since thats not a fixed size, should be:

PHP Code:

int[] players = new int[MaxClients+1]; 


[fiction]

Originally Posted by hmmmmm Won't compile since thats not a fixed size, should be:

It shouldn't be MaxClients+1 though, just MaxClients https://github.com/alliedmodders/sou....inc#L186-L198

[Halt]

Okay so a few questions on Toxins post

PHP Code:

int bFirstZombie = 0; //Couldnt this be new bFirstZombie?

stock int GetRandomPlayer()
{
    int Players[MAXPLAYERS]; //Dont understand purpose
    int MAXPLAYERS = 0; //Dont understand purpose also compiler threw an error here says it expected an identifier but found integer.
    
    for    (int Client = 1; Client <= MaxClients; Client++) //Creates loop and what ends it
    {
        if(IsClientInGame(Client)) //Check for valid client
            continue;
        
        if    (PlayerTeam[Client] != TFTeam_Blue) //Check for client on BLU team
            continue;
        
        if    (Client == bFirstZombie) //Check for is the player was first zombie? A little confused
            continue;
        
    }
    
    if    (MAXPLAYERS == 0) //Threw and error on compile (Redundant code constant expression is zero)
        bFirstZombie = -1;
    else
        bFirstZombie = Players[GetRandomInt(0, MAXPLAYERS - 1)];
    return bFirstZombie;
} 


Questions are in the block above. The compiler threw a few errors.

Secondly whats the point of MaxClients/MaxPlayers?


As for hmmmm's post so we are setting i to 0 then each time the loop runs 1 is added to i. Once I equals 5 the loop stops?

Also at what point is this Toxins code checking for the client index stored in bFirstZombie and selecting a different client if they were the first zombie last round?