[snezzsp]

I would like to add a button on a new style menu, that stay in all pages of the menu, the menu is of the players of the servers, and if there are 2 pages and I pass the page, the button would stay there with a custom function. Like the ban menu from the amxmodmenu, but custom function. Sorry for my bad English

PHP Code:

#include <amxmodx>
#include <amxmisc>

#define PLUGIN "New Plug-In"
#define VERSION "1.0"
#define AUTHOR "author"

new g_maxplayers;
new i;
new name[33];


public plugin_init() {
    register_plugin(PLUGIN, VERSION, AUTHOR)
    register_clcmd("say /menu", "players");
    g_maxplayers = get_maxplayers();
}

public players(id)
{
    new menu = menu_create("PLAYERS :", "hd_menu");
    for(i=1; i <= g_maxplayers; i++)
    {
        if(is_user_connected(i)){
            get_user_name(i, name[i], 31);
            new message[100];
            format(message, charsmax(mensaje), "%s", name[i]);
            menu_additem(menu, mensaje);
        }
    }
    menu_setprop(menu, MPROP_EXIT, MEXIT_NEVER);
    menu_display(id, menu, 0)
}

public hd_menu(id, menu, item)
{
    if(item == MENU_EXIT){
        menu_destroy(menu);
        return PLUGIN_HANDLED;
    }
    new iData[6];
    new iAccess;
    new iCallback;
    new iName[64];
    menu_item_getinfo(menu, item, iAccess, iData, 5, iName, 63, iCallback);
    client_print(id,print_chat,"You have selected %s",iName);
    return PLUGIN_CONTINUE
} 


[EFFx]

First of all, use get_players() instead of a loop. If you want to learn more about it: https://forums.alliedmods.net/showthread.php?t=208331

Secondly, what is this?

PHP Code:

get_user_name(i, name[i], 31) 


The name[ i ] never should be like this, just the string name is needed, and use charsmax() instead of the array's size -1 ( the charsmax already does it ).

Here's the code:

PHP Code:

#include <amxmodx> 
#include <amxmisc> 

#define PLUGIN "New Plug-In" 
#define VERSION "1.0" 
#define AUTHOR "author" 

public plugin_init() 
{ 
    register_plugin(PLUGIN, VERSION, AUTHOR) 
    
    register_clcmd("say /menu", "players") 
} 

public players(id) 
{ 
    new menu = menu_create("Players list:", "hd_menu") 
    
    new Players[32],iPlayersNum,PlayerID, PlayersName[32],FormatMsg[100]
    get_players(Players,iPlayersNum,"ch")
    for(new i; i <= iPlayersNum; i++) 
    { 
        PlayerID = Players[i]
        get_user_name(PlayerID, PlayersName, charsmax(PlayersName))  
        format(FormatMsg, charsmax(FormatMsg), "%s", name) 
        menu_additem(menu, FormatMsg) 
    } 
    menu_display(id, menu, 0) 
} 

public hd_menu(id, menu, item) 
{ 
    if(item == MENU_EXIT)
    { 
        menu_destroy(menu) 
        return PLUGIN_HANDLED 
    } 
    new iData[6], iAccess, iCallback, iName[64] 
    menu_item_getinfo(menu, item, iAccess, iData, 5, iName, 63, iCallback) 

    new userid = str_to_num( szData );
    new player = find_player( "k", userid )

    new PlayerSelectedName[32]
    get_user_name(player,PlayerSelectedName,charsmax(PlayerSelectedName))
    
    client_print(id,print_chat,"You have selected %s",PlayerSelectedName) 
    return PLUGIN_CONTINUE 
} 


Just a small help about how to make a menu - https://forums.alliedmods.net/showthread.php?t=46364

[pupdebox]

Originally Posted by EFFx First of all, use get_players() instead of a loop. If you want to learn more about it: https://forums.alliedmods.net/showthread.php?t=208331

WHY? I'm of the opinion that using 1 loop is better instead of using double loop(get_players + loop for menu_additem)

[EFFx]

Did you read all the replies ?

https://forums.alliedmods.net/showpo...10&postcount=3

There's no problem using two loops, the problem is what the loop does.
The loop for all players call is_user_connected() 32 times, if have 5 players on the server, he still calling 32 times. With the get_players, will only 5. So, its better for the server.

[pupdebox]

If you have full server it will loop 32 times + using get_players will create a loop. You are right if the server is close to empty. I don't think using 32 loop is a bad habit. Using 32 loop wouldn't effect the server that much in addition, it's easy to filter specific players with that loop.

[EFFx]

Yes, the damage will not be much. I'm talking what I learn, what scripters better than me said. If you want to post your plugin here, they will told you to use get_players instead of a loop.

[fysiks]

The ban menu is created using the original menu method which is much much more flexible than the "new" menu method but the code is more complicated and is harder to understand (especially for newbies).

To do it with the new menu system, you would need to add a menu item after every 6 players (this assumes that pagination is set to 7). This menu item's data would differentiate it from the players. So, in your handler, you first check to see if the item's data is this special item (after checking for exit). If yes, do what you want otherwise you can assume that a player was chosen and run the original player-based code.

[Black Rose]

Originally Posted by pupdebox WHY? I'm of the opinion that using 1 loop is better instead of using double loop(get_players + loop for menu_additem)

It's more efficient. Simple as that.
One could also argue the readability is better instead of nested if statements.
You could just as well filter players in the second loop, most likely with more efficiency.

https://forums.alliedmods.net/showpo...9&postcount=12

[HamletEagle]

Originally Posted by pupdebox WHY? I'm of the opinion that using 1 loop is better instead of using double loop(get_players + loop for menu_additem)

Fun fact: It looks like that from time to time someone that hates get_players must appear and he won't ever accept that in most of cases it's better than looping manually each possible player slot.