[DJ Data]

Hey,

Is there a way to unhook !help and !motd and replace them by my hooks/functions?

[Miu]

registering it again should work

assuming they're called in the order they're registered in, you might need to delay it if the command doesn't already exist

[DJ Data]

Even if i reload the plugin, it seems like gameme's help, sourcemod's help and my own help command seem to fire at the same time.

[Miu]

Returning Plugin_Stop should do it

e: Seems like ithas a FIFO order actually which is awkward

[psychonic]

Originally Posted by Miu e: Seems like ithas a FIFO order actually which is awkward

The order is officially undefined and is an implementation detail. It can change at any time; don't rely on it.

If you don't want certain commands to be present, don't run the plugins providing those commands (or remove them from that plugin).

[Powerlord]

Originally Posted by psychonic The order is officially undefined and is an implementation detail. It can change at any time; don't rely on it. If you don't want certain commands to be present, don't run the plugins providing those commands (or remove them from that plugin).

It may be that people don't like editing core plugins. As I recall, motd is part of basetriggers.

[psychonic]

Originally Posted by Powerlord It may be that people don't like editing core plugins. As I recall, motd is part of basetriggers.

Indeed, but that doesn't change the answer.

[Powerlord]

Originally Posted by psychonic Indeed, but that doesn't change the answer.

No, but the fact that CommandListeners are processed before ConCmds are does.

For everyone else, I should explain that. If you know a command is a registered using RegConCmd, you can AddCommandListener on the same command and return Plugin_Handled or Plugin_Stop in the CommandListener to prevent the original plugin from ever receiving it.

[psychonic]

Originally Posted by Powerlord No, but the fact that CommandListeners are processed before ConCmds are does. For everyone else, I should explain that. If you know a command is a registered using RegConCmd, you can AddCommandListener on the same command and return Plugin_Handled or Plugin_Stop in the CommandListener to prevent the original plugin from ever receiving it.

At which point you end up running two plugins just to achieve a net result of... nothing.

Not to mention having troubleshooting issues when you forgot or don't realize that you have one plugin trying to block another plugin.

[Powerlord]

Originally Posted by psychonic At which point you end up running two plugins just to achieve a net result of... nothing. Not to mention having troubleshooting issues when you forgot or don't realize that you have one plugin trying to block another plugin.

There are reasons to do it. NativeVotes BaseCommands uses Command Listeners to override sm_cancelvote and sm_revote and handle them differently if NativeVotes has a vote running.

If NativeVotes doesn't have a vote running, then it allows a fallthrough to BaseCommands which will ultimately handle the cancel/revote/rejection of the command.

(Note: Because sm_cancelvote is an admin command, NativeVotes BaseCommands also does a CheckCommandAccess call)