[ImACow]

I'm hooking player_death (pre)
I have this code on. I'm still getting negative values somehow. what I'm I missing ?

The point of the code is to prevent suicides by "kill" or "world" to show negative values on the scoreboard

PHP Code:

public Action:event_PlayerDeathPre(Handle:event,const String:name[], bool:dontBroadcast){

  new var_userid = GetEventInt(event, "userid"); //get userid from event this one died
  new client = GetClientOfUserId(var_userid); //get client index this one died
  new var_attacker = GetEventInt(event, "attacker"); //get userid who killed
    new client_attacker = GetClientOfUserId(var_attacker); //get client index

    if(IsValidClient(client)){
      
        if(client == client_attacker || client_attacker == 0){ //world or himself
            //PrintToChatAll("suicide");
            new kills = GetEntProp(client, Prop_Data, "m_iFrags");
            kills = kills +1;
            SetEntProp(client, Prop_Data, "m_iFrags",kills);
        }
    }

  return Plugin_Continue; 
} 


PHP Code:

public IsValidClient(client)
{
    if(client == 0)
        return false;

    if(!IsClientInGame(client))
        return false;
   
    if(IsFakeClient(client))
        return false;

    return true;
} 


[Mathias.]

IsValidClient, supose it check if your not 0 which mean if you die by world it won't trigger your code

[Neuro Toxin]

To confirm. The problem is the scoreboard shows negative kills or the actual score is negative?

[Mathias.]

he don't want have his player suffering from losing a kill when they die from themself or by the world, which make sense, I mean why the fuck would it remove you a kill? points okay maybe but kills are kills.

[ImACow]

Originally Posted by Black-Rabbit IsValidClient, supose it check if your not 0 which mean if you die by world it won't trigger your code

PHP Code:

public IsValidClient(client)
{
    if(client == 0)
        return false;

    if(!IsClientInGame(client))
        return false;
   
    if(IsFakeClient(client))
        return false;

    return true;
} 


[ImACow]

Originally Posted by Black-Rabbit he don't want have his player suffering from losing a kill when they die from themself or by the world, which make sense, I mean why the fuck would it remove you a kill? points okay maybe but kills are kills.

Exactly, its annoying seeing players at -30 kills when they killed 15 players past 8 rounds

[Mathias.]

I don't, I got similar code, I'm setting the kills the same way, it should work as it is. Killing a teamate also give a negative value, just not sure if you use friendly fire, the only thing I can see that can g ive you negative values.

[ImACow]

ff is disabled, I'm just confused why its still going negative.

[Mathias.]

when it goes negative? are you sure when play sucide? give more information at when it happen.

[ici]

PHP Code:

#pragma semicolon 1

#include <sourcemod>

public OnPluginStart()
{
    HookEvent("player_death", Event_PlayerDeath);
}

public Event_PlayerDeath(Handle:event, const String:name[], bool:dontBroadcast)
{
    new victim = GetClientOfUserId(GetEventInt(event, "userid"));
    new attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    
    if ((1 <= victim <= MaxClients) && IsClientInGame(victim)) {
        if ((victim == attacker) || attacker == 0) {
            SetEntProp(victim, Prop_Data, "m_iFrags", GetClientFrags(victim) + 1);
        }
    }
}