[lingzhidiyu]

same code?

PHP Code:

stock bool:IsClientTeamT(client)
{
    if(client > 0 && client <= MaxClients)
        if(GetClientTeam(client) == CS_TEAM_T)
            return (true);

    return (false);
}

stock bool:IsClientTeamT(client)
{
    if(client > 0 && client <= MaxClients)
    {
        if(GetClientTeam(client) == CS_TEAM_T)
        {
            return (true);
        }
    }
    else
    {
        return (false);
    }
} 


[Franc1sco]

Edit: the first is better, use the first, the second have a error

[KissLick]

PHP Code:

stock bool:IsClientTeamT(client) 
{ 
    if(client > 0 && client <= MaxClients) 
    { 
        if(GetClientTeam(client) == CS_TEAM_T) 
        { 
            return (true); 
        }
        else
        { 
            // missing return false here ;-)
        }
    } 
    else 
    { 
        return (false); 
    } 
} 


So yeah, the first is better.

EDIT: You also might want to check client validity via IsClientInGame() before GetClientTeam()

[xf117]

It's a matter of style, but the first one usually never better.

PHP Code:

stock bool:IsClientTeamT(client) {

    if (client > 0 && client <= MaxClients) {
        if (IsClientInGame(client)) {
            if (GetClientTeam(client) == CS_TEAM_T) {
                return true;
            }
        }
    }

    return false;
} 


[Mitchell]

Nested if statements

PHP Code:

stock bool:IsClientTeamT(client) {

    if (client > 0 && client <= MaxClients &&
        IsClientInGame(client) &&
        GetClientTeam(client) == CS_TEAM_T) {
        return true;
    }

    return false;
} 


[floube]

Just for more readability (hah)

PHP Code:

stock bool:IsClientTeamT(client) {
    return (client > 0 && client <= MaxClients && IsClientInGame(client) && GetClientTeam(client) == CS_TEAM_T);
}