[Flasher]

PHP Code:

    register_concmd("amx_ban", "cmdBan", ADMIN_BAN|ADMIN_BAN_TEMP, "<name or #userid> <minutes> [reason]")

public cmdBan(id, level, cid)
{
    if (!cmd_access(id, level, cid, 3)) // Pass when user has ADMIN_BAN|ADMIN_BAN_TEMP
        return PLUGIN_HANDLED

    if( ~get_user_flags(id) & ( ADMIN_BAN | ADMIN_RCON ) && (nNum <= 0 || nNum > get_pcvar_num(p_amx_tempban_maxtime)) )
    {
        // Shoundn't be here if user has ADMIN_BAN _OR_ ADMIN_RCON
        // Currently it is not pass here only if user has both ADMIN_BAN _AND_ ADMIN_RCON
        console_print(id, "%L", id, "NO_ACC_COM");
        return PLUGIN_HANDLED
    } 


There is similar code in other places and in plmenu.sma.

[luxor]

Originally Posted by isotonic @luxor: now it's time to check access flag for temp bans and amx_tempban_maxtime cvar ;) That code is fine.

Major => bcefijnopv (i put the acces flag, but it don`t works )


amx_tempban_maxtime 60

[isotonic]

Originally Posted by Black Rose I'm not sure what you're asking. No they don't give the same result.

And it is the reason why original plugins do not work as they should ;)
Flasher has explained nice.
The only question I have why my 'fix' is the same as original)

Originally Posted by Black Rose Afaik, you're supposed to have both flags to be able to access that command. Is this incorrect?

Yes, it is. ADMIN_RCON is here just in case. I think it is from ancient times and it was not carefully coded (for amx_ban you will get 'You have no access to that command' anyway).
To be able to use permanent bans you only need to have ADMIN_BAN flag, temporary ones - ADMIN_BAN_TEMP flag.

[Black Rose]

Originally Posted by isotonic why my 'fix' is the same as original)

It was before you edited your post.

[isotonic]

I just removed 2nd proposed variant. Of course both my variants were the same because they serve the same purpose.

[luxor]

and why flag "v" don`t works ?

that is the acces : Major => bcefijnopv

cvar : amx_tempban_maxtime 60

but it don`t works .


it`s verry annoying, when was the bug with ~get_user_flags(id) & ( ADMIN_BAN | ADMIN_RCON ) it works with flag "d", but now, when i use !get_user_flags(id) & ( ADMIN_BAN | ADMIN_RCON ) it don`t works... why ?

[luxor]

problem solved..
it was my mistake, i forget to change acces on cmdacces.ini

[isotonic]

I told you to do so ;)
Anyway thank you for the response.