[cssBOT]

Bug (umc-rockthevote v3.4.5): Disabling umc-rockthevote with sm_umc_rtv_enabled doesn't fully stop RTV processing.

Running this with SM-GunGame. GG has a feature to trigger disabling RTV at certain level. If you use the cvar sm_umc_rtv_enabled 0 to stop RTV's it blocks any future RTV's but any RTV in progress is still active after the cvar change. Specifically found that despite the default setting sm_umc_rtv_duration "20" (Specifies how long a vote should be available for.) and sm_umc_rtv_enabled set 0 (disabled), that if enough players disconnect so that the number of vote threshold is reached it processes an RTV map change. The 20 second rtv duration and rtv enable setting are ineffectual.

[Bittersweet]

Originally Posted by cssBOT Bug (umc-rockthevote v3.4.5): Disabling umc-rockthevote with sm_umc_rtv_enabled doesn't fully stop RTV processing. Running this with SM-GunGame. GG has a feature to trigger disabling RTV at certain level. If you use the cvar sm_umc_rtv_enabled 0 to stop RTV's it blocks any future RTV's but any RTV in progress is still active after the cvar change. Specifically found that despite the default setting sm_umc_rtv_duration "20" (Specifies how long a vote should be available for.) and sm_umc_rtv_enabled set 0 (disabled), that if enough players disconnect so that the number of vote threshold is reached it processes an RTV map change. The 20 second rtv duration and rtv enable setting are ineffectual.

It looks like UMC is built to ignore changes to sm_umc_rtv_enabled until the next map. From umc-rockthevote.sp:

PHP Code:

cvar_rtv_enable = CreateConVar(
        "sm_umc_rtv_enabled",
        "1",
        "Enables RTV.",
        0, true, 0.0, true, 1.0
    ); 


PHP Code:

HookConVarChange(cvar_rtv_enable, Handle_RTVChange); 


//Called when the cvar to enable RTVs has been changed.
public Handle_RTVChange(Handle:convar, const String:oldVal[], const String:newVal[])
{
    //If the new value is 0, we ignore the change until next map.
    
    //Update (in this case set) the RTV threshold if...
    //    ...the new value of the changed cvar is 1.
    if (StringToInt(newVal) == 1)
        UpdateRTVThreshold();
}

Edit: Looks like you could insert a check of the cvar here and return if disabled:

PHP Code:

//************************************************************************************************//
//                                            COMMANDS                                            //
//************************************************************************************************//

//sm_rtv or sm_rockthevote
public Action:Command_RTV(client, args)
{
    AttemptRTV(client);
    return Plugin_Handled;
} 


Edit 2: Actually, you'd want to do it in AttemptRTV, but it looks like it already is:

PHP Code:

//************************************************************************************************//
//                                          ROCK THE VOTE                                         //
//************************************************************************************************//

//Tries to enter the given client into RTV.
AttemptRTV(client)
{
    //Get the number of clients who have RTV'd.
    new size = GetArraySize(rtv_clients);
    
    if (!rtv_enabled || !GetConVarBool(cvar_rtv_enable) || size >= rtv_threshold || client == 0)
        return; 


Are you sure it's not the regular SM RTV activating?

[cssBOT]

Originally Posted by Bittersweet Are you sure it's not the regular SM RTV activating?

Yes I'm sure it's not. SM RTV is not running.

I Haven't tried to figure out how the plugin works but what it needs to do is when sm_umc_rtv_enabled is set 0, any current RTV's are cleared.

[Bittersweet]

Originally Posted by cssBOT Yes I'm sure it's not. SM RTV is not running. Haven't tried to figure out how it works but what it needs is when sm_umc_rtv_enabled is set 0, it clears and current RTV's.

Yeah, my bad. rtv_enabled isn't set to false except OnConfigsExecuted and when the mapcycle is reloaded. It seems like it was designed this way, looking at the (previous) comment in Handle_RTVChange. This should work to disable RTV as soon as the cvar is changed:

PHP Code:

//Called when the cvar to enable RTVs has been changed.
public Handle_RTVChange(Handle:convar, const String:oldVal[], const String:newVal[])
{
    //If the new value is 0, we immediately disable
   if (StringToInt(newVal) == 0) 
        rtv_enabled = false;
    
    //Update (in this case set) the RTV threshold if...
    //    ...the new value of the changed cvar is 1.
    if (StringToInt(newVal) == 1)
        UpdateRTVThreshold();
} 


[cssBOT]

Originally Posted by Bittersweet Yeah, my bad. rtv_enabled isn't set to false except OnConfigsExecuted and when the mapcycle is reloaded. It seems like it was designed this way, looking at the (previous) comment in Handle_RTVChange. This should work to disable RTV as soon as the cvar is changed:

I already worked around it by just having gg unload the plugin instead of disabling via the cvar.

You should really contact Steell and ask him to allow you assist in developing UMC. I hate to start patching here there too much because it gets painful to track from official releases.

[Bittersweet]

Originally Posted by cssBOT I already worked around it by just having gg unload the plugin instead of disabling via the cvar. You should really contact Steell and ask him to allow you assist in developing UMC. I hate to start patching here there too much because it gets painful to track from official releases.

There is a repository, as listed in the OP: https://github.com/Steell/Ultimate-Mapchooser

There hasn't been an "official" release of UMC since 3.4.5. I'm not familiar enough with the source, and have too many other things on my plate to take on that task at this point, but you are welcome to make pull requests. I just provide support in these forums when I can.

[utaker]

is it any better than "mapchooser extended"

[musosoft]

EDIT: Discovered a way, how to do what I wanted. Only thing I didn't fixed is, that UMC changes map sooner, as CS:GO drops at mapend appear... Does anyone know workaround to this?

[St00ne]

Originally Posted by musosoft EDIT: Discovered a way, how to do what I wanted. Only thing I didn't fixed is, that UMC changes map sooner, as CS:GO drops at mapend appear... Does anyone know workaround to this?

Hi,

You might want to ask this to Powerlord, IF he has time, AND IF he found a solution to this, when making his mapchooser extended compatible for CS:GO.

++

[Wilczek]

Is it possible to start a runoff-vote at the beggening of a new round instead 5 sec delay? I tried to dive into UMC sourcecode, but it looks like black magic to me :/