Giving weapons from a "list"

Floody · **Author**

Hey
what's wrong with this code? I want to give a player a random weapon. I tried this, didn't work. Anyone has an idea why?

PHP Code:


			
    new String:weaponArray[] =
    {
        "weapon_glock",
        "weapon_usp",
        "weapon_mac10",
        "weapon_deagle",
        "weapon_p228"
    };
    new randomNum = GetRandomInt(1, 5);
    GivePlayerItem(client, weaponArray[randomNum]);

Thanks in advance!

RedSword · 03-19-2014 , 20:41 Re: Giving weapons from a "list"

Well, I would start with having a 2 dimensions array. I'm surprised your code compile. A string is already an array. Having many array you have an array of arrays --> [][].

i.e.

Code:

new const String:weaponNames[35][ 16 ] = 
{ 
	"none",			"p228",			"glock",		"scout",
	"hegrenade",	"xm1014",		"c4",			"mac10",
	"aug",			"smokegrenade",	"elite",		"fiveseven",
	"ump45",		"sg550",		"galil",		"famas",
	"usp",			"awp",			"mp5navy",		"m249",
	"m3",			"m4a1",			"tmp",			"g3sg1",
	"flashbang", 	"deagle",		"sg552",		"ak47",
	"knife",		"p90",			"shield",		"vest",
	"vesthelm",		"nvgs",			"defuser"
};

KissLick · 03-20-2014 , 20:06 Re: Giving weapons from a "list"

And the index of array starts at 0, so you should do

PHP Code:


			
new randomNum = GetRandomInt(0, 4);

instead of

PHP Code:


			
new randomNum = GetRandomInt(1, 5);

Root_ · 03-24-2014 , 08:50 Re: Giving weapons from a "list"

Let the array size to be defined by compiler, so

Code:

new const String:weaponNames[][] = 
{ 
    "none",         "p228",         "glock",        "scout",
    "hegrenade",    "xm1014",       "c4",           "mac10",
    "aug",          "smokegrenade"  "elite",        "fiveseven",
    "ump45",        "sg550",        "galil",        "famas",
    "usp",          "awp",          "mp5navy",      "m249",
    "m3",           "m4a1",         "tmp",          "g3sg1",
    "flashbang",    "deagle",       "sg552",        "ak47",
    "knife",        "p90",          "shield",       "vest",
    "vesthelm",     "nvgs",         "defuser"
};

To give random weapon from a list, you can use GetRandomInt(0, sizeof(weaponNames)-1);