[jingojang]

Wait what?

train_punishment Default: Blind
no //Turns punishment off
off //Turns punishment off
none //Turns punishment off

Three commands with the same purpose.

[Pastout]

Originally Posted by jingojang Wait what? train_punishment Default: Blind no //Turns punishment off off //Turns punishment off none //Turns punishment off Three commands with the same purpose.

Yes as you can see...
If the admin changes the cvar to any of thoses it will turn off. Its to make it easier for the admin.

If you read more the other commands have them too.

[Pastout]

Updated added a better checking system.

Added new cvar
train_killangle 145 // 0-180 [Do Not change unless you know what you are doing.]

• kill angle helps detect train kill by checking what angle the killer has killed his victim at.
• The higher the angle the more direct the kill has to be.

[roymor]

Nice plugin never heard this term "train kill" but I know how annoying it is to get killed this way XD

[UchihaSkills]

Why this Plugin dont get approved?

[bristol]

Hello, your plugin "TrainKiller" is magnificent, I delivered it to myself on knife the server, a floor of day everything was excellent, but then it simply was disconnected and in ravines such error - http://rghost.ru/47585155

[Hembi]

Hy!
I'm Hembi.
This plugin so good for my knife server , but not working perfect.

Error log

L 09/11/2013 - 19:090: Start of error session.
L 09/11/2013 - 19:090: Info (map "35hp_2") (file "addons/amxmodx/logs/error_20130911.log")
L 09/11/2013 - 19:090: Invalid player id 147
L 09/11/2013 - 19:090: [AMXX] Displaying debug trace (plugin "trainkiller.amxx")
L 09/11/2013 - 19:090: [AMXX] Run time error 10: native error (native "get_user_weapon")
L 09/11/2013 - 19:090: [AMXX] [0] trainkiller(1).sma::Ham_CBasePlayer_Killed (line 96)
L 09/11/2013 - 19:13:41: Invalid player id 147
L 09/11/2013 - 19:13:41: [AMXX] Displaying debug trace (plugin "trainkiller.amxx")
L 09/11/2013 - 19:13:41: [AMXX] Run time error 10: native error (native "get_user_weapon")
L 09/11/2013 - 19:13:41: [AMXX] [0] trainkiller(1).sma::Ham_CBasePlayer_Killed (line 96)
L 09/11/2013 - 19:22:12: Invalid player id 147
L 09/11/2013 - 19:22:12: [AMXX] Displaying debug trace (plugin "trainkiller.amxx")
L 09/11/2013 - 19:22:12: [AMXX] Run time error 10: native error (native "get_user_weapon")
L 09/11/2013 - 19:22:12: [AMXX] [0] trainkiller(1).sma::Ham_CBasePlayer_Killed (line 96)

Please fix the error.

[HamletEagle]

For approval:

1.Fix the errors.

Originally Posted by Hembi Hy! I'm Hembi. This plugin so good for my knife server , but not working perfect. Error log L 09/11/2013 - 19:090: Start of error session. L 09/11/2013 - 19:090: Info (map "35hp_2") (file "addons/amxmodx/logs/error_20130911.log") L 09/11/2013 - 19:090: Invalid player id 147 L 09/11/2013 - 19:090: [AMXX] Displaying debug trace (plugin "trainkiller.amxx") L 09/11/2013 - 19:090: [AMXX] Run time error 10: native error (native "get_user_weapon") L 09/11/2013 - 19:090: [AMXX] [0] trainkiller(1).sma::Ham_CBasePlayer_Killed (line 96) L 09/11/2013 - 19:13:41: Invalid player id 147 L 09/11/2013 - 19:13:41: [AMXX] Displaying debug trace (plugin "trainkiller.amxx") L 09/11/2013 - 19:13:41: [AMXX] Run time error 10: native error (native "get_user_weapon") L 09/11/2013 - 19:13:41: [AMXX] [0] trainkiller(1).sma::Ham_CBasePlayer_Killed (line 96) L 09/11/2013 - 19:22:12: Invalid player id 147 L 09/11/2013 - 19:22:12: [AMXX] Displaying debug trace (plugin "trainkiller.amxx") L 09/11/2013 - 19:22:12: [AMXX] Run time error 10: native error (native "get_user_weapon") L 09/11/2013 - 19:22:12: [AMXX] [0] trainkiller(1).sma::Ham_CBasePlayer_Killed (line 96) Please fix the error.

2.In Check_Connections you should use new, not static.
3.In Ham_CBasePlayer_Killed:

• Retrieve victim's team before the loop. The same applies for cvars, cache them before looping.
• Instead of looping all players and checking the distance, you should use find_sphere_class. This will give an array of players that meet all the requierements.
• Creating variables inside a loop it's not a good ideea. Ok, they are static and will be initialized only one time, but it can confuse beginners when they see this. For consistency, I would like you to declare them outside the loop and make them "new".

4.Since GetPunishMethod is called from a loop the vars should be static.
5.Add ML please.
6.Add the cvars description inside the source file, it will be easier for the end user.
7.Destroy the trie in plugin_end. While AMXX should free all handles automatically, it's a good habit to do it yourself, and that way you will be sure that you don't waste memory. At the end, I am not sure how usefull your trie is, you could create a const and save what you need, the difference is anyway trivial.
Only this for now, we'll see later.

[HamletEagle]

No changes, unapproved. You can PM me after you update the plugin.