[andrzN]

Hey Everyone!

I've got a problem on my server, and the problem is that the server gets a small lagg spike that
everyone on the server feels when someone write "/rank" in chat.

I will post the code I use for my rank below, and I was wondering what I can change to make the lagg
dissepear when someone say /rank, and if it's not possible to do so, do you have any suggestions to what I can do instead to solve this problem?

Thanks!

PHP Code:

register_clcmd("say /rank", "CmdHideRank"); 


PHP Code:

public CmdHideRank(id)
{
    
    if( g_bUsedRank[id] )
    {
        Print(id, "Do not use this command to often !");
    }
    
    CmdRank(id);
    g_bUsedRank[id] = true;
    return PLUGIN_HANDLED;
} 


PHP Code:

public CmdRank(id)
{
    new Array:aNames, Array:aAuths, Array:aXPs;
    new iTotal = SortTopPlayers(aNames, aAuths, aXPs);
    
    new szAuth[35];
    get_user_authid(id, szAuth, charsmax(szAuth));
    
    new szAuth2[35], i;
    for( i = 0; i < iTotal; i++ )
    {
        ArrayGetString(aAuths, i, szAuth2, charsmax(szAuth2));
        
        if( equal(szAuth, szAuth2) )
        {
            new szData[256], szXP[11];
            nvault_get(g_iVault, szAuth2, szData, charsmax(szData));
            parse(szData, szXP, charsmax(szXP));
            Print(id, "Your rank is^x01 %i^x03 of^x01 %i^x03 with^x04 %i points", (i + 1), iTotal, str_to_num(szXP));
            break;
        }
    }
    
    ArrayDestroy(aNames);
    ArrayDestroy(aAuths);
    ArrayDestroy(aXPs);
} 


[ConnorMcLeod]

How many threads are you going to create for this ?

[andrzN]

Originally Posted by ConnorMcLeod How many threads are you going to create for this ?

I made two, I first made one in the other section, but then I figured this might be the right section so I posted it here instead. And it wasn't possible to delete the other thread, so thats why

[jimaway]

post SortTopPlayers

[Liverwiz]

There is probably a better way than using Dynamic Arrays and all of the natives required for that.
I see you use nvault as your data structure....SQL will also be faster because it has sorting functions built into it. simply "SELECT name, sid, xp FROM xp_table ORDER BY xp DESC;"

Then print your query to your html document.

[claudiuhks]

Try to use MySQL.

[andrzN]

Okey, I don't know how to change the saving / loading code, and I don't know how to make it save in mysql instead of nvault..
I'll upload the plugin here, and if theres any of you that have a little time to help me, I would really appreciate it a lot! Thanks!

I would rather like it to be in normal nvault instead of mysql, if thats possible

[Arkshine]

No wonder why it lags, you create 3 dynamic arrays each time and inserts probably a lot of entries + read nvault file at the same time. Inserting in a dynamic array is very slow. You should cache more datas, like pre-loading any necessary datas at map start from nvault file in some vars, dealing/updating datas with these vars, and saving in nvault file on change map or something.

[andrzN]

Originally Posted by Arkshine No wonder why it lags, you create 3 dynamic arrays each time and inserts probably a lot of entries + read nvault file at the same time. Inserting in a dynamic array is very slow. You should cache more datas, like pre-loading any necessary datas at map start from nvault file in some vars, dealing/updating datas with these vars, and saving in nvault file on change map or something.

I think I understand what you mean. But you should know I didn't code this plugin myself, I'm not nearly good enough to code.
I have no idea how to fix what you said was wrong, I am abseloutely blank on that area.

Do you think you could do it for me? If no, I still appreaciate your help, thanks!

[claudiuhks]

I think you have to post that at Requests category.