[teh ORiON]

Hi,

Since hooking CBasePlayer::Killed with Ham_Killed makes TFC(Team Fortress Classic) hang/crash under windows, here is an alternative way using Orpheu which works incase someone out there would need it.

JSON file:

PHP Code:

{
    "name"      : "Killed",
    "class"     : "CBasePlayer",
    "library"   : "mod",
    "arguments" : 
    [
        {
            "type" : "entvars_s *"
        },
        {
            "type" : "entvars_s *"
        },
        {
            "type" : "int"
        }
    ],
    "indexes" : 
    [
        {
            "os"    : "windows",
            "mod"   : "tfc",
            "value" : 14
        },
        {
            "os"    : "linux",
            "mod"   : "tfc",
            "value" : 16
        }
    ]
} 


Test plugin:

PHP Code:

#include <amxmodx>
#include <amxmisc>
#include <orpheu>

public plugin_init()
{
    new OrpheuFunction:Player_Killed = OrpheuGetFunctionFromClass("player","Killed", "CBasePlayer" ) 
    OrpheuRegisterHook(Player_Killed,"Killed",OrpheuHookPre) 
}

public Killed(idvictim,idattacker,shouldgib)
{
    new victim[32],attacker[32]
    get_user_name(idvictim, victim, 31)     
    get_user_name(idattacker, attacker, 31) 
    
    client_print(0,print_chat,"%s was killed by %s",victim,attacker)
} 


Regards,
ORiON.

[bibu]

Nice find and thanks for sharing! There should be especially a thread with updated events for TFC, since most of them don't work.

[Arkshine]

It's weird virtual functions doesn't work with Ham, but with Orpheu. -_-
I'm a little curious to know why it happens, will try to investigate.

[teh ORiON]

Originally Posted by Arkshine It's weird virtual functions doesn't work with Ham, but with Orpheu. -_- I'm a little curious to know why it happens, will try to investigate.

Ok so I also got hooked on finding out why it happens. My initial assumption was that HAM was hooking with bad arguments, and I was right. It turns out that TFC actually take an extra parameter in CBasePlayer::Killed(entvars_s*,entvars_s*,int ). As opposed to CS and possibly other mods that only take two, eg. CBasePlayer::Killed(entvars_s*,int).

I didn't stop here though. I went through HAM's source and changed it so that it could handle the extra parameter, compiled the module and thus ::Killed started working in TFC as expected.

Of course it would seem that HAM would need an update to handle different arguments for the same functions. Anyway there you have it! Bad arguments.

[Arkshine]

Yes, I've noticed that later too.
Will update here : https://forums.alliedmods.net/showpo...9&postcount=34 ;

It was the case for SendWeaponAnim in CS where one param was removed compared to the original one, which was crashing the thing, so you would need to create Ham_CS_SendWeaponAnim.

[teh ORiON]

Originally Posted by Arkshine Yes, I've noticed that later too. Will update here : https://forums.alliedmods.net/showpo...9&postcount=34 ; It was the case for SendWeaponAnim in CS where one param was removed compared to the original one, which was crashing the thing, so you would need to create Ham_CS_SendWeaponAnim.

Alright, cool! So it will be added as Ham_TFC_Killed or so?

[Arkshine]

Yes, Ham_TFC_Killed.

I won't mind if you would test the others TFC functions.