[SGG]

After having a look for something to do this, I couldn't find one exactly like it, so found out how to build it myself.

Feature list:
On entering ghost mode, it sets SI health back to it's maximum value determined by the appropriate z_xxx_health cvar.

CVAR/Command list:
l4d2_ghost_hp_restore_smoker (Default of 1, determines if smoker hp restore is enabled, 1 for yes, 0 for no)

l4d2_ghost_hp_restore_boomer (Default of 1)

l4d2_ghost_hp_restore_hunter (Default of 1)

l4d2_ghost_hp_restore_spitter (Default of 1)

l4d2_ghost_hp_restore_jockey (Default of 1)

l4d2_ghost_hp_restore_charger (Default of 1)

Changelog:
2012-03-28 (0.2)

• Fixes/changes as suggested by Dont Fear The Reaper
• Changed Cvars so you can enable/disable individual SI ghost health restore

2012-03-26 (0.1)

• Initial release

Installation instructions:
Will auto generate a cfg file if needed, no special install instructions

Dependencies:
Requires Left4Downtown2

Plans:
None, unless someone has a good idea.

[Dont Fear The Reaper]

Nice idea and plugin

Just some minor things i noticed:


- For consistency:

The topics name "[L4D2] Ghost HP restore", the plugins filename "L4D2_Ghost_HP_Regen" and the cvars "l4d2_ghost_HP_regen_enabled" and "l4d2_Ghost_HP_regen_version" have different usage of capitals and restore/regen.
My suggestion is for topic and plugin name (the name in the plugin info, you don't need underscores there) use "[L4D2] Ghost HP Regen" and for filename, config name and cvars just lowercase like "l4d2_ghost_hp_regen...".


- You might have forgot to check the cvar descriptions again

Could be something like "Disable/Enable the '[L4D2] Ghost HP Regen' plugin" and "Version of the '[L4D2] Ghost HP Regen' plugin".


- You can get the handle to the cvar directly from "CreateConVar()", so you don't need the "FindConVar()" there:

H_GhostHPRegenEnabled = CreateConVar("l4d2_ghost_HP_regen_enabled"...);

- Not sure if you do, but if you want the config file to have the same name as the plugin, just use:

AutoExecConfig(true, "l4d2_ghost_hp_regen");

- If you want the plugin to only work in L4D2, you could add a game check at the start of "OnPluginStart()" like:

public OnPluginStart()
{
        decl String:sGame[16];
        GetGameFolderName(sGame, sizeof(sGame));
        if (!StrEqual(sGame, "left4dead2", false))
        {
            SetFailState("Plugin supports 'Left 4 Dead 2' only.");
        }

        CreateConVar...

But as i said it's just minor things, nothing affecting the functionality of the plugin. Good job, thanks for sharing

[SGG]

Yeah, I guess most of those come from what was (for me), a rush job of 20 mins.

All of your suggestions have been implemented (fixing the names, CaPitaLIzaTIOn, etc), and added in the l4d2 check code. I also changed it from being an all or nothing, to individual yes/no for each SI health restore.

[Dont Fear The Reaper]

That "all or nothing" just made me think of making the cvars not work as on/off, but as percentages to restore the lost hp. 0 would add nothing and 1 would add all the lost hp back, like in the following equation:

(hp to set) = (current hp) + ( (max hp) - (current hp) ) * (cvar value)

    200     =      150     + (    250   -     150      ) *     0.5    (as example for 50% restore)

But i'm not sure if it's worth the effort since it's fine as it is now and that might not get used much anyway. As i said it just came to my mind, so don't see it as a request

[disawar1]

you can use a basic API function.

PHP Code:

stock SetEntityHealth(entity, amount)

/**
 * Sets an entity's health
 *
 * @param entity    Entity index.
 * @param amount    Health amount.
 * @noreturn
 * @error            Invalid entity index, or lack of mod compliance.
 *