[TnTSCS]

I just read through that coding style and I've worked my way through all of those bad habits - I still need to work on 2 or so areas of style, but I went through the no brackets around single statement if junk... I'm back to using brackets on all

[Thrawn2]

i don't really see how

PHP Code:

    if (gaben)
    {
        hello
    } 


has a better readability than

PHP Code:

    if (gaben) {
        hello
    } 


i would argue the other way around tbh. and it's usually the first thing i 'fix' about code i get my hands on.
would really like an explanation why it's better so i have a motivation to get rid of this ocd.

completely agree on all the other stuff.

[asherkin]

Originally Posted by Thrawn2 i would argue the other way around tbh. and it's usually the first thing i 'fix' about code i get my hands on. would really like an explanation why it's better so i have a motivation to get rid of this ocd. completely agree on all the other stuff.

PHP Code:

if (gaben1
 || gaben2
 || gaben3
 || gaben4) {
    gaben5
} 


PHP Code:

if (gaben1
 || gaben2
 || gaben3
 || gaben4)
{
    gaben5
} 


[Dr. McKay]

Originally Posted by Lord Canistra Nah, real beginners always write brackets since they don't know those aren't always required.

This is true. I started out with PHP, and I didn't know that the brackets weren't always required. Then I found out that they're not required, tried it out a little bit, and didn't like it. So I always use brackets.

But I do put the opening brace on the same line as the if (mainly because that's how the PHP people do it [check out the examples section]).

[napalm00]

The "all-in-one-line" structure

PHP Code:

if(gaben) { 


was mainly used in the past from the "oldschool" programmers, back in the days when they had screens/text editors with only a few rows, so as you can see writing the open bracket on the same line would help saving some space.
Nowadays we have giant screens and text editors with plenty of lines, so that structure is not used that often anymore.

[Dreamy]

any experienced coder would say that:

PHP Code:

if (a > b)
    b = 1; 


is way better than

PHP Code:

if (a > b)
{
    b = 1;
} 


since you save 2 lines for >no< readability costs! while writing those brackets (+other habits like those) easily add up in a big program to 50-100 extra lines.

while:

PHP Code:

if (a > b) {
    b = 1;
} 


is just an ugly exuse between both. (dunno why, but i see this phenomenon only in java code)

Well in the end brackets dont have ANY impact on the execution time of the program.
So its just a matter of taste afterall...

[Dr. McKay]

Originally Posted by Dreamy any experienced coder would say that: PHP Code: if (a > b)     b = 1;  is way better than PHP Code: if (a > b) {     b = 1; }  since you save 2 lines for >no< readability costs! while writing those brackets (+other habits like those) easily add up in a big program to 50-100 extra lines. while: PHP Code: if (a > b) {     b = 1; }  is just an ugly exuse between both. (dunno why, but i see this phenomenon only in java code)

Until you happen to need to add another line in your if statement. Who cares how many lines it takes? The compiled program is the same either way.

And "ugly" is a subjective term.

[asherkin]

Originally Posted by Dreamy any experienced coder would say

Hi. No.

[Dreamy]

PHP Code:

if (Condition)
   if (otherCondition)
      callSomething();
   else
      if (yetAnotherCondition)
         callSomethingElse(); 


PHP Code:

if (Condition)
{
   if (otherCondition)
   {
      callSomething();
   }
   else
   {
      if (yetAnotherCondition)
      {
          callSomethingElse();
      }
   }
} 


PHP Code:

if (Condition) {
   if (otherCondition) {
      callSomething();
   }
   else {
      if (yetAnotherCondition) {
          callSomethingElse();
      }
   }
} 


which one did you read the fastest? Be honest!
And for asherkin: rephrase -> MOST experienced coders would say...

[asherkin]

Originally Posted by Dreamy which one did you read the fastest? Be honest!

The middle one, seriously, since I could just glance over it and see what was conditions.
EDIT: While the examples were all single line condition -> single line block, you need to look at multi-line examples for the real benefit. See my previous post.

Personally, I prefer the last one however.