[shaliwahan]

Then why did you ask if it will work when you know it works?

Because it throws some warnings.. + GHW said that he does not want to made the code more complex, so shared that its working and its just 5-6 lines extra from the original code.. + Wanted to ask if there is a better way to do this or what I have done is perfectly fine? + On all these previous pages many users have asked for the same but none cared to explain them how to do it, I just gave a start..
That's what is community is for.. Sharing and helping....

No offense..

[fysiks]

Originally Posted by shaliwahan Because it throws some warnings.. + GHW said that he does not want to made the code more complex, so shared that its working and its just 5-6 lines extra from the original code.. + Wanted to ask if there is a better way to do this or what I have done is perfectly fine? + On all these previous pages many users have asked for the same but none cared to explain them how to do it, I just gave a start.. That's what is community is for.. Sharing and helping.... No offense..

As far as efficiency goes it is a negligible change. About the warnings, we can't help you fix the warnings if you don't tell us what they are or you post your whole code (as an attachment).

[shaliwahan]

Here you go.. Attached the sma.. Custom version..
Checks for gungame enabled else number of players else regular vote.
I get a couple of warnings while compiling..

Thank you for your help...


NOTE: THIS IS NOT THE EXACT SAME VERSION THAT GHW CREATED.. I HAVE EDITED IT AS PER MY REQUIREMENTS.

[fysiks]

It's because your indenation is done very poorly.

PHP Code:

        if (get_cvar_num("gg_enabled"))
        {
        get_configsdir(configfile,199)
        format(configfile,199,"%s/custom_nextmaps_gungame.ini",configfile)
        }
    else if    (get_playersnum() < 13)
        {
        get_configsdir(configfile,199)
        format(configfile,199,"%s/custom_nextmaps_small.ini",configfile)
        }
    else
        {
        get_configsdir(configfile,199)
        format(configfile,199,"%s/custom_nextmaps.ini",configfile)
        } 


PHP Code:

    if (get_cvar_num("gg_enabled"))
    {
        get_configsdir(configfile,199)
        format(configfile,199,"%s/custom_nextmaps_gungame.ini",configfile)
    }
    else if (get_playersnum() < 13)
    {
        get_configsdir(configfile,199)
        format(configfile,199,"%s/custom_nextmaps_small.ini",configfile)
    }
    else
    {
        get_configsdir(configfile,199)
        format(configfile,199,"%s/custom_nextmaps.ini",configfile)
    } 


[shaliwahan]

Ahahaha.... thanks...
Never took indenation seriously.. will take it from now in

[fysiks]

Originally Posted by shaliwahan Ahahaha.... thanks... Never took indenation seriously.. will take it from now in

Proper indentation is very important for readability and if you ever want people to help you with your code/plugins.

[RTG]

shaliwahan i like your work, please could you post your code here? or PM me, thanks

[shaliwahan]

Ok! Here we go.. As requested by RTG and other..

The main plugin and the version attached here differs the following changes..

• Added 3 different conditions for votes.
• Added empty server random map from maps file
• Changed version from 1.4d to 1.4f

Files

custom_nextmaps_gungame.ini
To be used in the same way as defined on the first page. Used only when gungame is active.

custom_nextmaps_small.ini
Used when the total number of players are less then 15 when the vote starts.

custom_nextmaps.ini
Default file used in all other cased except the above two mentioned.

Note: Whenever the server is empty and no one votes, a random map is chosen from custom_nextmaps_small.ini

For more details on how to use this plugin see the first page of this thread.

[RTG]

what do you mean by this? thanks

Added 3 different conditions for votes.

[shaliwahan]

Originally Posted by RTG what do you mean by this?

1. GunGame Active/In-Active
2. Players less then 15
3. None of the above